Skip to contentSkip to conversation

xfs: remove SYNC_WAIT and SYNC_TRYLOCK

PATCH In review Christoph Hellwig 4 participants 4 messages Jul 10, 2020 – Jul 13, 2020 XFS filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs: remove SYNC_WAIT and SYNC_TRYLOCK

These two definitions are unused now.

---
 fs/xfs/xfs_icache.h | 3 ---
 1 file changed, 3 deletions(-)
fs/xfs/xfs_icache.h +0 -3
index ae92ca53de423f..3a4c8b382cd0fe 100644
@@ -17,9 +17,6 @@ struct xfs_eofblocks {
 	__u64		eof_min_file_size;
 };
 
-#define SYNC_WAIT		0x0001	/* wait for i/o to complete */
-#define SYNC_TRYLOCK		0x0002  /* only try to lock inodes */
-
 /*
  * tags for inode radix tree
  */
Signature · 1 line
2.26.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 12 lines · Christoph Hellwig

These two definitions are unused now.

---
 fs/xfs/xfs_icache.h | 3 ---
 1 file changed, 3 deletions(-)
fs/xfs/xfs_icache.h +0 -0
index ae92ca53de423f..3a4c8b382cd0fe 100644

fs/xfs/xfs_icache.h struct xfs_eofblocks { · line 21

Quoted 5 lines
fs/xfs/xfs_icache.h +0 -2
@@ -17,9 +17,6 @@ struct xfs_eofblocks {
 	__u64		eof_min_file_size;
 };
 
-#define SYNC_WAIT		0x0001	/* wait for i/o to complete */
-#define SYNC_TRYLOCK		0x0002  /* only try to lock inodes */

Oh, I didn't realise they'd been removed from the EOF block scanner. I was too busy removing them from inode reclaim to notice this had occurred.

Looks good.

Signature · 2 lines
Dave Chinner
[email protected]
Reviewed-by on v1 1/1
#3 lore raw
In reply to Christoph Hellwig
Quoted 3 lines · Christoph Hellwig

These two definitions are unused now.

Looks ok,

--D

Quoted 21 lines
---
 fs/xfs/xfs_icache.h | 3 ---
 1 file changed, 3 deletions(-)
fs/xfs/xfs_icache.h +0 -3
index ae92ca53de423f..3a4c8b382cd0fe 100644
@@ -17,9 +17,6 @@ struct xfs_eofblocks {
 	__u64		eof_min_file_size;
 };
 
-#define SYNC_WAIT		0x0001	/* wait for i/o to complete */
-#define SYNC_TRYLOCK		0x0002  /* only try to lock inodes */
-
 /*
  * tags for inode radix tree
  */
Signature · 1 line
2.26.2