Skip to contentSkip to conversation

MAINTAINERS: Add Python library stanza

PATCH Superseded John Snow 5 participants 9 messages Jul 10, 2020 – Jul 20, 2020

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

John Snow

author
#0 lore raw

cover MAINTAINERS: Add Python library stanza

John Snow (1):
MAINTAINERS: Add Python library stanza

 MAINTAINERS | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
Signature · 1 line
2.21.3
author
#1 lore raw

PATCH 1/1 MAINTAINERS: Add Python library stanza

I'm proposing that I split the actual Python library off from the other miscellaneous python scripts we have and declare it maintained. Add myself as a maintainer of this folder, along with Cleber.

---
 MAINTAINERS | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
MAINTAINERS +8 -1
index 6aa54f7f8f..fe1dcd5a76 100644
@@ -2280,11 +2280,18 @@ S: Maintained
 F: include/sysemu/cryptodev*.h
 F: backends/cryptodev*.c
 
+Python library
+M: John Snow <[email protected]>
+M: Cleber Rosa <[email protected]>
+R: Eduardo Habkost <[email protected]>
+S: Maintained
+F: python/*
+T: git https://gitlab.com/jsnow/qemu.git python
+
 Python scripts
 M: Eduardo Habkost <[email protected]>
 M: Cleber Rosa <[email protected]>
 S: Odd fixes
-F: python/qemu/*py
 F: scripts/*.py
 F: tests/*.py
 
Signature · 1 line
2.21.3
Reviewed-by Tested-by on v1 1/1
#2 lore raw
Quoted 24 lines · John Snow

I'm proposing that I split the actual Python library off from the other miscellaneous python scripts we have and declare it maintained. Add myself as a maintainer of this folder, along with Cleber.

---
 MAINTAINERS | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
MAINTAINERS +6 -0
index 6aa54f7f8f..fe1dcd5a76 100644
@@ -2280,11 +2280,18 @@ S: Maintained
 F: include/sysemu/cryptodev*.h
 F: backends/cryptodev*.c
 
+Python library
+M: John Snow <[email protected]>
+M: Cleber Rosa <[email protected]>
+R: Eduardo Habkost <[email protected]>
+S: Maintained
+F: python/*

MAINTAINERS S: Maintained · line 2297

Quoted 10 lines
MAINTAINERS +2 -1
+T: git https://gitlab.com/jsnow/qemu.git python
+
 Python scripts
 M: Eduardo Habkost <[email protected]>
 M: Cleber Rosa <[email protected]>
 S: Odd fixes
-F: python/qemu/*py
 F: scripts/*.py
 F: tests/*.py
 
Reviewed-by on v1 1/1
#3 lore raw
In reply to John Snow
Quoted 14 lines · John Snow

I'm proposing that I split the actual Python library off from the other miscellaneous python scripts we have and declare it maintained. Add myself as a maintainer of this folder, along with Cleber.

---
 MAINTAINERS | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
MAINTAINERS +0 -0
index 6aa54f7f8f..fe1dcd5a76 100644

MAINTAINERS S: Maintained · line 2288

Quoted 9 lines
MAINTAINERS +6 -0
@@ -2280,11 +2280,18 @@ S: Maintained
 F: include/sysemu/cryptodev*.h
 F: backends/cryptodev*.c
 
+Python library
+M: John Snow <[email protected]>
+M: Cleber Rosa <[email protected]>
+R: Eduardo Habkost <[email protected]>
+S: Maintained
+F: python/*

I don't think that's equivalent to what you drop bellow:

F: drivers/net/ all files in and below drivers/net
F: drivers/net/* all files in drivers/net, but not below

So I think you should drop the *

MAINTAINERS S: Maintained · line 2296

Quoted 9 lines
MAINTAINERS +2 -1
+T: git https://gitlab.com/jsnow/qemu.git python
+
 Python scripts
 M: Eduardo Habkost <[email protected]>
 M: Cleber Rosa <[email protected]>
 S: Odd fixes
-F: python/qemu/*py
 F: scripts/*.py
 F: tests/*.py

Otherwise:

Signature · 1 line
Alex Bennée
author
#4 lore raw
Quoted 29 lines · Alex Bennée
Quoted 14 lines · John Snow

I'm proposing that I split the actual Python library off from the other miscellaneous python scripts we have and declare it maintained. Add myself as a maintainer of this folder, along with Cleber.

---
 MAINTAINERS | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
MAINTAINERS +0 -0
index 6aa54f7f8f..fe1dcd5a76 100644

MAINTAINERS S: Maintained · line 2288

Quoted 9 lines
MAINTAINERS +6 -0
@@ -2280,11 +2280,18 @@ S: Maintained
 F: include/sysemu/cryptodev*.h
 F: backends/cryptodev*.c
 
+Python library
+M: John Snow <[email protected]>
+M: Cleber Rosa <[email protected]>
+R: Eduardo Habkost <[email protected]>
+S: Maintained
+F: python/*

I don't think that's equivalent to what you drop bellow:

Quoted 5 lines

F: drivers/net/ all files in and below drivers/net
F: drivers/net/* all files in drivers/net, but not below

So I think you should drop the *

I didn't realize that, thanks for correcting it.

Quoted 12 lines

MAINTAINERS S: Maintained · line 2296

Quoted 9 lines
MAINTAINERS +2 -1
+T: git https://gitlab.com/jsnow/qemu.git python
+
 Python scripts
 M: Eduardo Habkost <[email protected]>
 M: Cleber Rosa <[email protected]>
 S: Odd fixes
-F: python/qemu/*py
 F: scripts/*.py
 F: tests/*.py

Otherwise:

Quoted 2 lines

I swear I talked to Cleber and Eduardo before sending this, we'll wait for them to say hi :)

#5 lore raw
Quoted 30 lines · John Snow
Quoted 29 lines · Alex Bennée
Quoted 14 lines · John Snow

I'm proposing that I split the actual Python library off from the other miscellaneous python scripts we have and declare it maintained. Add myself as a maintainer of this folder, along with Cleber.

---
 MAINTAINERS | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
MAINTAINERS +0 -0
index 6aa54f7f8f..fe1dcd5a76 100644

MAINTAINERS S: Maintained · line 2288

Quoted 9 lines
MAINTAINERS +6 -0
@@ -2280,11 +2280,18 @@ S: Maintained
 F: include/sysemu/cryptodev*.h
 F: backends/cryptodev*.c
 
+Python library
+M: John Snow <[email protected]>
+M: Cleber Rosa <[email protected]>
+R: Eduardo Habkost <[email protected]>
+S: Maintained
+F: python/*

I don't think that's equivalent to what you drop bellow:

Quoted 4 lines
Quoted 4 lines

F: drivers/net/ all files in and below drivers/net
F: drivers/net/* all files in drivers/net, but not below

So I think you should drop the *

I can fix that if I do the next python pull req.

Quoted 22 lines
Quoted 1 line

I didn't realize that, thanks for correcting it.

Quoted 12 lines

MAINTAINERS S: Maintained · line 2296

Quoted 9 lines
MAINTAINERS +2 -1
+T: git https://gitlab.com/jsnow/qemu.git python
+
 Python scripts
 M: Eduardo Habkost <[email protected]>
 M: Cleber Rosa <[email protected]>
 S: Odd fixes
-F: python/qemu/*py
 F: scripts/*.py
 F: tests/*.py

Otherwise:

Quoted 2 lines

I swear I talked to Cleber and Eduardo before sending this, we'll wait for them to say hi :)

#6 lore raw
In reply to John Snow
Quoted 52 lines · John Snow
Quoted 29 lines · Alex Bennée
Quoted 14 lines · John Snow

I'm proposing that I split the actual Python library off from the other miscellaneous python scripts we have and declare it maintained. Add myself as a maintainer of this folder, along with Cleber.

---
 MAINTAINERS | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
MAINTAINERS +0 -0
index 6aa54f7f8f..fe1dcd5a76 100644

MAINTAINERS S: Maintained · line 2288

Quoted 9 lines
MAINTAINERS +6 -0
@@ -2280,11 +2280,18 @@ S: Maintained
 F: include/sysemu/cryptodev*.h
 F: backends/cryptodev*.c
 
+Python library
+M: John Snow <[email protected]>
+M: Cleber Rosa <[email protected]>
+R: Eduardo Habkost <[email protected]>
+S: Maintained
+F: python/*

I don't think that's equivalent to what you drop bellow:

Quoted 5 lines

F: drivers/net/ all files in and below drivers/net
F: drivers/net/* all files in drivers/net, but not below

So I think you should drop the *

I didn't realize that, thanks for correcting it.

Quoted 12 lines

MAINTAINERS S: Maintained · line 2296

Quoted 9 lines
MAINTAINERS +2 -1
+T: git https://gitlab.com/jsnow/qemu.git python
+
 Python scripts
 M: Eduardo Habkost <[email protected]>
 M: Cleber Rosa <[email protected]>
 S: Odd fixes
-F: python/qemu/*py
 F: scripts/*.py
 F: tests/*.py

Otherwise:

Quoted 5 lines
Quoted 2 lines

I swear I talked to Cleber and Eduardo before sending this, we'll wait for them to say hi :)

You did! And I'm happy to see you are volunteering to replace me as maintainer on many of those files.

Signature · 1 line
Eduardo
author
#7 lore raw
In reply to Alex Bennée
Quoted 46 lines · Alex Bennée
Quoted 14 lines · John Snow

I'm proposing that I split the actual Python library off from the other miscellaneous python scripts we have and declare it maintained. Add myself as a maintainer of this folder, along with Cleber.

---
 MAINTAINERS | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
MAINTAINERS +0 -0
index 6aa54f7f8f..fe1dcd5a76 100644

MAINTAINERS S: Maintained · line 2288

Quoted 9 lines
MAINTAINERS +6 -0
@@ -2280,11 +2280,18 @@ S: Maintained
 F: include/sysemu/cryptodev*.h
 F: backends/cryptodev*.c
 
+Python library
+M: John Snow <[email protected]>
+M: Cleber Rosa <[email protected]>
+R: Eduardo Habkost <[email protected]>
+S: Maintained
+F: python/*

I don't think that's equivalent to what you drop bellow:

F: drivers/net/ all files in and below drivers/net
F: drivers/net/* all files in drivers/net, but not below

So I think you should drop the *

MAINTAINERS S: Maintained · line 2296

Quoted 9 lines
MAINTAINERS +2 -1
+T: git https://gitlab.com/jsnow/qemu.git python
+
 Python scripts
 M: Eduardo Habkost <[email protected]>
 M: Cleber Rosa <[email protected]>
 S: Odd fixes
-F: python/qemu/*py
 F: scripts/*.py
 F: tests/*.py

Otherwise:

Quoted 2 lines

ACK on the edit, I think otherwise I'm still technically waiting for Cleber to approve this before I would ask for someone to stage it.

--js

#8 lore raw
In reply to John Snow
Quoted 15 lines · John Snow

I'm proposing that I split the actual Python library off from the other miscellaneous python scripts we have and declare it maintained. Add myself as a maintainer of this folder, along with Cleber.

---
 MAINTAINERS | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
MAINTAINERS +0 -0
index 6aa54f7f8f..fe1dcd5a76 100644
@@ -2280,11 +2280,18 @@ S: Maintained
 F: include/sysemu/cryptodev*.h

MAINTAINERS S: Maintained · line 2290

Quoted 10 lines
MAINTAINERS +8 -0
 F: backends/cryptodev*.c
 
+Python library
+M: John Snow <[email protected]>
+M: Cleber Rosa <[email protected]>
+R: Eduardo Habkost <[email protected]>
+S: Maintained
+F: python/*
+T: git https://gitlab.com/jsnow/qemu.git python
+

Thanks for this, and for that will come next! :)