watchdog: pcwd_usb: remove needless check before usb_free_coherent()
PATCH 1/1 watchdog: pcwd_usb: remove needless check before usb_free_coherent()
usb_free_coherent() is safe with NULL usb_pcwd->intr_buffer and this check is not required.
Signed-off-by Xu Wang <[email protected]>
--- drivers/watchdog/pcwd_usb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/watchdog/pcwd_usb.c +2 -3
@@ -585,9 +585,8 @@ static struct notifier_block usb_pcwd_notifier = {static inline void usb_pcwd_delete (struct usb_pcwd_private *usb_pcwd) {usb_free_urb (usb_pcwd->intr_urb); -if (usb_pcwd->intr_buffer !=NULL ) -usb_free_coherent (usb_pcwd->udev, usb_pcwd->intr_size, - usb_pcwd->intr_buffer, usb_pcwd->intr_dma); +usb_free_coherent (usb_pcwd->udev, usb_pcwd->intr_size, + usb_pcwd->intr_buffer, usb_pcwd->intr_dma);kfree (usb_pcwd); }
Signature · 1 line
2.17.1
Quoted 4 lines · Xu Wang
usb_free_coherent()is safe with NULLusb_pcwd->intr_bufferand this check is not required.Signed-off-by Xu Wang <[email protected]>
Reviewed-by Guenter Roeck <[email protected]>
Quoted 20 lines
--- drivers/watchdog/pcwd_usb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/watchdog/pcwd_usb.c +2
-3@@ -585,9 +585,8 @@ static struct notifier_block usb_pcwd_notifier = {static inline void usb_pcwd_delete (struct usb_pcwd_private *usb_pcwd) {usb_free_urb (usb_pcwd->intr_urb); -if (usb_pcwd->intr_buffer !=NULL ) -usb_free_coherent (usb_pcwd->udev, usb_pcwd->intr_size, - usb_pcwd->intr_buffer, usb_pcwd->intr_dma); +usb_free_coherent (usb_pcwd->udev, usb_pcwd->intr_size, + usb_pcwd->intr_buffer, usb_pcwd->intr_dma);kfree (usb_pcwd); }