ram: rk3399: Drop debug stride in driver
PATCH 1/3 ram: rk3399: Drop debug stride in driver
stride debug is already present in sdram_common.c via RAM_ROCKCHIP_DEBUG.
So, drop the redundant debug stride code in rk3399 driver.
--- drivers/ram/rockchip/sdram_rk3399.c | 25 ------------------------- 1 file changed, 25 deletions(-)
drivers/ram/rockchip/sdram_rk3399.c +0 -25
@@ -2875,31 +2875,6 @@ static unsigned char calculate_stride(struct rk3399_sdram_params *params)if (stride == (-1 )) goto error; } -switch (stride) { -case 0xc : -printf ("128B stride\n" ); -break ; -case 5 : -case 9 : -case 0xd : -case 0x11 : -case 0x19 : -printf ("256B stride\n" ); -break ; -case 0xa : -case 0xe : -case 0x12 : -printf ("512B stride\n" ); -break ; -case 0xf : -printf ("4K stride\n" ); -break ; -case 0x1f : -printf ("32MB + 256B stride\n" ); -break ; -default : -printf ("no stride\n" ); - }sdram_print_stride (stride);
Signature · 1 line
2.25.1
PATCH 2/3 ram: rk3399: Mark existing prints via RAM_ROCKCHIP_DEBUG
Right now all these debug statements are printing on the console to make sure proper dram initialization happens.
Mark them into RAM_ROCKCHIP_DEBUG would be more meaningful and work like before since the RAM_ROCKCHIP_DEBUG is by default yet.
No functionality changes.
--- drivers/ram/rockchip/sdram_rk3399.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)
drivers/ram/rockchip/sdram_rk3399.c +8 -4
@@ -2551,8 +2551,10 @@ static int lpddr4_set_rate(struct dram_info *dram,lpddr4_set_ctl (dram, params, ctl_fn, dfs_cfgs_lpddr4[ctl_fn].base.ddr_freq); -printf ("%s: change freq to %d mhz %d, %d\n" , __func__, - dfs_cfgs_lpddr4[ctl_fn].base.ddr_freq, ctl_fn, phy_fn); +if (IS_ENABLED (CONFIG_RAM_ROCKCHIP_DEBUG )) +printf ("%s: change freq to %d mhz %d, %d\n" , __func__, + dfs_cfgs_lpddr4[ctl_fn].base.ddr_freq, + ctl_fn, phy_fn); }return 0 ;
@@ -2966,8 +2968,10 @@ static int sdram_init(struct dram_info *dram, params->base.num_channels++; } -printf ("Channel " ); -printf (channel ?"1: " :"0: " ); +if (IS_ENABLED (CONFIG_RAM_ROCKCHIP_DEBUG )) { +printf ("Channel " ); +printf (channel ?"1: " :"0: " ); + }if (channel ==0 )set_ddr_stride (dram->pmusgrf,0x17 );
Signature · 1 line
2.25.1
Re: [PATCH 2/3] ram: rk3399: Mark existing prints via RAM_ROCKCHIP_DEBUG
Quoted 10 lines · Jagan Teki
Right now all these debug statements are printing on the console to make sure proper dram initialization happens.
Mark them into
RAM_ROCKCHIP_DEBUGwould be more meaningful and work like before since theRAM_ROCKCHIP_DEBUGis by default yet.No functionality changes.
Signed-off-by Jagan Teki <[email protected]>
Thanks,
- Kever
Quoted 34 lines
--- drivers/ram/rockchip/sdram_rk3399.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)drivers/ram/rockchip/sdram_rk3399.c +8
-4@@ -2551,8 +2551,10 @@ static int lpddr4_set_rate(struct dram_info *dram,lpddr4_set_ctl (dram, params, ctl_fn, dfs_cfgs_lpddr4[ctl_fn].base.ddr_freq); -printf ("%s: change freq to %d mhz %d, %d\n" , __func__, - dfs_cfgs_lpddr4[ctl_fn].base.ddr_freq, ctl_fn, phy_fn); +if (IS_ENABLED (CONFIG_RAM_ROCKCHIP_DEBUG )) +printf ("%s: change freq to %d mhz %d, %d\n" , __func__, + dfs_cfgs_lpddr4[ctl_fn].base.ddr_freq, + ctl_fn, phy_fn); }return 0 ;@@ -2966,8 +2968,10 @@ static int sdram_init(struct dram_info *dram, params->base.num_channels++; } -printf ("Channel " ); -printf (channel ?"1: " :"0: " ); +if (IS_ENABLED (CONFIG_RAM_ROCKCHIP_DEBUG )) { +printf ("Channel " ); +printf (channel ?"1: " :"0: " ); + }if (channel ==0 )set_ddr_stride (dram->pmusgrf,0x17 );
PATCH 3/3 roc-rk3399-pc: Disable RAM_ROCKCHIP_DEBUG
In reply to Jagan TekiDisable ram rockchip debug driver for roc-rk3399-pc boards since we have verified ram in many instances with respective U-Boot versions.
--- configs/roc-pc-mezzanine-rk3399_defconfig | 1 + configs/roc-pc-rk3399_defconfig | 1 + 2 files changed, 2 insertions(+)
configs/roc-pc-mezzanine-rk3399_defconfig +1 -0
@@ -53,6 +53,7 @@ CONFIG_PMIC_RK8XX=y CONFIG_REGULATOR_PWM=y CONFIG_REGULATOR_RK8XX=y CONFIG_PWM_ROCKCHIP=y +# CONFIG_RAM_ROCKCHIP_DEBUG is not set CONFIG_RAM_RK3399_LPDDR4=y CONFIG_DM_RESET=y CONFIG_BAUDRATE=1500000
configs/roc-pc-rk3399_defconfig +1 -0
@@ -50,6 +50,7 @@ CONFIG_PMIC_RK8XX=y CONFIG_REGULATOR_PWM=y CONFIG_REGULATOR_RK8XX=y CONFIG_PWM_ROCKCHIP=y +# CONFIG_RAM_ROCKCHIP_DEBUG is not set CONFIG_RAM_RK3399_LPDDR4=y CONFIG_DM_RESET=y CONFIG_BAUDRATE=1500000
Signature · 1 line
2.25.1
Re: [PATCH 3/3] roc-rk3399-pc: Disable RAM_ROCKCHIP_DEBUG
Quoted 5 lines · Jagan Teki
Disable ram rockchip debug driver for roc-rk3399-pc boards since we have verified ram in many instances with respective U-Boot versions.
Signed-off-by Jagan Teki <[email protected]>
Thanks,
- Kever
Quoted 29 lines
--- configs/roc-pc-mezzanine-rk3399_defconfig | 1 + configs/roc-pc-rk3399_defconfig | 1 + 2 files changed, 2 insertions(+)configs/roc-pc-mezzanine-rk3399_defconfig +1
-0@@ -53,6 +53,7 @@ CONFIG_PMIC_RK8XX=y CONFIG_REGULATOR_PWM=y CONFIG_REGULATOR_RK8XX=y CONFIG_PWM_ROCKCHIP=y +# CONFIG_RAM_ROCKCHIP_DEBUG is not set CONFIG_RAM_RK3399_LPDDR4=y CONFIG_DM_RESET=y CONFIG_BAUDRATE=1500000configs/roc-pc-rk3399_defconfig +1
-0@@ -50,6 +50,7 @@ CONFIG_PMIC_RK8XX=y CONFIG_REGULATOR_PWM=y CONFIG_REGULATOR_RK8XX=y CONFIG_PWM_ROCKCHIP=y +# CONFIG_RAM_ROCKCHIP_DEBUG is not set CONFIG_RAM_RK3399_LPDDR4=y CONFIG_DM_RESET=y CONFIG_BAUDRATE=1500000
Quoted 6 lines · Jagan Teki
stride debug is already present in
sdram_common.cviaRAM_ROCKCHIP_DEBUG.So, drop the redundant debug stride code in rk3399 driver.
Signed-off-by Jagan Teki <[email protected]>
Thanks,
- Kever
Quoted 40 lines
--- drivers/ram/rockchip/sdram_rk3399.c | 25 ------------------------- 1 file changed, 25 deletions(-)drivers/ram/rockchip/sdram_rk3399.c +0
-25@@ -2875,31 +2875,6 @@ static unsigned char calculate_stride(struct rk3399_sdram_params *params)if (stride == (-1 )) goto error; } -switch (stride) { -case 0xc : -printf ("128B stride\n" ); -break ; -case 5 : -case 9 : -case 0xd : -case 0x11 : -case 0x19 : -printf ("256B stride\n" ); -break ; -case 0xa : -case 0xe : -case 0x12 : -printf ("512B stride\n" ); -break ; -case 0xf : -printf ("4K stride\n" ); -break ; -case 0x1f : -printf ("32MB + 256B stride\n" ); -break ; -default : -printf ("no stride\n" ); - }sdram_print_stride (stride);