Skip to contentSkip to conversation

media: atomisp: Fix error code in ov5693_probe()

PATCH New Dan Carpenter 1 participant 1 message Jul 14, 2020

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: atomisp: Fix error code in ov5693_probe()

If gmin_camera_platform_data() returns NULL then we should return a negative error instead of success.

Fixes 90ebe55ab886 ("media: staging: atomisp: Add driver prefix to Kconfig option and module names")
---
 drivers/staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c +4 -2
index 97ab10bc45ca..e698b63d6cb7 100644
@@ -1899,7 +1899,7 @@ static int ov5693_probe(struct i2c_client *client)
 {
 	struct ov5693_device *dev;
 	int i2c;
-	int ret = 0;
+	int ret;
 	void *pdata;
 	unsigned int i;
 
@@ -1929,8 +1929,10 @@ static int ov5693_probe(struct i2c_client *client)
 	pdata = gmin_camera_platform_data(&dev->sd,
 					  ATOMISP_INPUT_FORMAT_RAW_10,
 					  atomisp_bayer_order_bggr);
-	if (!pdata)
+	if (!pdata) {
+		ret = -EINVAL;
 		goto out_free;
+	}
 
 	ret = ov5693_s_config(&dev->sd, client->irq, pdata);
 	if (ret)
Signature · 1 line
2.27.0