Skip to contentSkip to conversation

bootconfig: Make symbol 'xbc_namebuf' static

PATCH In review Wei Yongjun 2 participants 2 messages Jul 14, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bootconfig: Make symbol 'xbc_namebuf' static

Fix sparse build warning:

init/main.c:305:6: warning:
symbol 'xbc_namebuf' was not declared. Should it be static?

---
 init/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
init/main.c +1 -1
index 9127b240fd26..6a24981c727f 100644
@@ -302,7 +302,7 @@ static void * __init get_boot_config_from_initrd(u32 *_size, u32 *_csum)
 
 #ifdef CONFIG_BOOT_CONFIG
 
-char xbc_namebuf[XBC_KEYLEN_MAX] __initdata;
+static char xbc_namebuf[XBC_KEYLEN_MAX] __initdata;
 
 #define rest(dst, end) ((end) > (dst) ? (end) - (dst) : 0)
 
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · On Tue, 14 Jul 2020 22:25:04 +0800 Wei Yongjun <[email protected]> wrote:

Fix sparse build warning:

init/main.c:305:6: warning:
symbol 'xbc_namebuf' was not declared. Should it be static?

Good catch!

Thank you,

Quoted 20 lines
---
 init/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
init/main.c +1 -1
index 9127b240fd26..6a24981c727f 100644
@@ -302,7 +302,7 @@ static void * __init get_boot_config_from_initrd(u32 *_size, u32 *_csum)
 
 #ifdef CONFIG_BOOT_CONFIG
 
-char xbc_namebuf[XBC_KEYLEN_MAX] __initdata;
+static char xbc_namebuf[XBC_KEYLEN_MAX] __initdata;
 
 #define rest(dst, end) ((end) > (dst) ? (end) - (dst) : 0)
 
Signature · 1 line
Masami Hiramatsu <[email protected]>