net/i40e: fix fdir cannot receive rx writeback issue
PATCH 1/1 net/i40e: fix fdir cannot receive rx writeback issue
From: Chenmin Sun <[email protected]>
This patch fixes the fdir connot receive rx writeback packet issue, by setting the fdir_vsi->nb_used_qps to 1.
Besides this, to make sure fdir programming works fine when the port is stopped, move the fdir interrupt configure from start/stop to setup/teardown.
--- drivers/net/i40e/i40e_ethdev.c | 15 ++------------- drivers/net/i40e/i40e_ethdev.h | 2 ++ drivers/net/i40e/i40e_fdir.c | 11 +++++++++++ 3 files changed, 15 insertions(+), 13 deletions(-)
drivers/net/i40e/i40e_ethdev.c +2 -13
@@ -2068,7 +2068,7 @@ i40e_vsi_queues_bind_intr(struct i40e_vsi *vsi, uint16_t itr_idx) } } -static void +void i40e_vsi_enable_queues_intr (struct i40e_vsi *vsi) {struct rte_eth_dev *dev = vsi->adapter->eth_dev;
@@ -2095,7 +2095,7 @@ i40e_vsi_enable_queues_intr(struct i40e_vsi *vsi)I40E_WRITE_FLUSH (hw); } -static void +void i40e_vsi_disable_queues_intr (struct i40e_vsi *vsi) {struct rte_eth_dev *dev = vsi->adapter->eth_dev;
@@ -2317,13 +2317,6 @@ i40e_dev_start(struct rte_eth_dev *dev)i40e_vsi_enable_queues_intr (pf->vmdq[i].vsi); } -/* enable FDIR MSIX interrupt */ -if (pf->fdir.fdir_vsi) { -i40e_vsi_queues_bind_intr (pf->fdir.fdir_vsi, -I40E_ITR_INDEX_NONE ); -i40e_vsi_enable_queues_intr (pf->fdir.fdir_vsi); - } -/* Enable all queues which have been configured */ for (nb_rxq =0 ; nb_rxq < dev->data->nb_rx_queues; nb_rxq++) { ret =i40e_dev_rx_queue_start (dev, nb_rxq);
@@ -2459,10 +2452,6 @@ i40e_dev_stop(struct rte_eth_dev *dev)i40e_vsi_queues_unbind_intr (pf->vmdq[i].vsi); } -if (pf->fdir.fdir_vsi) { -i40e_vsi_queues_unbind_intr (pf->fdir.fdir_vsi); -i40e_vsi_disable_queues_intr (pf->fdir.fdir_vsi); - }/* Clear all queues and release memory */ i40e_dev_clear_queues (dev);
drivers/net/i40e/i40e_ethdev.h +2 -0
@@ -1268,6 +1268,7 @@ void i40e_pf_enable_irq0(struct i40e_hw *hw);int i40e_dev_link_update (struct rte_eth_dev *dev,int wait_to_complete);void i40e_vsi_queues_bind_intr (struct i40e_vsi *vsi,uint16_t itr_idx);void i40e_vsi_queues_unbind_intr (struct i40e_vsi *vsi); +void i40e_vsi_disable_queues_intr (struct i40e_vsi *vsi);int i40e_vsi_vlan_pvid_set (struct i40e_vsi *vsi,struct i40e_vsi_vlan_pvid_info *info);int i40e_vsi_config_vlan_stripping (struct i40e_vsi *vsi,bool on);
@@ -1277,6 +1278,7 @@ uint64_t i40e_parse_hena(const struct i40e_adapter *adapter, uint64_t flags);enum i40e_status_code i40e_fdir_setup_tx_resources (struct i40e_pf *pf);enum i40e_status_code i40e_fdir_setup_rx_resources (struct i40e_pf *pf);int i40e_fdir_setup (struct i40e_pf *pf); +void i40e_vsi_enable_queues_intr (struct i40e_vsi *vsi);const struct rte_memzone *i40e_memzone_reserve (const char *name,uint32_t len,int socket_id);
drivers/net/i40e/i40e_fdir.c +11 -0
@@ -228,6 +228,11 @@ i40e_fdir_setup(struct i40e_pf *pf) goto fail_mem; } +/* enable FDIR MSIX interrupt */ + vsi->nb_used_qps =1 ; +i40e_vsi_queues_bind_intr (vsi,I40E_ITR_INDEX_NONE ); +i40e_vsi_enable_queues_intr (vsi); +/* reserve memory for the fdir programming packet */ snprintf(z_name, sizeof(z_name), "%s_%s_%d", eth_dev->device->driver->name,
@@ -274,12 +279,18 @@ i40e_fdir_teardown(struct i40e_pf *pf) vsi = pf->fdir.fdir_vsi;if (!vsi)return ; + +/* disable FDIR MSIX interrupt */ +i40e_vsi_queues_unbind_intr (vsi); +i40e_vsi_disable_queues_intr (vsi); +int err =i40e_switch_tx_queue (hw, vsi->base_queue, FALSE);if (err)PMD_DRV_LOG (DEBUG ,"Failed to do FDIR TX switch off" ); err =i40e_switch_rx_queue (hw, vsi->base_queue, FALSE);if (err)PMD_DRV_LOG (DEBUG ,"Failed to do FDIR RX switch off" ); +i40e_dev_rx_queue_release (pf->fdir.rxq);rte_eth_dma_zone_free (dev,"fdir_rx_ring" , pf->fdir.rxq->queue_id); pf->fdir.rxq =NULL ;
Signature · 1 line
2.17.1
PATCH v2 1/1 net/i40e: fix fdir cannot receive rx writeback issue
From: Chenmin Sun <[email protected]>
This patch fixes the fdir cannot receive rx writeback packet issue, by setting the fdir_vsi->nb_used_qps to 1.
Besides this, to make sure fdir programming works fine when the port is stopped, move the fdir interrupt configure from start/stop to setup/teardown.
---
v2:
* Fix commit message typo
--- drivers/net/i40e/i40e_ethdev.c | 15 ++------------- drivers/net/i40e/i40e_ethdev.h | 2 ++ drivers/net/i40e/i40e_fdir.c | 11 +++++++++++ 3 files changed, 15 insertions(+), 13 deletions(-)
drivers/net/i40e/i40e_ethdev.c +2 -13
@@ -2068,7 +2068,7 @@ i40e_vsi_queues_bind_intr(struct i40e_vsi *vsi, uint16_t itr_idx) } } -static void +void i40e_vsi_enable_queues_intr (struct i40e_vsi *vsi) {struct rte_eth_dev *dev = vsi->adapter->eth_dev;
@@ -2095,7 +2095,7 @@ i40e_vsi_enable_queues_intr(struct i40e_vsi *vsi)I40E_WRITE_FLUSH (hw); } -static void +void i40e_vsi_disable_queues_intr (struct i40e_vsi *vsi) {struct rte_eth_dev *dev = vsi->adapter->eth_dev;
@@ -2317,13 +2317,6 @@ i40e_dev_start(struct rte_eth_dev *dev)i40e_vsi_enable_queues_intr (pf->vmdq[i].vsi); } -/* enable FDIR MSIX interrupt */ -if (pf->fdir.fdir_vsi) { -i40e_vsi_queues_bind_intr (pf->fdir.fdir_vsi, -I40E_ITR_INDEX_NONE ); -i40e_vsi_enable_queues_intr (pf->fdir.fdir_vsi); - } -/* Enable all queues which have been configured */ for (nb_rxq =0 ; nb_rxq < dev->data->nb_rx_queues; nb_rxq++) { ret =i40e_dev_rx_queue_start (dev, nb_rxq);
@@ -2459,10 +2452,6 @@ i40e_dev_stop(struct rte_eth_dev *dev)i40e_vsi_queues_unbind_intr (pf->vmdq[i].vsi); } -if (pf->fdir.fdir_vsi) { -i40e_vsi_queues_unbind_intr (pf->fdir.fdir_vsi); -i40e_vsi_disable_queues_intr (pf->fdir.fdir_vsi); - }/* Clear all queues and release memory */ i40e_dev_clear_queues (dev);
drivers/net/i40e/i40e_ethdev.h +2 -0
@@ -1268,6 +1268,7 @@ void i40e_pf_enable_irq0(struct i40e_hw *hw);int i40e_dev_link_update (struct rte_eth_dev *dev,int wait_to_complete);void i40e_vsi_queues_bind_intr (struct i40e_vsi *vsi,uint16_t itr_idx);void i40e_vsi_queues_unbind_intr (struct i40e_vsi *vsi); +void i40e_vsi_disable_queues_intr (struct i40e_vsi *vsi);int i40e_vsi_vlan_pvid_set (struct i40e_vsi *vsi,struct i40e_vsi_vlan_pvid_info *info);int i40e_vsi_config_vlan_stripping (struct i40e_vsi *vsi,bool on);
@@ -1277,6 +1278,7 @@ uint64_t i40e_parse_hena(const struct i40e_adapter *adapter, uint64_t flags);enum i40e_status_code i40e_fdir_setup_tx_resources (struct i40e_pf *pf);enum i40e_status_code i40e_fdir_setup_rx_resources (struct i40e_pf *pf);int i40e_fdir_setup (struct i40e_pf *pf); +void i40e_vsi_enable_queues_intr (struct i40e_vsi *vsi);const struct rte_memzone *i40e_memzone_reserve (const char *name,uint32_t len,int socket_id);
drivers/net/i40e/i40e_fdir.c +11 -0
@@ -228,6 +228,11 @@ i40e_fdir_setup(struct i40e_pf *pf) goto fail_mem; } +/* enable FDIR MSIX interrupt */ + vsi->nb_used_qps =1 ; +i40e_vsi_queues_bind_intr (vsi,I40E_ITR_INDEX_NONE ); +i40e_vsi_enable_queues_intr (vsi); +/* reserve memory for the fdir programming packet */ snprintf(z_name, sizeof(z_name), "%s_%s_%d", eth_dev->device->driver->name,
@@ -274,12 +279,18 @@ i40e_fdir_teardown(struct i40e_pf *pf) vsi = pf->fdir.fdir_vsi;if (!vsi)return ; + +/* disable FDIR MSIX interrupt */ +i40e_vsi_queues_unbind_intr (vsi); +i40e_vsi_disable_queues_intr (vsi); +int err =i40e_switch_tx_queue (hw, vsi->base_queue, FALSE);if (err)PMD_DRV_LOG (DEBUG ,"Failed to do FDIR TX switch off" ); err =i40e_switch_rx_queue (hw, vsi->base_queue, FALSE);if (err)PMD_DRV_LOG (DEBUG ,"Failed to do FDIR RX switch off" ); +i40e_dev_rx_queue_release (pf->fdir.rxq);rte_eth_dma_zone_free (dev,"fdir_rx_ring" , pf->fdir.rxq->queue_id); pf->fdir.rxq =NULL ;
Signature · 1 line
2.17.1
Quoted 9 lines
-----Original Message-----
From: Sun, Chenmin <[email protected]>
Sent: Thursday, July 16, 2020 7:04 AM
To: Zhang, Qi Z <[email protected]>; Xing, Beilei <[email protected]>
Cc: [email protected]; Sun, Chenmin <[email protected]>
Subject: [PATCH V2] net/i40e: fix fdir cannot receive rx writeback issue
Quoted 4 lines
From: Chenmin Sun <[email protected]>
This patch fixes the fdir cannot receive rx writeback packet issue, by setting the
fdir_vsi->nb_used_qpsto 1.
Better to describe what's the root cause but not how to set the detailed value. The root cause should be FDIR interrupt is not enabled successfully.
Quoted 119 lines
Besides this, to make sure fdir programming works fine when the port is stopped, move the fdir interrupt configure from start/stop to setup/teardown.
Fixes cfd662d22e ("net/i40e: fix interrupt throttling setting in PF")Signed-off-by Chenmin Sun <[email protected]>---
v2:
* Fix commit message typo--- drivers/net/i40e/i40e_ethdev.c | 15 ++------------- drivers/net/i40e/i40e_ethdev.h | 2 ++ drivers/net/i40e/i40e_fdir.c | 11 +++++++++++ 3 files changed, 15 insertions(+), 13 deletions(-)drivers/net/i40e/i40e_ethdev.c +1
-1@@ -2068,7 +2068,7 @@ i40e_vsi_queues_bind_intr(struct i40e_vsi *vsi, uint16_t itr_idx) } } -static void +void i40e_vsi_enable_queues_intr (struct i40e_vsi *vsi) { struct rte_eth_dev *dev = vsi->adapter->eth_dev; @@ -2095,7 +2095,7@@
i40e_vsi_enable_queues_intr(struct i40e_vsi *vsi)drivers/net/i40e/i40e_ethdev.c +3
-12I40E_WRITE_FLUSH (hw); } -static void +void i40e_vsi_disable_queues_intr (struct i40e_vsi *vsi) { struct rte_eth_dev *dev = vsi->adapter->eth_dev; @@ -2317,13 +2317,6 @@ i40e_dev_start(struct rte_eth_dev *dev)i40e_vsi_enable_queues_intr (pf->vmdq[i].vsi); } -/* enable FDIR MSIX interrupt */ -if (pf->fdir.fdir_vsi) { -i40e_vsi_queues_bind_intr (pf->fdir.fdir_vsi, -I40E_ITR_INDEX_NONE ); -i40e_vsi_enable_queues_intr (pf->fdir.fdir_vsi); - } -/* Enable all queues which have been configured */ for (nb_rxq =0 ; nb_rxq < dev->data->nb_rx_queues; nb_rxq++) { ret = i40e_dev_rx_queue_start(dev, nb_rxq); @@ -2459,10 +2452,6 @@ i40e_dev_stop(struct rte_eth_dev *dev)i40e_vsi_queues_unbind_intr (pf->vmdq[i].vsi); } -if (pf->fdir.fdir_vsi) { -i40e_vsi_queues_unbind_intr (pf->fdir.fdir_vsi); -i40e_vsi_disable_queues_intr (pf->fdir.fdir_vsi); - }/* Clear all queues and release memory */ i40e_dev_clear_queues (dev);drivers/net/i40e/i40e_ethdev.h +0
-0@@ -1268,6 +1268,7 @@ void i40e_pf_enable_irq0(struct i40e_hw *hw); int
i40e_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete); voidi40e_vsi_queues_bind_intr(struct i40e_vsi *vsi, uint16_t itr_idx); voidi40e_vsi_queues_unbind_intr(struct i40e_vsi *vsi);drivers/net/i40e/i40e_ethdev.h +1
-0+void i40e_vsi_disable_queues_intr (struct i40e_vsi *vsi);int i40e_vsi_vlan_pvid_set (struct i40e_vsi *vsi,struct i40e_vsi_vlan_pvid_info *info);int
i40e_vsi_config_vlan_stripping(struct i40e_vsi *vsi, bool on); @@ -1277,6 +1278,7 @@uint64_ti40e_parse_hena(const struct i40e_adapter *adapter, uint64_t flags); enumi40e_status_codei40e_fdir_setup_tx_resources(struct i40e_pf *pf); enumi40e_status_codei40e_fdir_setup_rx_resources(struct i40e_pf *pf); inti40e_fdir_setup(struct i40e_pf *pf);drivers/net/i40e/i40e_ethdev.h +1
-0+void i40e_vsi_enable_queues_intr (struct i40e_vsi *vsi);const struct rte_memzone *i40e_memzone_reserve (const char *name,uint32_t len,int socket_id);drivers/net/i40e/i40e_fdir.c index renamed from drivers/net/i40e/i40e_fdir.c +0
-0
71eb31fb8..60eeccc1a100644drivers/net/i40e/i40e_fdir.c +11
-1@@ -228,6 +228,11 @@ i40e_fdir_setup(struct i40e_pf *pf) goto fail_mem; } +/* enable FDIR MSIX interrupt */ + vsi->nb_used_qps =1 ; +i40e_vsi_queues_bind_intr (vsi,I40E_ITR_INDEX_NONE ); +i40e_vsi_enable_queues_intr (vsi); +/* reserve memory for the fdir programming packet */ snprintf(z_name, sizeof(z_name), "%s_%s_%d", eth_dev->device->driver->name,@@ -274,12 +279,18 @@ i40e_fdir_teardown(struct i40e_pf *pf) vsi = pf->fdir.fdir_vsi;if (!vsi)return ; + +/* disable FDIR MSIX interrupt */ +i40e_vsi_queues_unbind_intr (vsi); +i40e_vsi_disable_queues_intr (vsi); +int err =i40e_switch_tx_queue (hw, vsi->base_queue, FALSE);if (err)PMD_DRV_LOG (DEBUG ,"Failed to do FDIR TX switch off" ); err =i40e_switch_rx_queue (hw, vsi->base_queue, FALSE);if (err)PMD_DRV_LOG (DEBUG ,"Failed to do FDIR RX switch off" ); +i40e_dev_rx_queue_release (pf->fdir.rxq);rte_eth_dma_zone_free (dev,"fdir_rx_ring" , pf->fdir.rxq->queue_id); pf->fdir.rxq =NULL ; --2.17.1
PATCH v3 1/1 net/i40e: fix fdir cannot receive rx writeback issue
In reply to [email protected]From: Chenmin Sun <[email protected]>
This patch fixes the fdir cannot receive rx writeback packet issue. The root cause is FDIR interrupt is not correctly enabled.
Beside this, to make sure fdir programming works fine when the port is stopped, move the fdir interrupt configure from start/stop to setup/teardown.
---
v3:
* Refine commit log
v2:
* Fix commit message typo
--- drivers/net/i40e/i40e_ethdev.c | 15 ++------------- drivers/net/i40e/i40e_ethdev.h | 2 ++ drivers/net/i40e/i40e_fdir.c | 11 +++++++++++ 3 files changed, 15 insertions(+), 13 deletions(-)
drivers/net/i40e/i40e_ethdev.c +2 -13
@@ -2068,7 +2068,7 @@ i40e_vsi_queues_bind_intr(struct i40e_vsi *vsi, uint16_t itr_idx) } } -static void +void i40e_vsi_enable_queues_intr (struct i40e_vsi *vsi) {struct rte_eth_dev *dev = vsi->adapter->eth_dev;
@@ -2095,7 +2095,7 @@ i40e_vsi_enable_queues_intr(struct i40e_vsi *vsi)I40E_WRITE_FLUSH (hw); } -static void +void i40e_vsi_disable_queues_intr (struct i40e_vsi *vsi) {struct rte_eth_dev *dev = vsi->adapter->eth_dev;
@@ -2317,13 +2317,6 @@ i40e_dev_start(struct rte_eth_dev *dev)i40e_vsi_enable_queues_intr (pf->vmdq[i].vsi); } -/* enable FDIR MSIX interrupt */ -if (pf->fdir.fdir_vsi) { -i40e_vsi_queues_bind_intr (pf->fdir.fdir_vsi, -I40E_ITR_INDEX_NONE ); -i40e_vsi_enable_queues_intr (pf->fdir.fdir_vsi); - } -/* Enable all queues which have been configured */ for (nb_rxq =0 ; nb_rxq < dev->data->nb_rx_queues; nb_rxq++) { ret =i40e_dev_rx_queue_start (dev, nb_rxq);
@@ -2459,10 +2452,6 @@ i40e_dev_stop(struct rte_eth_dev *dev)i40e_vsi_queues_unbind_intr (pf->vmdq[i].vsi); } -if (pf->fdir.fdir_vsi) { -i40e_vsi_queues_unbind_intr (pf->fdir.fdir_vsi); -i40e_vsi_disable_queues_intr (pf->fdir.fdir_vsi); - }/* Clear all queues and release memory */ i40e_dev_clear_queues (dev);
drivers/net/i40e/i40e_ethdev.h +2 -0
@@ -1268,6 +1268,7 @@ void i40e_pf_enable_irq0(struct i40e_hw *hw);int i40e_dev_link_update (struct rte_eth_dev *dev,int wait_to_complete);void i40e_vsi_queues_bind_intr (struct i40e_vsi *vsi,uint16_t itr_idx);void i40e_vsi_queues_unbind_intr (struct i40e_vsi *vsi); +void i40e_vsi_disable_queues_intr (struct i40e_vsi *vsi);int i40e_vsi_vlan_pvid_set (struct i40e_vsi *vsi,struct i40e_vsi_vlan_pvid_info *info);int i40e_vsi_config_vlan_stripping (struct i40e_vsi *vsi,bool on);
@@ -1277,6 +1278,7 @@ uint64_t i40e_parse_hena(const struct i40e_adapter *adapter, uint64_t flags);enum i40e_status_code i40e_fdir_setup_tx_resources (struct i40e_pf *pf);enum i40e_status_code i40e_fdir_setup_rx_resources (struct i40e_pf *pf);int i40e_fdir_setup (struct i40e_pf *pf); +void i40e_vsi_enable_queues_intr (struct i40e_vsi *vsi);const struct rte_memzone *i40e_memzone_reserve (const char *name,uint32_t len,int socket_id);
drivers/net/i40e/i40e_fdir.c +11 -0
@@ -228,6 +228,11 @@ i40e_fdir_setup(struct i40e_pf *pf) goto fail_mem; } +/* enable FDIR MSIX interrupt */ + vsi->nb_used_qps =1 ; +i40e_vsi_queues_bind_intr (vsi,I40E_ITR_INDEX_NONE ); +i40e_vsi_enable_queues_intr (vsi); +/* reserve memory for the fdir programming packet */ snprintf(z_name, sizeof(z_name), "%s_%s_%d", eth_dev->device->driver->name,
@@ -274,12 +279,18 @@ i40e_fdir_teardown(struct i40e_pf *pf) vsi = pf->fdir.fdir_vsi;if (!vsi)return ; + +/* disable FDIR MSIX interrupt */ +i40e_vsi_queues_unbind_intr (vsi); +i40e_vsi_disable_queues_intr (vsi); +int err =i40e_switch_tx_queue (hw, vsi->base_queue, FALSE);if (err)PMD_DRV_LOG (DEBUG ,"Failed to do FDIR TX switch off" ); err =i40e_switch_rx_queue (hw, vsi->base_queue, FALSE);if (err)PMD_DRV_LOG (DEBUG ,"Failed to do FDIR RX switch off" ); +i40e_dev_rx_queue_release (pf->fdir.rxq);rte_eth_dma_zone_free (dev,"fdir_rx_ring" , pf->fdir.rxq->queue_id); pf->fdir.rxq =NULL ;
Signature · 1 line
2.17.1
Quoted 14 lines
-----Original Message-----
From: Sun, Chenmin <[email protected]>
Sent: Friday, July 17, 2020 10:58 PM
To: Zhang, Qi Z <[email protected]>; Xing, Beilei <[email protected]>
Cc: [email protected]; Sun, Chenmin <[email protected]>
Subject: [PATCH v3] net/i40e: fix fdir cannot receive rx writeback issueFrom: Chenmin Sun <[email protected]>
This patch fixes the fdir cannot receive rx writeback packet issue. The root cause is FDIR interrupt is not correctly enabled.
Quoted 6 lines
Beside this, to make sure fdir programming works fine when the port is stopped, move the fdir interrupt configure from start/stop to setup/teardown.
Fixes cfd662d22e7b ("net/i40e: fix interrupt throttling setting in PF")Signed-off-by Chenmin Sun <[email protected]>
Zhang, Qi Z
AppliedQuoted 28 lines
-----Original Message-----
From: Xing, Beilei <[email protected]>
Sent: Friday, July 17, 2020 10:48 PM
To: Sun, Chenmin <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: [email protected]
Subject: RE: [PATCH v3] net/i40e: fix fdir cannot receive rx writeback issueQuoted 9 lines
-----Original Message-----
From: Sun, Chenmin <[email protected]>
Sent: Friday, July 17, 2020 10:58 PM
To: Zhang, Qi Z <[email protected]>; Xing, Beilei <[email protected]>
Cc: [email protected]; Sun, Chenmin <[email protected]>
Subject: [PATCH v3] net/i40e: fix fdir cannot receive rx writeback issueQuoted 7 lines
From: Chenmin Sun <[email protected]>
This patch fixes the fdir cannot receive rx writeback packet issue. The root cause is FDIR interrupt is not correctly enabled.
Beside this, to make sure fdir programming works fine when the port is stopped, move the fdir interrupt configure from start/stop to
Quoted 8 lines
setup/teardown.
Quoted 5 lines
Fixes cfd662d22e7b ("net/i40e: fix interrupt throttling setting inPF")
Signed-off-by Chenmin Sun <[email protected]>Acked-by Beilei Xing <[email protected]>
Applied to dpdk-next-net-intel.
Thanks
Qi