Unsolicited broadcast probe resp support
Subsystems (2)
PATCH v3 1/2 nl80211: Unsolicited broadcast probe response support
In reply to Aloka DixitThis patch adds new attributes to support unsolicited broadcast probe response transmission used for in-band
discovery in 6GHz band (IEEE P802.11ax/D6.0 26.17.2.3.2, AP behavior for fast passive scanning).
The new attribute, NL80211_ATTR_UNSOL_BCAST_PROBE_RESP, is nested which supports following parameters:
(1) NL80211_UNSOL_BCAST_PROBE_RESP_INT - Packet interval
(2) NL80211_UNSOL_BCAST_PROBE_RESP_TMPL - Template data
--- include/net/cfg80211.h | 18 ++++++++++++++ include/uapi/linux/nl80211.h | 32 ++++++++++++++++++++++++ net/wireless/nl80211.c | 47 ++++++++++++++++++++++++++++++++++++ 3 files changed, 97 insertions(+)
include/net/cfg80211.h +18 -0
@@ -1047,6 +1047,22 @@ struct cfg80211_acl_data {struct mac_address mac_addrs[]; }; +/** +* struct cfg80211_unsol_bcast_probe_resp - Unsolicited broadcast probe +* response parameters in 6GHz. +* +* @interval: Packet interval in TUs. Maximum allowed is 20 TU, as mentioned +* in IEEE P802.11ax/D6.0 26.17.2.3.2 - AP behavior for fast passive +* scanning +* @tmpl_len: Template length +* @tmpl: Template data for probe response +*/ +struct cfg80211_unsol_bcast_probe_resp { +u32 interval; +size_t tmpl_len; +const u8 *tmpl; +}; +/** * enum cfg80211_ap_settings_flags - AP settings flags *
@@ -1094,6 +1110,7 @@ enum cfg80211_ap_settings_flags {* @he_obss_pd: OBSS Packet Detection settings * @he_bss_color: BSS Color settings * @he_oper: HE operation IE (or %NULL if HE isn't enabled) +* @unsol_bcast_probe_resp: Unsolicited broadcast probe response parameters */ struct cfg80211_ap_settings {struct cfg80211_chan_def chandef;
@@ -1124,6 +1141,7 @@ struct cfg80211_ap_settings {u32 flags;struct ieee80211_he_obss_pd he_obss_pd;struct cfg80211_he_bss_color he_bss_color; +struct cfg80211_unsol_bcast_probe_resp unsol_bcast_probe_resp; };/**
include/uapi/linux/nl80211.h +32 -0
@@ -2505,6 +2505,10 @@ enum nl80211_commands {* @NL80211_ATTR_HE_6GHZ_CAPABILITY: HE 6 GHz Band Capability element (from * association request when used with NL80211_CMD_NEW_STATION). * +* @NL80211_ATTR_UNSOL_BCAST_PROBE_RESP: Optional parameter to configure +* unsolicited broadcast probe response. It is a nested attribute, see +* &enum nl80211_unsol_bcast_probe_resp_attributes. +* * @NUM_NL80211_ATTR: total number of nl80211_attrs available * @NL80211_ATTR_MAX: highest attribute number currently defined * @__NL80211_ATTR_AFTER_LAST: internal use
@@ -2987,6 +2991,8 @@ enum nl80211_attrs {NL80211_ATTR_HE_6GHZ_CAPABILITY , +NL80211_ATTR_UNSOL_BCAST_PROBE_RESP , +/* add attributes here, update the policy in nl80211.c */ __NL80211_ATTR_AFTER_LAST,
@@ -6922,4 +6928,30 @@ enum nl80211_iftype_akm_attributes { NL80211_IFTYPE_AKM_ATTR_MAX = __NL80211_IFTYPE_AKM_ATTR_LAST - 1, }; +/** +* enum nl80211_unsol_bcast_probe_resp_attributes - Unsolicited broadcast probe +* response configuration. Applicable only in 6GHz. +* +* @__NL80211_UNSOL_BCAST_PROBE_RESP_INVALID: Invalid +* +* @NL80211_UNSOL_BCAST_PROBE_RESP_INT: Maximum packet interval (u32, TU). +* Allowed range: 0..20 (TU = Time Unit). IEEE P802.11ax/D6.0 +* 26.17.2.3.2 (AP behavior for fast passive scanning. +* @NL80211_UNSOL_BCAST_PROBE_RESP_TMPL: Unsolicited broadcast probe response +* frame template (binary). +* +* @__NL80211_UNSOL_BCAST_PROBE_RESP_LAST: Internal +* @NL80211_UNSOL_BCAST_PROBE_RESP_MAX: highest attribute +*/ +enum nl80211_unsol_bcast_probe_resp_attributes { + __NL80211_UNSOL_BCAST_PROBE_RESP_INVALID, + +NL80211_UNSOL_BCAST_PROBE_RESP_INT , +NL80211_UNSOL_BCAST_PROBE_RESP_TMPL , + +/* keep last */ + __NL80211_UNSOL_BCAST_PROBE_RESP_LAST, +NL80211_UNSOL_BCAST_PROBE_RESP_MAX = + __NL80211_UNSOL_BCAST_PROBE_RESP_LAST -1 +};#endif /* __LINUX_NL80211_H */
net/wireless/nl80211.c +47 -0
71 lines not on this page · raw message
Signature · 1 line
2.25.0
PATCH v3 2/2 mac80211: Unsolicited broadcast probe response support
In reply to Aloka DixitThis patch adds mac80211 support to configure unsolicited broadcast probe response transmission for in-band discovery in 6GHz.
Changes include functions to store and retrieve probe response template, and packet interval (0 - 20 TUs).
Setting interval to 0 disables the unsolicited broadcast probe response transmission.
--- include/net/mac80211.h | 21 +++++++++++++++++++ net/mac80211/cfg.c | 42 ++++++++++++++++++++++++++++++++++++++ net/mac80211/ieee80211_i.h | 7 +++++++ net/mac80211/tx.c | 26 +++++++++++++++++++++++ 4 files changed, 96 insertions(+)
include/net/mac80211.h +21 -0
@@ -317,6 +317,8 @@ struct ieee80211_vif_chanctx_switch {* @BSS_CHANGED_TWT: TWT status changed * @BSS_CHANGED_HE_OBSS_PD: OBSS Packet Detection status changed. * @BSS_CHANGED_HE_BSS_COLOR: BSS Color has changed +* @BSS_CHANGED_UNSOL_BCAST_PROBE_RESP: Unsolicited broadcast probe response +* status changed. * */ enum ieee80211_bss_change {
@@ -350,6 +352,7 @@ enum ieee80211_bss_change {BSS_CHANGED_TWT =1 <<27 ,BSS_CHANGED_HE_OBSS_PD =1 <<28 ,BSS_CHANGED_HE_BSS_COLOR =1 <<29 , + BSS_CHANGED_UNSOL_BCAST_PROBE_RESP = 1<<30, /* when adding here, make sure to change ieee80211_reconfig */ };
@@ -607,6 +610,8 @@ struct ieee80211_ftm_responder_params {* @he_oper: HE operation information of the AP we are connected to * @he_obss_pd: OBSS Packet Detection parameters. * @he_bss_color: BSS coloring settings, if BSS supports HE +* @unsol_bcast_probe_resp_interval: Unsolicited broadcast probe response +* interval. */ struct ieee80211_bss_conf {const u8 *bssid;
@@ -674,6 +679,7 @@ struct ieee80211_bss_conf { } he_oper;struct ieee80211_he_obss_pd he_obss_pd;struct cfg80211_he_bss_color he_bss_color; +u32 unsol_bcast_probe_resp_interval; };/**
@@ -6558,4 +6564,19 @@ u32 ieee80211_calc_tx_airtime(struct ieee80211_hw *hw,*/ bool ieee80211_set_hw_80211_encap (struct ieee80211_vif *vif,bool enable); + +/** +* ieee80211_get_unsol_bcast_probe_resp_tmpl - Get unsolicited broadcast +* probe response template. +* @hw: pointer obtained from ieee80211_alloc_hw(). +* @vif: &struct ieee80211_vif pointer from the add_interface callback. +* +* The driver is responsible for freeing the returned skb. +* +* Return: Unsolicited broadcast probe response template. %NULL on error. +*/ +struct sk_buff * +ieee80211_get_unsol_bcast_probe_resp_tmpl (struct ieee80211_hw *hw, +struct ieee80211_vif *vif); +#endif /* MAC80211_H */
net/mac80211/cfg.c +42 -0
75 lines not on this page · raw message
net/mac80211/ieee80211_i.h +7 -0
@@ -272,6 +272,12 @@ struct probe_resp {u8 data[]; }; +struct unsol_bcast_probe_resp_data { +struct rcu_head rcu_head; +int len; +u8 data[]; +}; +struct ps_data {/* yes, this looks ugly, but guarantees that we can later use * bitmap_empty :)
@@ -287,6 +293,7 @@ struct ps_data {struct ieee80211_if_ap {struct beacon_data __rcu *beacon;struct probe_resp __rcu *probe_resp; +struct unsol_bcast_probe_resp_data __rcu *unsol_bcast_probe_resp;/* to be used after channel switch. */ struct cfg80211_beacon_data *next_beacon;
net/mac80211/tx.c +26 -0
@@ -4998,6 +4998,32 @@ struct sk_buff *ieee80211_proberesp_get(struct ieee80211_hw *hw, }EXPORT_SYMBOL (ieee80211_proberesp_get); +struct sk_buff * +ieee80211_get_unsol_bcast_probe_resp_tmpl (struct ieee80211_hw *hw, +struct ieee80211_vif *vif) +{ +struct sk_buff *skb =NULL ; +struct unsol_bcast_probe_resp_data *tmpl =NULL ; +struct ieee80211_sub_if_data *sdata =vif_to_sdata (vif); + +if (sdata->vif.type !=NL80211_IFTYPE_AP ) +return NULL ; + +rcu_read_lock (); + tmpl =rcu_dereference (sdata->u.ap.unsol_bcast_probe_resp); +if (!tmpl) { +rcu_read_unlock (); +return NULL ; + } + + skb =dev_alloc_skb (tmpl->len); +if (skb) +skb_put_data (skb, tmpl->data, tmpl->len); +rcu_read_unlock (); +return skb; +} +EXPORT_SYMBOL (ieee80211_get_unsol_bcast_probe_resp_tmpl); +struct sk_buff *ieee80211_pspoll_get (struct ieee80211_hw *hw,struct ieee80211_vif *vif) {
Signature · 1 line
2.25.0
v3 cover Unsolicited broadcast probe resp support
Unsolicited broadcast probe response tranmission is used for in-band discovery in 6GHz band (IEEE P802.11ax/D6.0 26.17.2.3.2, AP behavior for fast passive scanning).
v3: Rebased. Removed check for 6Ghz, drivers should add that check.
v2: Removed flag 'enabled' and changed 6GHz frequency range as per
IEEE P802.11ax/D6.1.
Aloka Dixit (2):
nl80211: Unsolicited broadcast probe response support
mac80211: Unsolicited broadcast probe response support
include/net/cfg80211.h | 18 ++++++++++++++ include/net/mac80211.h | 21 ++++++++++++++++ include/uapi/linux/nl80211.h | 32 ++++++++++++++++++++++++ net/mac80211/cfg.c | 42 ++++++++++++++++++++++++++++++++ net/mac80211/ieee80211_i.h | 7 ++++++ net/mac80211/tx.c | 26 ++++++++++++++++++++ net/wireless/nl80211.c | 47 ++++++++++++++++++++++++++++++++++++ 7 files changed, 193 insertions(+)
Signature · 1 line
2.25.0
Quoted 5 lines · Aloka Dixit
Unsolicited broadcast probe response tranmission is used for in-band discovery in 6GHz band (IEEE P802.11ax/D6.0 26.17.2.3.2, AP behavior for fast passive scanning).
v3: Rebased. Removed check for 6Ghz, drivers should add that check.
I have not seen any comments in v2 so could you motivate this removal. It is a sanity check that is always needed so doing it in the nl80211 api seems the proper place.
Regards,
Arend
Quoted 5 lines · Arend Van Spriel
Quoted 4 lines · Aloka Dixit
Unsolicited broadcast probe response tranmission is used for in-band discovery in 6GHz band (IEEE P802.11ax/D6.0 26.17.2.3.2, AP behavior for fast passive scanning).
Quoted 8 lines
Quoted 1 line
v3: Rebased. Removed check for 6Ghz, drivers should add that check.
I have not seen any comments in v2 so could you motivate this removal. It is a sanity check that is always needed so doing it in the nl80211 api seems the proper place.
Regards,
Arend
Hi Arend,
I found that if any application sends NL80211_ATTR_UNSOL_BCAST_PROBE_RESP with NL80211_UNSOL_BCAST_PROBE_RESP_INT=0 (which means disable) for 2.4/5GHz, the check here resulted in AP not being brought up. Technically disabling this feature for 2.4/5GHz is not required as it is disabled by default but it should not cause issues if done so explicitly. Hence I removed the check here so that drivers can decide to use/ignore this attribute.
Johannes Berg
maintainerRe: [PATCH v3 1/2] nl80211: Unsolicited broadcast probe response support
In reply to Aloka DixitQuoted 10 lines
+/**
+ * enumnl80211_unsol_bcast_probe_resp_attributes- Unsolicited broadcast probe
+ * response configuration. Applicable only in 6GHz.
+ *
+ * @__NL80211_UNSOL_BCAST_PROBE_RESP_INVALID: Invalid
+ *
+ * @NL80211_UNSOL_BCAST_PROBE_RESP_INT: Maximum packet interval (u32, TU).
+ * Allowed range: 0..20 (TU = Time Unit). IEEE P802.11ax/D6.0
+ * 26.17.2.3.2 (AP behavior for fast passive scanning.
nit: that "(" never closes
net/wireless/nl80211.c static int nl80211_parse_he_bss_color(struct nlattr *attrs, · line 4758
Quoted 6 lines
net/wireless/nl80211.c +5
-0+ tmpl = tb[NL80211_UNSOL_BCAST_PROBE_RESP_TMPL ]; +if (tmpl) { + presp->tmpl =nla_data (tmpl); + presp->tmpl_len =nla_len (tmpl); + }
So, hmm. Similar question here - what do you do without a template? Or OTOH, why do you even need a template? Would you advertise something that's *different* from the regular probe response template you already get for offloaded probe request/response support?
johannes
Johannes Berg
maintainerRe: [PATCH v3 1/2] nl80211: Unsolicited broadcast probe response support
In reply to Aloka DixitAlso,
Quoted 8 lines
+/**
+ * enumnl80211_unsol_bcast_probe_resp_attributes- Unsolicited broadcast probe
+ * response configuration. Applicable only in 6GHz.
+ *
+ * @__NL80211_UNSOL_BCAST_PROBE_RESP_INVALID: Invalid
+ *
+ * @NL80211_UNSOL_BCAST_PROBE_RESP_INT: Maximum packet interval (u32, TU).
+ * Allowed range: 0..20 (TU = Time Unit). IEEE P802.11ax/D6.0
0 doesn't make sense, you should disallow that.
I see you used it for "turn off" at least in the mac80211 patch but it seems to me that should have a more explicit way at least in the external API? At the very least it needs to documentation.
johannes
Johannes Berg
maintainerRe: [PATCH v3 1/2] nl80211: Unsolicited broadcast probe response support
In reply to Aloka DixitQuoted 8 lines · Aloka Dixit
This patch adds new attributes to support unsolicited broadcast probe response transmission used for in-band
discovery in 6GHz band (IEEE P802.11ax/D6.0 26.17.2.3.2, AP behavior for fast passive scanning).
The new attribute,NL80211_ATTR_UNSOL_BCAST_PROBE_RESP, is nested which supports following parameters:
(1)NL80211_UNSOL_BCAST_PROBE_RESP_INT- Packet interval
(2)NL80211_UNSOL_BCAST_PROBE_RESP_TMPL- Template data
And maybe some driver support flag is needed?
johannes
Johannes Berg
maintainerRe: [PATCH v3 1/2] nl80211: Unsolicited broadcast probe response support
Quoted 11 lines · Johannes Berg
Quoted 8 lines · Aloka Dixit
This patch adds new attributes to support unsolicited broadcast probe response transmission used for in-band
discovery in 6GHz band (IEEE P802.11ax/D6.0 26.17.2.3.2, AP behavior for fast passive scanning).
The new attribute,NL80211_ATTR_UNSOL_BCAST_PROBE_RESP, is nested which supports following parameters:
(1)NL80211_UNSOL_BCAST_PROBE_RESP_INT- Packet interval
(2)NL80211_UNSOL_BCAST_PROBE_RESP_TMPL- Template dataAnd maybe some driver support flag is needed?
Possibly even per band, like our discussion on the other patches?
johannes
Re: [PATCH v3 1/2] nl80211: Unsolicited broadcast probe response support
In reply to Johannes BergQuoted 14 lines · Johannes Berg
Quoted 11 lines
+/**
+ * enumnl80211_unsol_bcast_probe_resp_attributes- Unsolicited broadcast probe
+ * response configuration. Applicable only in 6GHz.
+ *
+ * @__NL80211_UNSOL_BCAST_PROBE_RESP_INVALID: Invalid
+ *
+ * @NL80211_UNSOL_BCAST_PROBE_RESP_INT: Maximum packet interval (u32, TU).
+ * Allowed range: 0..20 (TU = Time Unit). IEEE P802.11ax/D6.0
+ * 26.17.2.3.2 (AP behavior for fast passive scanning.nit: that "(" never closes
Quoted 11 lines
net/wireless/nl80211.c static int nl80211_parse_he_bss_color(struct nlattr *attrs, · line 4758
Quoted 6 lines
net/wireless/nl80211.c +5
-0+ tmpl = tb[NL80211_UNSOL_BCAST_PROBE_RESP_TMPL ]; +if (tmpl) { + presp->tmpl =nla_data (tmpl); + presp->tmpl_len =nla_len (tmpl); + }So, hmm. Similar question here - what do you do without a template? Or OTOH, why do you even need a template? Would you advertise something that's *different* from the regular probe response template you already get for offloaded probe request/response support?
The template will be same as the probe response, except for the destination MAC address as this one is broadcast.
Main reason is that this unsolicited broadcast probe response transmission is specific to 6GHz and not applicable to lower bands. Having a separate netlink command allowed not messing with the existing probe response offload feature which is for all bands. Thanks.
Quoted 1 line
johannes
Re: [PATCH v3 1/2] nl80211: Unsolicited broadcast probe response support
In reply to Johannes BergQuoted 13 lines · Johannes Berg
Also,
Quoted 10 lines
+/**
+ * enumnl80211_unsol_bcast_probe_resp_attributes- Unsolicited broadcast probe
+ * response configuration. Applicable only in 6GHz.
+ *
+ * @__NL80211_UNSOL_BCAST_PROBE_RESP_INVALID: Invalid
+ *
+ * @NL80211_UNSOL_BCAST_PROBE_RESP_INT: Maximum packet interval (u32, TU).
+ * Allowed range: 0..20 (TU = Time Unit). IEEE P802.11ax/D6.0
Quoted 7 lines
0 doesn't make sense, you should disallow that.
I see you used it for "turn off" at least in the mac80211 patch but it seems to me that should have a more explicit way at least in the external API? At the very least it needs to documentation.
johannes
Hi Johannes, interval=0 means 'disable' is given in the specification, will extend the documentation to mention that.
Re: [PATCH v3 1/2] nl80211: Unsolicited broadcast probe response support
In reply to Johannes BergQuoted 10 lines · Johannes Berg
Quoted 8 lines · Aloka Dixit
This patch adds new attributes to support unsolicited broadcast probe response transmission used for in-band
discovery in 6GHz band (IEEE P802.11ax/D6.0 26.17.2.3.2, AP behavior for fast passive scanning).
The new attribute,NL80211_ATTR_UNSOL_BCAST_PROBE_RESP, is nested which supports following parameters:
(1)NL80211_UNSOL_BCAST_PROBE_RESP_INT- Packet interval
(2)NL80211_UNSOL_BCAST_PROBE_RESP_TMPL- Template data
Quoted 3 lines
And maybe some driver support flag is needed?
johannes
Are you referring to enable/disable flag separate from the interval field being used for that? Or a different command/event from driver to netlink advertising if the driver supports this feature?
If former, it isn't needed because interval=0 means disable.
Thanks.