Skip to contentSkip to conversation

configure: Fix for running with --enable-werror on macOS

PATCH In review Thomas Huth 3 participants 3 messages Jul 16, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configure: Fix for running with --enable-werror on macOS

The configure script currently refuses to succeed when run on macOS with --enable-werror:

ERROR: configure test passed without -Werror but failed with -Werror.

The information in config.log indicates:

config-temp/qemu-conf.c:3:55: error: control reaches end of non-void function [-Werror,-Wreturn-type]
static void *f(void *p) { pthread_setname_np("QEMU"); }

                                                      ^

And indeed, the return statement is missing here.

Fixes 479a57475e ("util: Implement debug-threads for macOS")

---
Note: There is another issue with --enable-werror on macOS, with the
atomic64, which I haven't quite figured out yet, so compiling with --enable-werror is still not working there.

 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure +1 -1
index b751c853f5..e93836aaae 100755
@@ -4198,7 +4198,7 @@ pthread_setname_np_wo_tid=no
 cat > $TMPC << EOF
 #include <pthread.h>
 
-static void *f(void *p) { pthread_setname_np("QEMU"); }
+static void *f(void *p) { pthread_setname_np("QEMU"); return NULL; }
 int main(void)
 {
     pthread_t thread;
Signature · 1 line
2.18.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Thomas Huth

The configure script currently refuses to succeed when run on macOS with --enable-werror:

ERROR: configure test passed without -Werror but failed with -Werror.

Quoted 7 lines

The information in config.log indicates:

config-temp/qemu-conf.c:3:55: error: control reaches end of non-void function [-Werror,-Wreturn-type]
static void *f(void *p) { pthread_setname_np("QEMU"); }

                                                      ^

And indeed, the return statement is missing here.

I have a similar commit dated "2019-07-13 17:13:51" that fixes that too, because I had problem with a CI (cirrus?). I remember there was a discussion about it, as I can't find on the list, I suppose it was discussed on IRC.
I don't remember the outcome, it was negative or the patch was incomplete. I'm happy if it get fixed, so:

Quoted 25 lines
Fixes 479a57475e ("util: Implement debug-threads for macOS")

---
Note: There is another issue with --enable-werror on macOS, with the
atomic64, which I haven't quite figured out yet, so compiling with --enable-werror is still not working there.

 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure +1 -1
index b751c853f5..e93836aaae 100755
@@ -4198,7 +4198,7 @@ pthread_setname_np_wo_tid=no
 cat > $TMPC << EOF
 #include <pthread.h>
 
-static void *f(void *p) { pthread_setname_np("QEMU"); }
+static void *f(void *p) { pthread_setname_np("QEMU"); return NULL; }
 int main(void)
 {
     pthread_t thread;
#2 lore raw
Quoted 15 lines · Philippe Mathieu-Daudé
Quoted 5 lines · Thomas Huth

The configure script currently refuses to succeed when run on macOS with --enable-werror:

ERROR: configure test passed without -Werror but failed with -Werror.

Quoted 7 lines

The information in config.log indicates:

config-temp/qemu-conf.c:3:55: error: control reaches end of non-void function [-Werror,-Wreturn-type]
static void *f(void *p) { pthread_setname_np("QEMU"); }

                                                      ^

And indeed, the return statement is missing here.

Quoted 7 lines

I have a similar commit dated "2019-07-13 17:13:51" that fixes that too, because I had problem with a CI (cirrus?). I remember there was a discussion about it, as I can't find on the list, I suppose it was discussed on IRC.
I don't remember the outcome, it was negative or the patch was incomplete. I'm happy if it get fixed, so:

Oops the other one:

Quoted 28 lines
Quoted 26 lines
Fixes 479a57475e ("util: Implement debug-threads for macOS")

---
Note: There is another issue with --enable-werror on macOS, with the
atomic64, which I haven't quite figured out yet, so compiling with --enable-werror is still not working there.

 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure +1 -1
index b751c853f5..e93836aaae 100755
@@ -4198,7 +4198,7 @@ pthread_setname_np_wo_tid=no
 cat > $TMPC << EOF
 #include <pthread.h>
 
-static void *f(void *p) { pthread_setname_np("QEMU"); }
+static void *f(void *p) { pthread_setname_np("QEMU"); return NULL; }
 int main(void)
 {
     pthread_t thread;