iio:adc:ltc2371: add support for ltc2361/ltc2363
Subsystems (3)
Changelog v1->v2:
- document power supply in yaml
- reorder enums in alphabetical order
- add missing include
- drop the of_match_ptr protection
Darius Berghe (3):
ltc2471: add of_match_table for existing devices
ltc2471: ltc2461/ltc2463 compatible strings ltc2471 driver yaml
.../bindings/iio/adc/adi,ltc2471.yaml | 49 +++++++++++++++++++ drivers/iio/adc/ltc2471.c | 25 ++++++++-- 2 files changed, 70 insertions(+), 4 deletions(-) create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ltc2471.yaml
Signature · 1 line
2.27.0
PATCH v2 1/3 ltc2471: add of_match_table for existing devices
OF style match table was missing, this commit adds it.
--- drivers/iio/adc/ltc2471.c | 9 +++++++++ 1 file changed, 9 insertions(+)
drivers/iio/adc/ltc2471.c +9 -0
@@ -14,6 +14,7 @@#include <linux/module.h> #include <linux/iio/iio.h> #include <linux/iio/sysfs.h> +#include <linux/mod_devicetable.h> enum ltc2471_chips { ltc2471,
@@ -144,9 +145,17 @@ static const struct i2c_device_id ltc2471_i2c_id[] = { };MODULE_DEVICE_TABLE (i2c, ltc2471_i2c_id); +static const struct of_device_id ltc2471_of_match[] = { + { .compatible ="adi,ltc2471" }, + { .compatible ="adi,ltc2473" }, + {} +}; +MODULE_DEVICE_TABLE (of, ltc2471_of_match); +static struct i2c_driver ltc2471_i2c_driver = { .driver = { .name ="ltc2471" , + .of_match_table = ltc2471_of_match }, .probe = ltc2471_i2c_probe, .id_table = ltc2471_i2c_id,
Signature · 1 line
2.27.0
PATCH v2 2/3 ltc2471: ltc2461/ltc2463 compatible strings
In reply to Darius BergheAdd compatible strings for these devices in the existing ltc2471 driver.
--- drivers/iio/adc/ltc2471.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-)
drivers/iio/adc/ltc2471.c +12 -4
@@ -1,5 +1,7 @@/* -* Driver for Linear Technology LTC2471 and LTC2473 voltage monitors +* Driver for Linear Technology LTC2461, LTC2463, LTC2471 and LTC2473 voltage +* monitors. +* The LTC2463 is identical to the 2461, but reports a differential signal. * The LTC2473 is identical to the 2471, but reports a differential signal. * * Copyright (C) 2017 Topic Embedded Products
@@ -17,8 +19,10 @@#include <linux/mod_devicetable.h> enum ltc2471_chips { + ltc2461, + ltc2463, ltc2471, - ltc2473, + ltc2473 };struct ltc2471_data {
@@ -122,7 +126,7 @@ static int ltc2471_i2c_probe(struct i2c_client *client, indio_dev->name = id->name; indio_dev->info = <c2471_info; indio_dev->modes =INDIO_DIRECT_MODE ; -if (id->driver_data == ltc2473) +if (id->driver_data == ltc2473 || id->driver_data == ltc2463) indio_dev->channels = ltc2473_channel;else indio_dev->channels = ltc2471_channel;
@@ -139,6 +143,8 @@ static int ltc2471_i2c_probe(struct i2c_client *client, }static const struct i2c_device_id ltc2471_i2c_id[] = { + {"ltc2461" , ltc2461 }, + {"ltc2463" , ltc2463 }, {"ltc2471" , ltc2471 }, {"ltc2473" , ltc2473 }, {}
@@ -146,6 +152,8 @@ static const struct i2c_device_id ltc2471_i2c_id[] = {MODULE_DEVICE_TABLE (i2c, ltc2471_i2c_id);static const struct of_device_id ltc2471_of_match[] = { + { .compatible ="adi,ltc2461" }, + { .compatible ="adi,ltc2463" }, { .compatible ="adi,ltc2471" }, { .compatible ="adi,ltc2473" }, {}
@@ -163,6 +171,6 @@ static struct i2c_driver ltc2471_i2c_driver = {module_i2c_driver (ltc2471_i2c_driver); -MODULE_DESCRIPTION ("LTC2471/LTC2473 ADC driver" ); +MODULE_DESCRIPTION ("LTC2461/LTC2463/LTC2471/LTC2473 ADC driver" );MODULE_AUTHOR ("Topic Embedded Products" );MODULE_LICENSE ("GPL v2" );
Signature · 1 line
2.27.0
PATCH v2 3/3 ltc2471 driver yaml
In reply to Darius BergheAdd dt binding documentation for ltc2471 driver. This covers all supported devices.
--- .../bindings/iio/adc/adi,ltc2471.yaml | 49 +++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ltc2471.yaml
Documentation/devicetree/bindings/iio/adc/adi,ltc2471.yaml new file +49 -0
@@ -0,0 +1,49 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright 2020 Analog Devices Inc. +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/bindings/iio/adc/adi,ltc2471.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Analog Devices LTC2471 16-bit I2C Sigma-Delta ADC + +maintainers: + - Mike Looijmans <[email protected]> + +description: | + Analog Devices LTC2461 (single-ended) and LTC2463 (differential) 16-bit + I2C Sigma-Delta ADC with 60sps output rate. + https://www.analog.com/media/en/technical-documentation/data-sheets/24613fa.pdf + + Analog Devices LTC2471 (single-ended) and LTC2473 (differential) 16-bit + I2C Sigma-Delta ADC with selectable 208/833sps output rate. + https://www.analog.com/media/en/technical-documentation/data-sheets/24713fb.pdf + +properties: + compatible: + enum: + - adi,ltc2461 + - adi,ltc2463 + - adi,ltc2471 + - adi,ltc2473 + + reg: + maxItems: 1 + + avcc-supply: + description: + Phandle to the Avcc power supply (2.7V - 5.5V) + +required: + - compatible + - reg + +examples: + - | + i2c0 { + adc@14 { + compatible = "adi,ltc2461"; + reg = <0x14>; + }; + }; +
Signature · 1 line
2.27.0
Jonathan Cameron
maintainerQuoted 10 lines · On Thu, 16 Jul 2020 12:46:08 +0300 Darius Berghe <[email protected]>…
Changelog
v1->v2:
- document power supply in yaml
- reorder enums in alphabetical order
- add missing include
- drop theof_match_ptrprotectionDarius Berghe (3):
ltc2471: addof_match_tablefor existing devices
ltc2471: ltc2461/ltc2463 compatible strings ltc2471 driver yaml
All looks fine to me, but please resend with dt list and maintainer cc'd as patch 3 needs a DT review.
Thanks,
Jonathan
Quoted 6 lines
.../bindings/iio/adc/adi,ltc2471.yaml | 49 +++++++++++++++++++ drivers/iio/adc/ltc2471.c | 25 ++++++++-- 2 files changed, 70 insertions(+), 4 deletions(-) create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ltc2471.yaml