Skip to contentSkip to conversation

enable security feature for security tests

PATCH In review David Coyle 3 participants 10 messages Jul 16, 2020 – Jul 18, 2020

lore
Share & tools
lore
#0 lore raw

cover enable security feature for security tests

The RTE_CRYPTODEV_FF_SECURITY feature was disabled through the ff_disable device configuration option for all cryptodev unit tests and crypto performance tests, including security related tests. These patches update the crypto test tools to not disable RTE_CRYPTODEV_FF_SECURITY for DOCSIS and PDCP security tests.

David Coyle (2):
test/crypto: enable security feature for security tests app/crypto-perf: enable security feature for security tests

 app/test-crypto-perf/main.c |  7 +++++--
 app/test/test_cryptodev.c   | 22 ++++++++++++++++++----
 2 files changed, 23 insertions(+), 6 deletions(-)
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/2 test/crypto: enable security feature for security tests

The RTE_CRYPTODEV_FF_SECURITY feature was disabled through the ff_disable device configuration option for all cryptodev tests, including security related tests. This patch updates the cryptodev unit tests to not disable RTE_CRYPTODEV_FF_SECURITY for DOCSIS and PDCP security tests.

Fixes ea31f2b4f547 ("test/crypto: add DOCSIS security cases")
---
 app/test/test_cryptodev.c | 22 ++++++++++++++++++----
 1 file changed, 18 insertions(+), 4 deletions(-)
app/test/test_cryptodev.c +18 -4
index 42e47059a..3d3548bb4 100644
@@ -631,7 +631,7 @@ testsuite_teardown(void)
 }
 
 static int
-ut_setup(void)
+dev_configure_and_start(uint64_t ff_disable)
 {
 	struct crypto_testsuite_params *ts_params = &testsuite_params;
 	struct crypto_unittest_params *ut_params = &unittest_params;
@@ -643,7 +643,7 @@ ut_setup(void)
 
 	/* Reconfigure device to default parameters */
 	ts_params->conf.socket_id = SOCKET_ID_ANY;
-	ts_params->conf.ff_disable = RTE_CRYPTODEV_FF_SECURITY;
+	ts_params->conf.ff_disable = ff_disable;
 	ts_params->qp_conf.nb_descriptors = MAX_NUM_OPS_INFLIGHT;
 	ts_params->qp_conf.mp_session = ts_params->session_mpool;
 	ts_params->qp_conf.mp_session_private = ts_params->session_priv_mpool;
@@ -673,6 +673,20 @@ ut_setup(void)
 	return TEST_SUCCESS;
 }
 
+static int
+ut_setup(void)
+{
+	/* Configure and start the device with security feature disabled */
+	return dev_configure_and_start(RTE_CRYPTODEV_FF_SECURITY);
+}
+
+static int
+ut_setup_security(void)
+{
+	/* Configure and start the device with no features disabled */
+	return dev_configure_and_start(0);
+}
+
 static void
 ut_teardown(void)
 {
@@ -12533,9 +12547,9 @@ static struct unit_test_suite cryptodev_testsuite  = {
 			test_verify_auth_aes_cmac_cipher_null_test_case_1),
 
 #ifdef RTE_LIBRTE_SECURITY
-		TEST_CASE_ST(ut_setup, ut_teardown,
+		TEST_CASE_ST(ut_setup_security, ut_teardown,
 			test_PDCP_PROTO_all),
-		TEST_CASE_ST(ut_setup, ut_teardown,
+		TEST_CASE_ST(ut_setup_security, ut_teardown,
 			test_DOCSIS_PROTO_all),
 #endif
 		TEST_CASES_END() /**< NULL terminate unit test array */
Signature · 1 line
2.17.1
#6 lore raw

PATCH 2/2 app/crypto-perf: enable security feature for security tests

In reply to David Coyle

The RTE_CRYPTODEV_FF_SECURITY feature was disabled through the ff_disable device configuration option for all crypto performance tests, including security related tests. This patch updates the crypto performance tool to not disable RTE_CRYPTODEV_FF_SECURITY for DOCSIS and PDCP security tests.

Fixes d4a131a9498d ("test/crypto-perf: support DOCSIS protocol")
---
 app/test-crypto-perf/main.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
app/test-crypto-perf/main.c +5 -2
index edeea9c1b..8f8e580e4 100644
@@ -203,10 +203,13 @@ cperf_initialize_cryptodev(struct cperf_options *opts, uint8_t *enabled_cdevs)
 		struct rte_cryptodev_config conf = {
 			.nb_queue_pairs = opts->nb_qps,
 			.socket_id = socket_id,
-			.ff_disable = RTE_CRYPTODEV_FF_SECURITY |
-				      RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO,
+			.ff_disable = RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO,
 		};
 
+		if (opts->op_type != CPERF_PDCP &&
+				opts->op_type != CPERF_DOCSIS)
+			conf.ff_disable |= RTE_CRYPTODEV_FF_SECURITY;
+
 		struct rte_cryptodev_qp_conf qp_conf = {
 			.nb_descriptors = opts->nb_descriptors
 		};
Signature · 1 line
2.17.1
Acked-by on v1 2/2
#7 lore raw

Re: [dpdk-dev] [PATCH v1 2/2] app/crypto-perf: enable security feature for security tests

Quoted 11 lines

The RTE_CRYPTODEV_FF_SECURITY feature was disabled through the ff_disable device configuration option for all crypto performance tests, including security related tests. This patch updates the crypto performance tool to not disable RTE_CRYPTODEV_FF_SECURITY for DOCSIS and PDCP security tests.

Fixes d4a131a9498d ("test/crypto-perf: support DOCSIS protocol")

---

Acked-by on v1 1/2
#2 lore raw

Re: [dpdk-dev] [PATCH v1 1/2] test/crypto: enable security feature for security tests

In reply to David Coyle
Quoted 11 lines

The RTE_CRYPTODEV_FF_SECURITY feature was disabled through the ff_disable device configuration option for all cryptodev tests, including security related tests. This patch updates the cryptodev unit tests to not disable RTE_CRYPTODEV_FF_SECURITY for DOCSIS and PDCP security tests.

Fixes ea31f2b4f547 ("test/crypto: add DOCSIS security cases")

---

#4 lore raw

Re: [dpdk-dev] [PATCH v1 1/2] test/crypto: enable security feature for security tests

In reply to David Coyle
Quoted 12 lines

-----Original Message-----
From: Coyle, David <[email protected]>
Sent: Thursday, July 16, 2020 4:30 PM
To: [email protected]; Doherty, Declan <[email protected]>; De Lara Guarch, Pablo <[email protected]>; Trahe, Fiona <[email protected]>
Cc: [email protected]; Ryan, Brendan <[email protected]>; O'loingsigh, Mairtin <[email protected]>; Coyle, David <[email protected]>
Subject: [PATCH v1 1/2] test/crypto: enable security feature for security tests

Quoted 8 lines

The RTE_CRYPTODEV_FF_SECURITY feature was disabled through the ff_disable device configuration option for all cryptodev tests, including security related tests. This patch updates the cryptodev unit tests to not disable RTE_CRYPTODEV_FF_SECURITY for DOCSIS and PDCP security tests.

Fixes ea31f2b4f547 ("test/crypto: add DOCSIS security cases")

Actually, since PDCP security tests were added in previous releases, this could be backported, right? Commit d883e6e71 ("test/crypto: add PDCP C-Plane encap cases") added PDCP test cases and the ff_disable option was already present. Akhil, do you think we need to backport this?

Pablo

#8 lore raw

Re: [dpdk-dev] [PATCH v1 2/2] app/crypto-perf: enable security feature for security tests

In reply to David Coyle
Quoted 13 lines

-----Original Message-----
From: Coyle, David <[email protected]>
Sent: Thursday, July 16, 2020 4:30 PM
To: [email protected]; Doherty, Declan <[email protected]>; De Lara Guarch, Pablo <[email protected]>; Trahe, Fiona <[email protected]>
Cc: [email protected]; Ryan, Brendan <[email protected]>; O'loingsigh, Mairtin <[email protected]>; Coyle, David <[email protected]>
Subject: [PATCH v1 2/2] app/crypto-perf: enable security feature for security tests

Quoted 8 lines

The RTE_CRYPTODEV_FF_SECURITY feature was disabled through the ff_disable device configuration option for all crypto performance tests, including security related tests. This patch updates the crypto performance tool to not disable RTE_CRYPTODEV_FF_SECURITY for DOCSIS and PDCP security tests.

Fixes d4a131a9498d ("test/crypto-perf: support DOCSIS protocol")

Same comment as on the first patch of this set, but with commit 8fd2b5a60d1 ("app/crypto-perf: support PDCP")

Thanks,
Pablo

#5 lore raw

Re: [dpdk-dev] [PATCH v1 1/2] test/crypto: enable security feature for security tests

In reply to De Lara Guarch, Pablo

Hi Pablo,

Quoted 7 lines
Quoted 2 lines

The RTE_CRYPTODEV_FF_SECURITY feature was disabled through the

ff_disable

Quoted 4 lines

device configuration option for all cryptodev tests, including security related tests. This patch updates the cryptodev unit tests to not disable RTE_CRYPTODEV_FF_SECURITY for DOCSIS and PDCP security tests.

Quoted 9 lines
Quoted 3 lines
Fixes ea31f2b4f547 ("test/crypto: add DOCSIS security cases")

Actually, since PDCP security tests were added in previous releases, this could be backported, right? Commit d883e6e71 ("test/crypto: add PDCP C-Plane encap cases") added PDCP test cases and the ff_disable option was already present. Akhil, do you think we need to backport this?

Good catch, but currently PDCP is only supported by NXP platforms and we do not do anything in dev_configure(), so the change will not make any difference. I believe many PMDs are also not doing anything in the dev_configure(). So I believe there is no need to backport this patch. NXP will fix this in the PMDs when it is required.

Regards,
Akhil

#9 lore raw

Re: [dpdk-dev] [PATCH v1 2/2] app/crypto-perf: enable security feature for security tests

In reply to De Lara Guarch, Pablo
Quoted 6 lines
Quoted 1 line

The RTE_CRYPTODEV_FF_SECURITY feature was disabled through the

ff_disable

Quoted 4 lines

device configuration option for all crypto performance tests, including security related tests. This patch updates the crypto performance tool to not disable RTE_CRYPTODEV_FF_SECURITY for DOCSIS and PDCP security tests.

Quoted 7 lines
Quoted 3 lines
Fixes d4a131a9498d ("test/crypto-perf: support DOCSIS protocol")

Same comment as on the first patch of this set, but with commit 8fd2b5a60d1 ("app/crypto-perf: support PDCP")

No need to backport this as well as explained in the 1st patch.

#3 lore raw

Re: [dpdk-dev] [PATCH v1 1/2] test/crypto: enable security feature for security tests

In reply to Akhil Goyal
Quoted 8 lines
Quoted 8 lines

The RTE_CRYPTODEV_FF_SECURITY feature was disabled through the ff_disable device configuration option for all cryptodev tests, including security related tests. This patch updates the cryptodev unit tests to not disable RTE_CRYPTODEV_FF_SECURITY for DOCSIS and PDCP security tests.

Quoted 5 lines
Quoted 4 lines
Fixes ea31f2b4f547 ("test/crypto: add DOCSIS security cases")

---

Patchset applied to dpdk-next-crypto

Thanks.