Skip to contentSkip to conversation

firmware: arm_scmi: Use NULL instead of integer 0 for rate pointer

PATCH Applied Sudeep Holla 2 participants 2 messages Jul 17, 2020 System control & power/management interface (SCPI/SCMI) Message Protocol drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 firmware: arm_scmi: Use NULL instead of integer 0 for rate pointer

Kbuild test robot reports the following sparse warning:

drivers/firmware/arm_scmi/clock.c:142:21:
sparse: Using plain integer as NULL pointer

Use NULL pointer instead of integer 0 for rate pointer and fix the warning.

---
 drivers/firmware/arm_scmi/clock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Hi Arnd,

Kbuild test robot reported this warning from the soc tree. Can you apply this directly or do you prefer pull request. Let me know.

Regards,
Sudeep

drivers/firmware/arm_scmi/clock.c +1 -1
index 6593ce87f420..75e39882746e 100644
@@ -139,7 +139,7 @@ static int
 scmi_clock_describe_rates_get(const struct scmi_handle *handle, u32 clk_id,
 			      struct scmi_clock_info *clk)
 {
-	u64 *rate = 0;
+	u64 *rate = NULL;
 	int ret, cnt;
 	bool rate_discrete = false;
 	u32 tot_rate_cnt = 0, rates_flag;

--
2.17.1

#1 lore raw
Quoted 11 lines · Sudeep Holla

Kbuild test robot reports the following sparse warning:

drivers/firmware/arm_scmi/clock.c:142:21:
sparse: Using plain integer as NULL pointer

Use NULL pointer instead of integer 0 for rate pointer and fix the warning.

Quoted 8 lines
---
 drivers/firmware/arm_scmi/clock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Hi Arnd,

Kbuild test robot reported this warning from the soc tree. Can you apply this directly or do you prefer pull request. Let me know.

Applied, thanks!

Arnd