Skip to contentSkip to conversation

ipvs: missing unlock in ip_vs_expire_nodest_conn_flush()

PATCH New Dan Carpenter 1 participant 1 message Jul 17, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ipvs: missing unlock in ip_vs_expire_nodest_conn_flush()

We can't return without calling rcu_read_unlock().

Fixes 04231e52d355 ("ipvs: queue delayed work to expire no destination connections if expire_nodest_conn=1")
---
 net/netfilter/ipvs/ip_vs_conn.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/netfilter/ipvs/ip_vs_conn.c +1 -1
index a5e9b2d55e57..a90b8eac16ac 100644
@@ -1422,7 +1422,7 @@ void ip_vs_expire_nodest_conn_flush(struct netns_ipvs *ipvs)
 
 		/* netns clean up started, abort delayed work */
 		if (!ipvs->enable)
-			return;
+			break;
 	}
 	rcu_read_unlock();
 }
Signature · 1 line
2.27.0