Skip to contentSkip to conversation

dt-bindings: i2c-gpio: Use 'deprecated' keyword on deprecated properties

PATCH In review Rob Herring 2 participants 3 messages Jul 17, 2020 – Jul 22, 2020

Subsystems (2)
Device tree bindings I2C subsystem host drivers
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: i2c-gpio: Use 'deprecated' keyword on deprecated properties

The i2c-gpio binding is the only case of 'not: true' being used for a deprecated property. Update it to use the json-schema 2019.09 'deprecated' keyword instead. Define the type too in order to keep the meta-schema happy.

This will disable warnings for these properties until the dtschema tools are updated to handle 'deprecated', but they are only used in a few at91 dts files.

Cc Wolfram Sang <[email protected]>
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>
---
 Documentation/devicetree/bindings/i2c/i2c-gpio.yaml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/i2c/i2c-gpio.yaml +4 -4
index da6129090a8e..78ffcab2428c 100644
@@ -52,15 +52,15 @@ properties:
     description: sda and scl gpio, alternative for {sda,scl}-gpios
 
   i2c-gpio,sda-open-drain:
-    # Generate a warning if present
-    not: true
+    type: boolean
+    deprecated: true
     description: this means that something outside of our control has put
       the GPIO line used for SDA into open drain mode, and that something is
       not the GPIO chip. It is essentially an inconsistency flag.
 
   i2c-gpio,scl-open-drain:
-    # Generate a warning if present
-    not: true
+    type: boolean
+    deprecated: true
     description: this means that something outside of our control has put the
       GPIO line used for SCL into open drain mode, and that something is not
       the GPIO chip. It is essentially an inconsistency flag.
Signature · 1 line
2.25.1
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Rob Herring

The i2c-gpio binding is the only case of 'not: true' being used for a deprecated property. Update it to use the json-schema 2019.09 'deprecated' keyword instead. Define the type too in order to keep the meta-schema happy.

Quoted 7 lines

This will disable warnings for these properties until the dtschema tools are updated to handle 'deprecated', but they are only used in a few at91 dts files.

Cc Wolfram Sang <[email protected]>
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>

Your tree or mine? for the latter case:

Acked-by Wolfram Sang <[email protected]>
author maintainer
#2 lore raw
Quoted 11 lines · Wolfram Sang
Quoted 9 lines · Rob Herring

The i2c-gpio binding is the only case of 'not: true' being used for a deprecated property. Update it to use the json-schema 2019.09 'deprecated' keyword instead. Define the type too in order to keep the meta-schema happy.

This will disable warnings for these properties until the dtschema tools are updated to handle 'deprecated', but they are only used in a few at91 dts files.

Quoted 7 lines
Quoted 3 lines
Cc Wolfram Sang <[email protected]>
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>

Your tree or mine? for the latter case:

Acked-by Wolfram Sang <[email protected]>

Thanks, I've applied it.

Rob