Skip to contentSkip to conversation

f2fs: compress: fix to avoid memory leak on cc->cpages

PATCH In review Chao Yu 1 participant 2 messages Jul 20, 2020 F2FS file system

lore
Share & tools
lore

Chao Yu

author
#0 lore raw

PATCH 1/1 f2fs: compress: fix to avoid memory leak on cc->cpages

Memory allocated for storing compressed pages' poitner should be released after f2fs_write_compressed_pages(), otherwise it will cause memory leak issue.

---
 fs/f2fs/compress.c | 2 ++
 1 file changed, 2 insertions(+)
fs/f2fs/compress.c +2 -0
index 3a847bc36748..a20c9f3272af 100644
@@ -1385,6 +1385,8 @@ int f2fs_write_multi_pages(struct compress_ctx *cc,
 		err = f2fs_write_compressed_pages(cc, submitted,
 							wbc, io_type);
 		cops->destroy_compress_ctx(cc);
+		kfree(cc->cpages);
+		cc->cpages = NULL;
 		if (!err)
 			return 0;
 		f2fs_bug_on(F2FS_I_SB(cc->inode), err != -EAGAIN);
Signature · 1 line
2.26.2
author
#1 lore raw
Quoted 3 lines · Chao Yu

Memory allocated for storing compressed pages' poitner should be released after f2fs_write_compressed_pages(), otherwise it will cause memory leak issue.

Jaegeuk,

Please help to add below tag when merging, thanks.

Fixes 4c8ff7095bef ("f2fs: support data compression")
Quoted 20 lines
---
  fs/f2fs/compress.c | 2 ++
  1 file changed, 2 insertions(+)
fs/f2fs/compress.c +2 -0
index 3a847bc36748..a20c9f3272af 100644
@@ -1385,6 +1385,8 @@ int f2fs_write_multi_pages(struct compress_ctx *cc,
  		err = f2fs_write_compressed_pages(cc, submitted,
  							wbc, io_type);
  		cops->destroy_compress_ctx(cc);
+		kfree(cc->cpages);
+		cc->cpages = NULL;
  		if (!err)
  			return 0;
  		f2fs_bug_on(F2FS_I_SB(cc->inode), err != -EAGAIN);