Skip to contentSkip to conversation

selftests/bpf: fix test_lwt_seg6local.sh hangs

PATCH In review Ilya Leoshkevich 2 participants 2 messages Jul 20, 2020 – Jul 21, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests/bpf: fix test_lwt_seg6local.sh hangs

OpenBSD netcat (Debian patchlevel 1.195-2) does not seem to react to SIGINT for whatever reason, causing prefix.pl to hang after test_lwt_seg6local.sh exits due to netcat inheriting test_lwt_seg6local.sh's file descriptors.

Fix by using SIGTERM instead.

---
 tools/testing/selftests/bpf/test_lwt_seg6local.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/test_lwt_seg6local.sh +1 -1
index 785eabf2a593..5620919fde9e 100755
@@ -140,7 +140,7 @@ ip netns exec ns6 sysctl net.ipv6.conf.veth10.seg6_enabled=1 > /dev/null
 ip netns exec ns6 nc -l -6 -u -d 7330 > $TMP_FILE &
 ip netns exec ns1 bash -c "echo 'foobar' | nc -w0 -6 -u -p 2121 -s fb00::1 fb00::6 7330"
 sleep 5 # wait enough time to ensure the UDP datagram arrived to the last segment
-kill -INT $!
+kill -TERM $!
 
 if [[ $(< $TMP_FILE) != "foobar" ]]; then
 	exit 1
Signature · 1 line
2.25.4
#1 lore raw
Quoted 18 lines · Ilya Leoshkevich

OpenBSD netcat (Debian patchlevel 1.195-2) does not seem to react to SIGINT for whatever reason, causing prefix.pl to hang after test_lwt_seg6local.sh exits due to netcat inheriting test_lwt_seg6local.sh's file descriptors.

Fix by using SIGTERM instead.

---
 tools/testing/selftests/bpf/test_lwt_seg6local.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/test_lwt_seg6local.sh +0 -0
index 785eabf2a593..5620919fde9e 100755

tools/testing/selftests/bpf/test_lwt_seg6local.sh ip netns exec ns6 sysctl net.ipv6.conf.veth10.seg6_enabled=1 > /dev/null · line 143

Quoted 5 lines
tools/testing/selftests/bpf/test_lwt_seg6local.sh +1 -1
@@ -140,7 +140,7 @@ ip netns exec ns6 sysctl net.ipv6.conf.veth10.seg6_enabled=1 > /dev/null
 ip netns exec ns6 nc -l -6 -u -d 7330 > $TMP_FILE &
 ip netns exec ns1 bash -c "echo 'foobar' | nc -w0 -6 -u -p 2121 -s fb00::1 fb00::6 7330"
 sleep 5 # wait enough time to ensure the UDP datagram arrived to the last segment
-kill -INT $!
+kill -TERM $!

Applied.
The test doesn't work for me anyway:
Ncat: Invalid -w timeout (must be greater than 0). QUITTING.
selftests: test_lwt_seg6local [FAILED]
Ncat: Since April 2010, the default unit for -d is seconds, so your time of "7330" is 122.2 minutes. Use "7330ms" for 7330 milliseconds. QUITTING.