ARM: dts: rockchip: Add usb host0 ohci node for rk3288
Subsystems (2)
PATCH v3 1/1 ARM: dts: rockchip: Add usb host0 ohci node for rk3288
rk3288 and rk3288w have a usb host0 ohci controller.
Although rk3288 ohci doesn't actually work on hardware, but rk3288w ohci can work well.
So add usb host0 ohci node in rk3288 dtsi and the quirk in ohci platform driver will disable ohci on rk3288.
---
Changes for v3:
- none
arch/arm/boot/dts/rk3288.dtsi | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)
arch/arm/boot/dts/rk3288.dtsi +10 -1
@@ -614,7 +614,16 @@ usb_host0_ehci: usb@ff500000 { status = "disabled"; }; - /* NOTE: ohci@ff520000 doesn't actually work on hardware */ + /* NOTE: doesn't work on RK3288, but fixed on RK3288W */ + usb_host0_ohci: usb@ff520000 { + compatible = "generic-ohci"; + reg = <0x0 0xff520000 0x0 0x100>; + interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cru HCLK_USBHOST0>; + phys = <&usbphy1>; + phy-names = "usb"; + status = "disabled"; + }; usb_host1: usb@ff540000 { compatible = "rockchip,rk3288-usb", "rockchip,rk3066-usb",
Signature · 1 line
2.25.1
Heiko Stuebner
maintainerHi Jaganm
Am Montag, 20. Juli 2020, 12:58:46 CEST schrieb Jagan Teki:
Quoted 7 lines
rk3288 and rk3288w have a usb host0 ohci controller.
Although rk3288 ohci doesn't actually work on hardware, but rk3288w ohci can work well.
So add usb host0 ohci node in rk3288 dtsi and the quirk in ohci platform driver will disable ohci on rk3288.
If I remember the discussion correctly, we expect the board dts or the bootloader to enable the ohci, right?
So that block go away ... just making sure, I don't remember untrue stuff ;-)
Heiko
Quoted 32 lines
Cc William Wu <[email protected]>---
Changes for v3:
- nonearch/arm/boot/dts/rk3288.dtsi | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)arch/arm/boot/dts/rk3288.dtsi +10
-1@@ -614,7 +614,16 @@ usb_host0_ehci: usb@ff500000 { status = "disabled"; }; - /* NOTE: ohci@ff520000 doesn't actually work on hardware */ + /* NOTE: doesn't work on RK3288, but fixed on RK3288W */ + usb_host0_ohci: usb@ff520000 { + compatible = "generic-ohci"; + reg = <0x0 0xff520000 0x0 0x100>; + interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cru HCLK_USBHOST0>; + phys = <&usbphy1>; + phy-names = "usb"; + status = "disabled"; + }; usb_host1: usb@ff540000 { compatible = "rockchip,rk3288-usb", "rockchip,rk3066-usb",
Hi Heiko,
Quoted 9 lines · Heiko Stuebner
Hi Jaganm
Am Montag, 20. Juli 2020, 12:58:46 CEST schrieb Jagan Teki:
Quoted 5 lines
rk3288 and rk3288w have a usb host0 ohci controller.
Although rk3288 ohci doesn't actually work on hardware, but rk3288w ohci can work well.
Quoted 7 lines
Quoted 2 lines
So add usb host0 ohci node in rk3288 dtsi and the quirk in ohci platform driver will disable ohci on rk3288.
If I remember the discussion correctly, we expect the board dts or the bootloader to enable the ohci, right?
So that block go away ... just making sure, I don't remember untrue stuff ;-)
Our (with Robin) initial discussion [1] is to manage OHCI enablement in the bootloader but since it requires many checks at bootloader level we finally rely on board dts to enable it as normal.
[1] https://lkml.org/lkml/2020/7/3/424
Jagan.
Heiko Stuebner
maintainerAm Mittwoch, 22. Juli 2020, 20:46:55 CEST schrieb Jagan Teki:
Quoted 15 lines
Hi Heiko,
Quoted 12 lines · Heiko Stuebner
Hi Jaganm
Am Montag, 20. Juli 2020, 12:58:46 CEST schrieb Jagan Teki:
Quoted 7 lines
rk3288 and rk3288w have a usb host0 ohci controller.
Although rk3288 ohci doesn't actually work on hardware, but rk3288w ohci can work well.
So add usb host0 ohci node in rk3288 dtsi and the quirk in ohci platform driver will disable ohci on rk3288.
Quoted 8 lines
Quoted 4 lines
If I remember the discussion correctly, we expect the board dts or the bootloader to enable the ohci, right?
So that block go away ... just making sure, I don't remember untrue stuff ;-)Our (with Robin) initial discussion [1] is to manage OHCI enablement in the bootloader but since it requires many checks at bootloader level we finally rely on board dts to enable it as normal.
ok, so I'll just drop this paragraph when applying.
Quoted 5 lines
[1] https://lkml.org/lkml/2020/7/3/424
Jagan.
Quoted 7 lines · Jagan Teki
rk3288 and rk3288w have a usb host0 ohci controller.
Although rk3288 ohci doesn't actually work on hardware, but rk3288w ohci can work well.
So add usb host0 ohci node in rk3288 dtsi and the quirk in ohci platform driver will disable ohci on rk3288.
Applied, thanks!
[1/1] ARM: dts: rockchip: Add usb host0 ohci node for rk3288
commit: 82540defdd9cfc491f564ffb8d01911966636bc7
Best regards,
Signature · 1 line
Heiko Stuebner <[email protected]>