drm/v3d: remove second free in v3d_submit_cl_ioctl
Subsystems (3)
PATCH 1/1 drm/v3d: remove second free in v3d_submit_cl_ioctl
From: Tom Rix <[email protected]>
clang static analysis reports this error
v3d_gem.c:573:4: warning: Attempt to free released
memory [unix.Malloc]
kfree(bin);
^~~~~~~~~~Problem is in the block of code
if (ret) {
kfree(bin);
v3d_job_put(&render->base);
kfree(bin);
return ret;
}Obviously bin is freed twice.
So remove one.
Fixes 0d352a3a8a1f ("drm/v3d: don't leak bin job if v3d_job_init fails.")
Fixes 29cd13cfd762 ("drm/v3d: Fix memory leak in v3d_submit_cl_ioctl")
Signed-off-by Tom Rix <[email protected]>
--- drivers/gpu/drm/v3d/v3d_gem.c | 1 - 1 file changed, 1 deletion(-)
drivers/gpu/drm/v3d/v3d_gem.c +0 -1
@@ -570,7 +570,6 @@ v3d_submit_cl_ioctl(struct drm_device *dev, void *data,if (ret) {kfree (bin);v3d_job_put (&render->base); -kfree (bin);return ret; }
Signature · 1 line
2.18.1