add multi-host support in the phosphor-post-code-manager
Hi All,
We woukld like to get opion on below multi-host support approaches.
Background :
------------
The Phosphor-post-code-manager supports only host
to store/retrieve the host postcode history.
Approaches:
-----------
Approach 1: << run the multiple process >>
Create and run the multiple phosphor-post-code-manager process to handle each host postcode history.
xyz.openbmc_project.State.Host0.Boot.PostCode
xyz.openbmc_project.State.Host1.Boot.PostCode
xyz.openbmc_project.State.Host2.Boot.PostCode
xyz.openbmc_project.State.Host3.Boot.PostCode
Approach 2: << pass number of host to single process >>
Pass number of host to single process phosphor-post-code-manager to register dbus object and handle each host postcode.
xyz.openbmc_project.State.Host0.Boot.PostCode
xyz.openbmc_project.State.Host1.Boot.PostCode
xyz.openbmc_project.State.Host2.Boot.PostCode
xyz.openbmc_project.State.Host3.Boot.PostCode
Thanks
Mani.E
Quoted 3 lines · Manikandan
Approach 1: << run the multiple process >>
Create and run the multiple phosphor-post-code-manager process to handle each host postcode history.
I would lean towards this implementation because I think it is more flexible in the long term. Some multi-host systems are hot-pluggable such that you do not statically know how many you're going to have. In some cases you have cards that take up two or three slots, so you really don't know the correct topology until you've done discovery.
Signature · 1 line
Patrick Williams
Quoted 10 lines · Patrick Williams
Quoted 3 lines · Manikandan
Approach 1: << run the multiple process >>
Create and run the multiple phosphor-post-code-manager process to handle each host postcode history.
I would lean towards this implementation because I think it is more flexible in the long term. Some multi-host systems are hot-pluggable such that you do not statically know how many you're going to have. In some cases you have cards that take up two or three slots, so you really don't know the correct topology until you've done discovery.
Thanks Patrick.
Our platfrom is also based on hot-pluggable multi-host(four) card in chassis. we have either four host in slots or 2 host with two device card hardware topology. As you mentioned above on multi-process , Do we need to start and stop each instance based on host present in the slot at start-up and runtime.
For example if only 2 host connected in slot with other slots empty, do we need to start only 2 instance and stop the instance when corresponding host card removed from slot at run time.
I understand that you are refering the same design implemented in x86-power-control and obmc-console for multi-host..
Quoted 3 lines
Signature · 2 lines
-- Patrick Williams
Quoted 11 lines · Patrick Williams
Quoted 3 lines · Manikandan
Approach 1: << run the multiple process >>
Create and run the multiple phosphor-post-code-manager process to handle each host postcode history.
I would lean towards this implementation because I think it is more flexible in the long term. Some multi-host systems are hot-pluggable such that you do not statically know how many you're going to have. In some cases you have cards that take up two or three slots, so you really don't know the correct topology until you've done discovery.
Hi Patrick,
our platform also hot-plug-able and supports maximum four host with different hardware topology. Do we need register and unregister based on hosts inserted or removed from the slot.
The multi-host support on obmc-console, host-logger and x86-power-control based on number of host passed from receipe.
I have updated design docuement in below Gerrit and your comments will helpful regards hot-plug-able host D-Bus creation and deletion.
https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/35065
Thanks
Mani.E
Quoted 2 lines
Signature · 1 line
Patrick Williams
I would think that one process to handle all post-code is a cleaner design.
-----Original Message-----
From: openbmc <[email protected]> On Behalf Of Manikandan
Sent: Monday, July 20, 2020 9:00 AM
To: [email protected]
Cc: Wang, Kuiying <[email protected]>; [email protected]; [email protected]
Subject: add multi-host support in the phosphor-post-code-manager
Hi All,
We woukld like to get opion on below multi-host support approaches.
Background :
------------
The Phosphor-post-code-manager supports only host to store/retrieve the host postcode history.
Approaches:
-----------
Approach 1: << run the multiple process >>
Create and run the multiple phosphor-post-code-manager process to handle each host postcode history.
xyz.openbmc_project.State.Host0.Boot.PostCode
xyz.openbmc_project.State.Host1.Boot.PostCode
xyz.openbmc_project.State.Host2.Boot.PostCode
xyz.openbmc_project.State.Host3.Boot.PostCode
Approach 2: << pass number of host to single process >>
Pass number of host to single process phosphor-post-code-manager to register dbus object and handle each host postcode.
xyz.openbmc_project.State.Host0.Boot.PostCode
xyz.openbmc_project.State.Host1.Boot.PostCode
xyz.openbmc_project.State.Host2.Boot.PostCode
xyz.openbmc_project.State.Host3.Boot.PostCode
Thanks
Mani.E
I would also prefer single process design but as Patrick mentioned about hot pluggable Host, either we can predefine maximum allowed host per platform or go for multi process approach for complete dynamic pluggable host.
We really need to assess what is the disadvantage in predefining maximum number of hosts With single process because there will be limited slots available per platform.
On 7/21/20, 10:12 AM, "openbmc on behalf of Ren, Zhikui" <[email protected] on behalf of [email protected]> wrote:
I would think that one process to handle all post-code is a cleaner design.
-----Original Message-----
From: openbmc <[email protected]> On Behalf Of Manikandan
Sent: Monday, July 20, 2020 9:00 AM
To: [email protected]
Cc: Wang, Kuiying <[email protected]>; [email protected]; [email protected]
Subject: add multi-host support in the phosphor-post-code-manager
Hi All,
We woukld like to get opion on below multi-host support approaches.
Background :
------------
The Phosphor-post-code-manager supports only host to store/retrieve the host postcode history.
Approaches:
-----------
Approach 1: << run the multiple process >>
Create and run the multiple phosphor-post-code-manager process to handle each host postcode history.
xyz.openbmc_project.State.Host0.Boot.PostCode xyz.openbmc_project.State.Host1.Boot.PostCode xyz.openbmc_project.State.Host2.Boot.PostCode xyz.openbmc_project.State.Host3.Boot.PostCode
Approach 2: << pass number of host to single process >>
Pass number of host to single process phosphor-post-code-manager to register dbus object and handle each host postcode.
xyz.openbmc_project.State.Host0.Boot.PostCode xyz.openbmc_project.State.Host1.Boot.PostCode xyz.openbmc_project.State.Host2.Boot.PostCode xyz.openbmc_project.State.Host3.Boot.PostCode
Thanks
Mani.E
Quoted 6 lines · Vijay Khemka
I would also prefer single process design but as Patrick mentioned about hot pluggable Host, either we can predefine maximum allowed host per platform or go for multi process approach for complete dynamic pluggable host.
We really need to assess what is the disadvantage in predefining maximum number of hosts With single process because there will be limited slots available per platform.
Thanks Vijay for comment.
The Multi-host on obmc-console and x86-power-control design and implemetation based on multi-process as i checked source code.
As already obmc-console and x86-power-control agreed on multi-process , Is there specific reason we need to go for the single process design to support on multi-host postcode.
I understand that x86-power-control initially planned to have single process for multi-host and then later changed to the multi-process.
Quoted 1 line · Zhikui
I would think that one process to handle all post-code is a cleaner design.
Thanks Ren for comments.
As Patrick mentioned on different hardware toplogy and hot-plug-able concept matches with our platform.
As per my undersatnd on recent multi-host feature such as
obmc-console, host-logger and x86-power-control implemented based on the multi-process.
I will update design doc in Gerrit to discuss to further on single or multi-host approach.
Quoted 39 lines
-----Original Message-----
From: openbmc <[email protected]> On Behalf Of Manikandan
Sent: Monday, July 20, 2020 9:00 AM
To: [email protected]
Cc: Wang, Kuiying <[email protected]>; [email protected]; [email protected]
Subject: add multi-host support in the phosphor-post-code-managerHi All,
We woukld like to get opion on below multi-host support approaches.
Background :
------------
The Phosphor-post-code-manager supports only host to store/retrieve the host postcode history.Approaches:
-----------
Approach 1: << run the multiple process >>Create and run the multiple phosphor-post-code-manager process to handle each host postcode history.
xyz.openbmc_project.State.Host0.Boot.PostCode
xyz.openbmc_project.State.Host1.Boot.PostCode
xyz.openbmc_project.State.Host2.Boot.PostCode
xyz.openbmc_project.State.Host3.Boot.PostCodeApproach 2: << pass number of host to single process >>
Pass number of host to single process phosphor-post-code-manager to register dbus object and handle each host postcode.
xyz.openbmc_project.State.Host0.Boot.PostCode
xyz.openbmc_project.State.Host1.Boot.PostCode
xyz.openbmc_project.State.Host2.Boot.PostCode
xyz.openbmc_project.State.Host3.Boot.PostCodeThanks
Mani.E
-----Original Message-----
From: Manikandan <[email protected]>
Sent: Friday, July 24, 2020 9:21 AM
To: Ren, Zhikui <[email protected]>
Cc: [email protected]; Wang, Kuiying <[email protected]>; [email protected]; [email protected]
Subject: Re: add multi-host support in the phosphor-post-code-manager
Quoted 1 line · Zhikui
I would think that one process to handle all post-code is a cleaner design.
Thanks Ren for comments.
As Patrick mentioned on different hardware toplogy and hot-plug-able concept matches with our platform.
As per my undersatnd on recent multi-host feature such as
obmc-console, host-logger and x86-power-control implemented based on the multi-process.
I will update design doc in Gerrit to discuss to further on single or multi-host approach.
Quoted 40 lines
It is good to be consistent. Thanks.
-----Original Message-----
From: openbmc <[email protected]> On Behalf Of Manikandan
Sent: Monday, July 20, 2020 9:00 AM
To: [email protected]
Cc: Wang, Kuiying <[email protected]>; [email protected]; [email protected]
Subject: add multi-host support in the phosphor-post-code-managerHi All,
We woukld like to get opion on below multi-host support approaches.
Background :
------------
The Phosphor-post-code-manager supports only host to store/retrieve the host postcode history.Approaches:
-----------
Approach 1: << run the multiple process >>Create and run the multiple phosphor-post-code-manager process to handle each host postcode history.
xyz.openbmc_project.State.Host0.Boot.PostCode
xyz.openbmc_project.State.Host1.Boot.PostCode
xyz.openbmc_project.State.Host2.Boot.PostCode
xyz.openbmc_project.State.Host3.Boot.PostCodeApproach 2: << pass number of host to single process >>
Pass number of host to single process phosphor-post-code-manager to register dbus object and handle each host postcode.
xyz.openbmc_project.State.Host0.Boot.PostCode
xyz.openbmc_project.State.Host1.Boot.PostCode
xyz.openbmc_project.State.Host2.Boot.PostCode
xyz.openbmc_project.State.Host3.Boot.PostCodeThanks
Mani.E
Please see all my comments in the Gerrit.
Thanks,
Kwin.
-----Original Message-----
From: Ren, Zhikui <[email protected]>
Sent: Saturday, July 25, 2020 12:32 AM
To: Manikandan <[email protected]>
Cc: [email protected]; Wang, Kuiying <[email protected]>; [email protected]; [email protected]
Subject: RE: add multi-host support in the phosphor-post-code-manager
-----Original Message-----
From: Manikandan <[email protected]>
Sent: Friday, July 24, 2020 9:21 AM
To: Ren, Zhikui <[email protected]>
Cc: [email protected]; Wang, Kuiying <[email protected]>; [email protected]; [email protected]
Subject: Re: add multi-host support in the phosphor-post-code-manager
Quoted 1 line · Zhikui
I would think that one process to handle all post-code is a cleaner design.
Thanks Ren for comments.
As Patrick mentioned on different hardware toplogy and hot-plug-able concept matches with our platform.
As per my undersatnd on recent multi-host feature such as
obmc-console, host-logger and x86-power-control implemented based on the multi-process.
I will update design doc in Gerrit to discuss to further on single or multi-host approach.
Quoted 40 lines
It is good to be consistent. Thanks.
-----Original Message-----
From: openbmc <[email protected]> On Behalf Of Manikandan
Sent: Monday, July 20, 2020 9:00 AM
To: [email protected]
Cc: Wang, Kuiying <[email protected]>; [email protected]; [email protected]
Subject: add multi-host support in the phosphor-post-code-managerHi All,
We woukld like to get opion on below multi-host support approaches.
Background :
------------
The Phosphor-post-code-manager supports only host to store/retrieve the host postcode history.Approaches:
-----------
Approach 1: << run the multiple process >>Create and run the multiple phosphor-post-code-manager process to handle each host postcode history.
xyz.openbmc_project.State.Host0.Boot.PostCode
xyz.openbmc_project.State.Host1.Boot.PostCode
xyz.openbmc_project.State.Host2.Boot.PostCode
xyz.openbmc_project.State.Host3.Boot.PostCodeApproach 2: << pass number of host to single process >>
Pass number of host to single process phosphor-post-code-manager to register dbus object and handle each host postcode.
xyz.openbmc_project.State.Host0.Boot.PostCode
xyz.openbmc_project.State.Host1.Boot.PostCode
xyz.openbmc_project.State.Host2.Boot.PostCode
xyz.openbmc_project.State.Host3.Boot.PostCodeThanks
Mani.E