Skip to contentSkip to conversation

HID: apple: Add support for Matias wireless keyboard

PATCH In review BALATON Zoltan 2 participants 5 messages Jul 20, 2020 – Aug 17, 2020 HID

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 HID: apple: Add support for Matias wireless keyboard

The Matias Wireless keyboard has an Apple like layout and identifies as ISO RevB Alu keyboard. Use hid-apple for it so Fn key and media control functions work as expected.

---
 drivers/hid/hid-apple.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/hid/hid-apple.c +2 -0
index e82f604d33e9..6b8f0d004d34 100644
@@ -503,6 +503,8 @@ static const struct hid_device_id apple_devices[] = {
 		.driver_data = APPLE_HAS_FN },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_REVB_ISO),
 		.driver_data = APPLE_HAS_FN },
+	{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_REVB_ISO),
+		.driver_data = APPLE_HAS_FN },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_REVB_JIS),
 		.driver_data = APPLE_HAS_FN },
 	{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_WIRELESS_ANSI),
Signature · 1 line
2.21.3
maintainer
#1 lore raw
Quoted 5 lines · BALATON Zoltan

The Matias Wireless keyboard has an Apple like layout and identifies as ISO RevB Alu keyboard. Use hid-apple for it so Fn key and media control functions work as expected.

So If I understand correctly, this keyboard identifies itself with Apple VID, but in fact it is not.

I'd like to make sure that we don't break the real USB_DEVICE_ID_APPLE_ALU_REVB_ISO device produced by Apple; CCing Dan Bastone, who added this device ID back in 2011 (4a4c879904aa). Dan, any ideas please?

Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs
maintainer
#2 lore raw
Quoted 6 lines · Jiri Kosina
Quoted 5 lines

The Matias Wireless keyboard has an Apple like layout and identifies as ISO RevB Alu keyboard. Use hid-apple for it so Fn key and media control functions work as expected.

Quoted 7 lines

So If I understand correctly, this keyboard identifies itself with Apple VID, but in fact it is not.

I'd like to make sure that we don't break the real USB_DEVICE_ID_APPLE_ALU_REVB_ISO device produced by Apple; CCing Dan Bastone, who added this device ID back in 2011 (4a4c879904aa). Dan, any ideas please?

OK, Dan's e-mail address doesn't work any more. Let's conservatively queue this for 5.10, and in case there are any regression reports against stock Apple keyboards, we'll have to look for ways to work it around.

Yay for VID sharing :/

Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs
#3 lore raw
In reply to Jiri Kosina
Quoted 5 lines · Jiri Kosina
Quoted 4 lines · BALATON Zoltan

The Matias Wireless keyboard has an Apple like layout and identifies as ISO RevB Alu keyboard. Use hid-apple for it so Fn key and media control functions work as expected.

Quoted 7 lines
Quoted 1 line

So If I understand correctly, this keyboard identifies itself with Apple VID, but in fact it is not.

I'd like to make sure that we don't break the real USB_DEVICE_ID_APPLE_ALU_REVB_ISO device produced by Apple; CCing Dan

AFAIK the Apple keyboard with the same pid is a USB one and is already handled by hid-apple. This one is a bluetooth keyboard so probably does not really clash and even if there's an Apple wireless keyboard with the same pid it's more likely we want hid-apple for that too so it's unlikely to break anything. (This Matias keyboard looks and acts like an Apple keyboard so probably uses this vid/pid to have macOS work better with it out of the box without needing additional setup.)

Regards,
BALATON Zoltan

maintainer
#4 lore raw
Quoted 7 lines · BALATON Zoltan

AFAIK the Apple keyboard with the same pid is a USB one and is already handled by hid-apple. This one is a bluetooth keyboard so probably does not really clash and even if there's an Apple wireless keyboard with the same pid it's more likely we want hid-apple for that too so it's unlikely to break anything. (This Matias keyboard looks and acts like an Apple keyboard so probably uses this vid/pid to have macOS work better with it out of the box without needing additional setup.)

Thanks for the bakcground. The patch is now in hid.git#for-5.10/apple

Signature · 2 lines
Jiri Kosina
SUSE Labs