tipc: remove set but not used variable 'no_warn'
PATCH 1/1 tipc: remove set but not used variable 'no_warn'
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/base/module.c: In function 'module_add_driver':drivers/base/module.c:33: warning:
variable 'no_warn' set but not used [-Wunused-but-set-variable]
--- drivers/base/module.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/base/module.c +2 -3
@@ -33,7 +33,6 @@ static void module_create_drivers_dir(struct module_kobject *mk)void module_add_driver (struct module *mod,struct device_driver *drv) {char *driver_name; -int no_warn;struct module_kobject *mk =NULL ;if (!drv)
@@ -59,11 +58,11 @@ void module_add_driver(struct module *mod, struct device_driver *drv)return ;/* Don't check return codes; these calls are idempotent */ - no_warn =sysfs_create_link (&drv->p->kobj, &mk->kobj,"module" ); +sysfs_create_link (&drv->p->kobj, &mk->kobj,"module" ); driver_name =make_driver_name (drv);if (driver_name) {module_create_drivers_dir (mk); - no_warn =sysfs_create_link (mk->drivers_dir, &drv->p->kobj, +sysfs_create_link (mk->drivers_dir, &drv->p->kobj, driver_name);kfree (driver_name); }
Signature · 1 line
2.17.1
Greg KH
maintainerQuoted 24 lines · Zheng Yongjun
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/base/module.c: In function 'module_add_driver':drivers/base/module.c:33: warning:
variable 'no_warn' set but not used [-Wunused-but-set-variable]Signed-off-by Zheng Yongjun <[email protected]>--- drivers/base/module.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/base/module.c +0
-1@@ -33,7 +33,6 @@ static void module_create_drivers_dir(struct module_kobject *mk)void module_add_driver (struct module *mod,struct device_driver *drv) {char *driver_name; -int no_warn;struct module_kobject *mk =NULL ;if (!drv)
drivers/base/module.c void module_add_driver(struct module *mod, struct device_driver *drv) · line 61
Quoted 5 lines
drivers/base/module.c +1
-1@@ -59,11 +58,11 @@ void module_add_driver(struct module *mod, struct device_driver *drv)return ;/* Don't check return codes; these calls are idempotent */ - no_warn =sysfs_create_link (&drv->p->kobj, &mk->kobj,"module" ); +sysfs_create_link (&drv->p->kobj, &mk->kobj,"module" );
Always test-build your patches before sending them out :(
kernel test robot
build botThank you for the patch! Perhaps something to improve:
Hi Zheng,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on driver-core/driver-core-testing] [also build test WARNING on v5.8-rc6 next-20200723]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Zheng-Yongjun/tipc-remove-set-but-not-used-variable-no_warn/20200721-164445 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git 6bdb486c5a628f7a927c2658166e3a5ef1f883e7 config: mips-randconfig-r004-20200724 (attached as .config) compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
All warnings (new ones prefixed by >>):
drivers/base/module.c: In function 'module_add_driver':
>> drivers/base/module.c:61:2: warning: ignoring return value of 'sysfs_create_link', declared with attribute warn_unused_result [-Wunused-result]
61 | sysfs_create_link(&drv->p->kobj, &mk->kobj, "module");
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/base/module.c:65:3: warning: ignoring return value of 'sysfs_create_link', declared with attribute warn_unused_result [-Wunused-result]
65 | sysfs_create_link(mk->drivers_dir, &drv->p->kobj,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
66 | driver_name);
| ~~~~~~~~~~~~vim +/sysfs_create_link +61 drivers/base/module.c
32
33 void module_add_driver(struct module *mod, struct device_driver *drv)
34 {
35 char *driver_name;
36 struct module_kobject *mk = NULL;
37
38 if (!drv)
39 return;
40
41 if (mod)
42 mk = &mod->mkobj;
43 else if (drv->mod_name) {
44 struct kobject *mkobj;
45
46 /* Lookup built-in module entry in /sys/modules */
47 mkobj = kset_find_obj(module_kset, drv->mod_name);
48 if (mkobj) {
49 mk = container_of(mkobj, struct module_kobject, kobj);
50 /* remember our module structure */
51 drv->p->mkobj = mk;
52 /* kset_find_obj took a reference */
53 kobject_put(mkobj);
54 }
55 }
56
57 if (!mk)
58 return;
59
60 /* Don't check return codes; these calls are idempotent */
> 61 sysfs_create_link(&drv->p->kobj, &mk->kobj, "module");
62 driver_name = make_driver_name(drv);
63 if (driver_name) {
64 module_create_drivers_dir(mk);
65 sysfs_create_link(mk->drivers_dir, &drv->p->kobj,
66 driver_name);
67 kfree(driver_name);
68 }
69 }
70 ---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org