Skip to contentSkip to conversation

xtensa: fix access check in csum_and_copy_from_user

PATCH In review Max Filippov 2 participants 3 messages Jul 21, 2020 – Jul 22, 2020 Tensilica Xtensa port (xtensa)

lore
Share & tools
lore

Max Filippov

author maintainer
#0 lore raw

PATCH 1/1 xtensa: fix access check in csum_and_copy_from_user

Commit d341659f470b ("xtensa: switch to providing csum_and_copy_from_user()") introduced access check, but incorrectly tested dst instead of src.
Fix access_ok argument in csum_and_copy_from_user.

Cc Al Viro <[email protected]>
Fixes d341659f470b ("xtensa: switch to providing csum_and_copy_from_user()")
---
 arch/xtensa/include/asm/checksum.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/xtensa/include/asm/checksum.h +1 -1
index d8292cc9ebdf..243a5fe79d3c 100644
@@ -57,7 +57,7 @@ static inline
 __wsum csum_and_copy_from_user(const void __user *src, void *dst,
 				   int len, __wsum sum, int *err_ptr)
 {
-	if (access_ok(dst, len))
+	if (access_ok(src, len))
 		return csum_partial_copy_generic((__force const void *)src, dst,
 					len, sum, err_ptr, NULL);
 	if (len)
Signature · 1 line
2.20.1
#1 lore raw
Quoted 4 lines · Max Filippov

Commit d341659f470b ("xtensa: switch to providing csum_and_copy_from_user()") introduced access check, but incorrectly tested dst instead of src.
Fix access_ok argument in csum_and_copy_from_user.

Applied, with apologies... Which tree do you want it to go through? I'm dropping it into vfs.git#fixes, will send to Linus unless you prefer it to go some other way...

author maintainer
#2 lore raw
Quoted 10 lines · Al Viro
Quoted 4 lines · Max Filippov

Commit d341659f470b ("xtensa: switch to providing csum_and_copy_from_user()") introduced access check, but incorrectly tested dst instead of src.
Fix access_ok argument in csum_and_copy_from_user.

Applied, with apologies... Which tree do you want it to go through? I'm dropping it into vfs.git#fixes, will send to Linus unless you prefer it to go some other way...

NP. Anything that will go into 5.8 is good.

Signature · 2 lines
Thanks.
-- Max