Skip to contentSkip to conversation

net: qed_hsi.h: Avoid the use of one-element array

PATCH Applied Gustavo A. R. Silva 3 participants 3 messages Jul 22, 2020 – Jul 23, 2020

Subsystems (3)
Networking Network drivers QLogic QL4xxx Ethernet driver
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 net: qed_hsi.h: Avoid the use of one-element array

One-element arrays are being deprecated[1]. Replace the one-element array with a simple value type '__le32 reserved1'[2], once it seems this is just a placeholder for alignment.

[1] https://github.com/KSPP/linux/issues/79
[2] https://github.com/KSPP/linux/issues/86

Tested-by kernel test robot <[email protected]>
Link https://github.com/GustavoARSilva/linux-hardening/blob/master/cii/0-day/qed_hsi-20200718.md
Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/net/ethernet/qlogic/qed/qed_hsi.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/qlogic/qed/qed_hsi.h +1 -1
index 1af3f65ab862..559df9f4d656 100644
@@ -361,7 +361,7 @@ struct core_tx_update_ramrod_data {
 	u8 update_qm_pq_id_flg;
 	u8 reserved0;
 	__le16 qm_pq_id;
-	__le32 reserved1[1];
+	__le32 reserved1;
 };
 
 /* Enum flag for what type of dcb data to update */
Signature · 1 line
2.27.0
maintainer Applied
#1 lore raw

From: "Gustavo A. R. Silva" <[email protected]>
Date: Wed, 22 Jul 2020 13:58:52 -0500

Quoted 10 lines

One-element arrays are being deprecated[1]. Replace the one-element array with a simple value type '__le32 reserved1'[2], once it seems this is just a placeholder for alignment.

[1] https://github.com/KSPP/linux/issues/79
[2] https://github.com/KSPP/linux/issues/86

Tested-by kernel test robot <[email protected]>
Link https://github.com/GustavoARSilva/linux-hardening/blob/master/cii/0-day/qed_hsi-20200718.md
Signed-off-by Gustavo A. R. Silva <[email protected]>

Applied.

#2 lore raw
Quoted 7 lines · David Miller

From: "Gustavo A. R. Silva" <[email protected]>
Date: Wed, 22 Jul 2020 13:58:52 -0500

Quoted 4 lines

One-element arrays are being deprecated[1]. Replace the one-element array with a simple value type '__le32 reserved1'[2], once it seems this is just a placeholder for alignment.

Quoted 9 lines
Quoted 6 lines

[1] https://github.com/KSPP/linux/issues/79
[2] https://github.com/KSPP/linux/issues/86

Tested-by kernel test robot <[email protected]>
Link https://github.com/GustavoARSilva/linux-hardening/blob/master/cii/0-day/qed_hsi-20200718.md
Signed-off-by Gustavo A. R. Silva <[email protected]>

Applied.

Thanks, Dave.

--
Gustavo