Skip to contentSkip to conversation

x86/configs: Remove CONFIG_CRYPTO_AES_586 from i386_defconfig

PATCH Applied Sedat Dilek 3 participants 4 messages Jul 23, 2020 – Jul 24, 2020 x86

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 x86/configs: Remove CONFIG_CRYPTO_AES_586 from i386_defconfig

Initially CONFIG_CRYPTO_AES_586=y was added to i386_defconfig file with commit c1b362e3b4d3 ("x86: update defconfigs").

The code and Kconfig for CONFIG_CRYPTO_AES_586 was removed in:

commit 1d2c3279311e4f03fcf164e1366f2fda9f4bfccf ("crypto: x86/aes - drop scalar assembler implementations")

Remove the Kconfig relict from i386_defconfig file.

Cc Ard Biesheuvel <[email protected]>
Cc Herbert Xu <[email protected]>

---
Changes v1 -> v2:
- Add CC to Ard and Herbert (see commit 1d2c3279311e)

 arch/x86/configs/i386_defconfig | 1 -
 1 file changed, 1 deletion(-)
arch/x86/configs/i386_defconfig +0 -1
index 550904591e94..3a2a89882350 100644
@@ -290,7 +290,6 @@ CONFIG_SECURITY_NETWORK=y
 CONFIG_SECURITY_SELINUX=y
 CONFIG_SECURITY_SELINUX_BOOTPARAM=y
 CONFIG_SECURITY_SELINUX_DISABLE=y
-CONFIG_CRYPTO_AES_586=y
 # CONFIG_CRYPTO_ANSI_CPRNG is not set
 CONFIG_EFI_STUB=y
 CONFIG_ACPI_BGRT=y
Signature · 1 line
2.28.0.rc2
Acked-by on v2 1/1
#1 lore raw
Quoted 9 lines · Sedat Dilek

Initially CONFIG_CRYPTO_AES_586=y was added to i386_defconfig file with commit c1b362e3b4d3 ("x86: update defconfigs").

The code and Kconfig for CONFIG_CRYPTO_AES_586 was removed in:

commit 1d2c3279311e4f03fcf164e1366f2fda9f4bfccf ("crypto: x86/aes - drop scalar assembler implementations")

Remove the Kconfig relict from i386_defconfig file.

relic

Quoted 4 lines
Cc Ard Biesheuvel <[email protected]>
Cc Herbert Xu <[email protected]>

Thanks.

Quoted 20 lines

---
Changes v1 -> v2:
- Add CC to Ard and Herbert (see commit 1d2c3279311e)

 arch/x86/configs/i386_defconfig | 1 -
 1 file changed, 1 deletion(-)
arch/x86/configs/i386_defconfig +0 -1
index 550904591e94..3a2a89882350 100644
@@ -290,7 +290,6 @@ CONFIG_SECURITY_NETWORK=y
 CONFIG_SECURITY_SELINUX=y
 CONFIG_SECURITY_SELINUX_BOOTPARAM=y
 CONFIG_SECURITY_SELINUX_DISABLE=y
-CONFIG_CRYPTO_AES_586=y
 # CONFIG_CRYPTO_ANSI_CPRNG is not set
 CONFIG_EFI_STUB=y
 CONFIG_ACPI_BGRT=y
Signature · 1 line
~Randy
#2 lore raw
Quoted 5 lines · Randy Dunlap
Quoted 3 lines · Sedat Dilek

Initially CONFIG_CRYPTO_AES_586=y was added to i386_defconfig file with commit c1b362e3b4d3 ("x86: update defconfigs").

Quoted 9 lines
Quoted 6 lines

The code and Kconfig for CONFIG_CRYPTO_AES_586 was removed in:

commit 1d2c3279311e4f03fcf164e1366f2fda9f4bfccf ("crypto: x86/aes - drop scalar assembler implementations")

Remove the Kconfig relict from i386_defconfig file.

relic

leftover :-)

https://dict.leo.org/englisch-deutsch/Relikt

Quoted 7 lines
Quoted 4 lines
Cc Ard Biesheuvel <[email protected]>
Cc Herbert Xu <[email protected]>

Thanks for the review.

- Sedat -

Quoted 26 lines

Thanks.

Quoted 13 lines

---
Changes v1 -> v2:
- Add CC to Ard and Herbert (see commit 1d2c3279311e)

 arch/x86/configs/i386_defconfig | 1 -
 1 file changed, 1 deletion(-)
arch/x86/configs/i386_defconfig +0 -0
index 550904591e94..3a2a89882350 100644

arch/x86/configs/i386_defconfig CONFIG_SECURITY_NETWORK=y · line 295

Quoted 7 lines
arch/x86/configs/i386_defconfig +0 -1
@@ -290,7 +290,6 @@ CONFIG_SECURITY_NETWORK=y
 CONFIG_SECURITY_SELINUX=y
 CONFIG_SECURITY_SELINUX_BOOTPARAM=y
 CONFIG_SECURITY_SELINUX_DISABLE=y
-CONFIG_CRYPTO_AES_586=y
 # CONFIG_CRYPTO_ANSI_CPRNG is not set
 CONFIG_EFI_STUB=y
 CONFIG_ACPI_BGRT=y

--
~Randy

merge bot Applied
#3 lore raw

[tip: x86/build] x86/defconfigs: Remove CONFIG_CRYPTO_AES_586 from i386_defconfig

In reply to Sedat Dilek
The following commit has been merged into the x86/build branch of tip:

The following commit has been merged into the x86/build branch of tip:

Commit-ID:     6526b12de07588253a52577f42ec99fc7ca26a1f
Gitweb:        https://git.kernel.org/tip/6526b12de07588253a52577f42ec99fc7ca26a1f
Author:        Sedat Dilek <[email protected]>
AuthorDate:    Thu, 23 Jul 2020 19:11:14 +02:00
Committer:     Ingo Molnar <[email protected]>
CommitterDate: Fri, 24 Jul 2020 14:55:55 +02:00

x86/defconfigs: Remove CONFIG_CRYPTO_AES_586 from i386_defconfig

Initially CONFIG_CRYPTO_AES_586=y was added to the i386_defconfig file in:

c1b362e3b4d3: ("x86: update defconfigs")

The code and Kconfig for CONFIG_CRYPTO_AES_586 was removed in:

1d2c3279311e: ("crypto: x86/aes - drop scalar assembler implementations")

Remove the leftover from the i386_defconfig file as well.

---
 arch/x86/configs/i386_defconfig | 1 -
 1 file changed, 1 deletion(-)
arch/x86/configs/i386_defconfig +0 -1
index 5509045..3a2a898 100644
@@ -290,7 +290,6 @@ CONFIG_SECURITY_NETWORK=y
 CONFIG_SECURITY_SELINUX=y
 CONFIG_SECURITY_SELINUX_BOOTPARAM=y
 CONFIG_SECURITY_SELINUX_DISABLE=y
-CONFIG_CRYPTO_AES_586=y
 # CONFIG_CRYPTO_ANSI_CPRNG is not set
 CONFIG_EFI_STUB=y
 CONFIG_ACPI_BGRT=y