Skip to contentSkip to conversation

ASoC: max98390: update dsm param bin max size

PATCH In review Steve Lee 2 participants 5 messages Jul 24, 2020 – Jul 28, 2020

Subsystems (2)
lore
Share & tools
lore

Steve Lee

author
#0 lore raw

PATCH 3/3 ASoC: max98390: update dsm param bin max size

MAX98390_DSM_PARAM_MAX_SIZE is changed to support extended register update.

---
 sound/soc/codecs/max98390.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/max98390.h +1 -1
index 5f444e7779b0..dff884f68e3e 100644
@@ -650,7 +650,7 @@
 
 /* DSM register offset */
 #define MAX98390_DSM_PAYLOAD_OFFSET 16
-#define MAX98390_DSM_PARAM_MAX_SIZE 770
+#define MAX98390_DSM_PARAM_MAX_SIZE 1024
 #define MAX98390_DSM_PARAM_MIN_SIZE 670
 
 struct max98390_priv {
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 2 lines · Steve Lee

MAX98390_DSM_PARAM_MAX_SIZE is changed to support extended register update.

I'm missing patches 1-2 and have no cover letter - what's the story with dependencies?

author
#2 lore raw
Quoted 13 lines

-----Original Message-----
From: Mark Brown <[email protected]>
Sent: Friday, July 24, 2020 7:51 PM
To: Steve Lee <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Ryan Lee <[email protected]>; [email protected]
Subject: Re: [PATCH 3/3] ASoC: max98390: update dsm param bin max size

Quoted 6 lines
Quoted 2 lines · Steve Lee

MAX98390_DSM_PARAM_MAX_SIZE is changed to support extended register
update.

I'm missing patches 1-2 and have no cover letter - what's the story with dependencies?

I will re-send patch ang please ignore this patch.
DSM init param is extended to cover more register so that DSM MAX PARAM SIZE value is changed. Thanks.!

maintainer
#3 lore raw
Quoted 5 lines · Steve Lee
Quoted 2 lines

I'm missing patches 1-2 and have no cover letter - what's the story with dependencies?

I will re-send patch ang please ignore this patch.
DSM init param is extended to cover more register so that DSM MAX PARAM SIZE value is changed.

I applied these on Friday having found the other two patches (you're not sending things as a thread so they get lost, for example if someone sends a big series at a similar time like what happened on Friday) so your new version won't apply, please resend whatever change you want to make as an incremental patch against current code.

Please do not submit new versions of already applied patches, please submit incremental updates to the existing code. Modifying existing commits creates problems for other users building on top of those commits so it's best practice to only change pubished git commits if absolutely essential.

author
#4 lore raw
Quoted 29 lines

-----Original Message-----
From: Mark Brown <[email protected]>
Sent: Monday, July 27, 2020 10:08 PM
To: Steve Lee <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Ryan Lee <[email protected]>; [email protected]
Subject: Re: [PATCH 3/3] ASoC: max98390: update dsm param bin max size

Quoted 5 lines · Steve Lee
Quoted 2 lines

I'm missing patches 1-2 and have no cover letter - what's the story with dependencies?

I will re-send patch ang please ignore this patch.
DSM init param is extended to cover more register so that DSM MAX PARAM

SIZE value is changed.

I applied these on Friday having found the other two patches (you're not sending things as a thread so they get lost, for example if someone sends a big series at a similar time like what happened on Friday) so your new version won't apply, please resend whatever change you want to make as an incremental patch against current code.

Quoted 4 lines

Please do not submit new versions of already applied patches, please submit incremental updates to the existing code. Modifying existing commits creates problems for other users building on top of those commits so it's best practice to only change pubished git commits if absolutely essential.

Thanks, I missed patched was already applied. I will send patch upon these patches later.