nvmet-fc: check successful reference in nvmet_fc_find_target_assoc
Subsystems (3)
PATCH 1/1 nvmet-fc: check successful reference in nvmet_fc_find_target_assoc
When searching for an association based on an association id, when there is a match, the code takes a reference. However, it is not validating that the reference taking was successful.
Check the status of the reference. If unsuccessful, the device is being deleted and should be ignored.
--- drivers/nvme/target/fc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/nvme/target/fc.c +2 -1
@@ -1243,7 +1243,8 @@ nvmet_fc_find_target_assoc(struct nvmet_fc_tgtport *tgtport,list_for_each_entry (assoc, &tgtport->assoc_list, a_list) {if (association_id == assoc->association_id) { ret = assoc; -nvmet_fc_tgt_a_get (assoc); +if (!nvmet_fc_tgt_a_get (assoc)) + ret =NULL ;break ; } }
Signature · 7 lines
2.26.2 _______________________________________________ Linux-nvme mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-nvme
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Christoph Hellwig
AppliedQuoted 8 lines · James Smart
When searching for an association based on an association id, when there is a match, the code takes a reference. However, it is not validating that the reference taking was successful.
Check the status of the reference. If unsuccessful, the device is being deleted and should be ignored.
Signed-off-by James Smart <[email protected]>
Applied to nvme-5.9, thanks.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme