Skip to contentSkip to conversation

crypto: sa2ul - Fix inconsistent IS_ERR and PTR_ERR

PATCH In review Gustavo A. R. Silva 3 participants 3 messages Jul 24, 2020 – Jul 31, 2020 Crypto API

lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 crypto: sa2ul - Fix inconsistent IS_ERR and PTR_ERR

Fix inconsistent IS_ERR and PTR_ERR in sa_dma_init(). The proper pointer to be passed as argument to PTR_ERR() is dd->dma_tx.

This bug was detected with the help of Coccinelle.

Fixes 7694b6ca649f ("crypto: sa2ul - Add crypto driver")
Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/crypto/sa2ul.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/crypto/sa2ul.c +1 -1
index ebcdffcdb686..5bc099052bd2 100644
@@ -2259,7 +2259,7 @@ static int sa_dma_init(struct sa_crypto_data *dd)
 
 	dd->dma_tx = dma_request_chan(dd->dev, "tx");
 	if (IS_ERR(dd->dma_tx)) {
-		if (PTR_ERR(dd->dma_rx1) != -EPROBE_DEFER)
+		if (PTR_ERR(dd->dma_tx) != -EPROBE_DEFER)
 			dev_err(dd->dev, "Unable to request tx DMA channel\n");
 		ret = PTR_ERR(dd->dma_tx);
 		goto err_dma_tx;
Signature · 1 line
2.27.0
maintainer
#1 lore raw
Quoted 10 lines · Gustavo A. R. Silva

Fix inconsistent IS_ERR and PTR_ERR in sa_dma_init(). The proper pointer to be passed as argument to PTR_ERR() is dd->dma_tx.

This bug was detected with the help of Coccinelle.

Fixes 7694b6ca649f ("crypto: sa2ul - Add crypto driver")
Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/crypto/sa2ul.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
#2 lore raw
Quoted 6 lines · Herbert Xu
Quoted 5 lines · Gustavo A. R. Silva

Fix inconsistent IS_ERR and PTR_ERR in sa_dma_init(). The proper pointer to be passed as argument to PTR_ERR() is dd->dma_tx.

This bug was detected with the help of Coccinelle.

Quoted 8 lines
Quoted 5 lines
Fixes 7694b6ca649f ("crypto: sa2ul - Add crypto driver")
Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/crypto/sa2ul.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied. Thanks.

Awesome. :)

Thanks
--
Gustavo