Skip to contentSkip to conversation

STAGING - REALTEK RTL8188EU DRIVERS: Fix Coding Style Error

PATCH In review Anant Thazhemadam 3 participants 4 messages Jul 25, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 STAGING - REALTEK RTL8188EU DRIVERS: Fix Coding Style Error

Running the checkpatch.pl script on the file for which patch was created, the following error was found to exist.
ERROR: space required after that ',' (ctx:VxV)

Fixed the above error which was found on line #721 by inserting a blank space at the appropriate position.

---
 drivers/staging/rtl8188eu/core/rtw_security.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8188eu/core/rtw_security.c +1 -1
index 21f6652dd69f..57e171d3e48d 100644
@@ -718,7 +718,7 @@ u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *precvframe)
 				res = _FAIL;
 			}
 		} else {
-			RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("%s: stainfo==NULL!!!\n",__func__));
+			RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("%s: stainfo==NULL!!!\n", __func__));
 			res = _FAIL;
 		}
 	}
Signature · 1 line
2.25.1
#1 lore raw
Quoted 17 lines · Anant Thazhemadam

Running the checkpatch.pl script on the file for which patch was created, the following error was found to exist.
ERROR: space required after that ',' (ctx:VxV)

Fixed the above error which was found on line #721 by inserting a blank space at the appropriate position.

---
  drivers/staging/rtl8188eu/core/rtw_security.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8188eu/core/rtw_security.c +0 -0
index 21f6652dd69f..57e171d3e48d 100644

drivers/staging/rtl8188eu/core/rtw_security.c u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *precvframe) · line 724

Quoted 8 lines
drivers/staging/rtl8188eu/core/rtw_security.c +1 -1
@@ -718,7 +718,7 @@ u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *precvframe)
  				res = _FAIL;
  			}
  		} else {
-			RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("%s: stainfo==NULL!!!\n",__func__));
+			RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("%s: stainfo==NULL!!!\n", __func__));
  			res = _FAIL;
  		}
  	}

In fixing one checkpatch.pl condition, you introduced another - the resulting line is too long. You should fix only one such condition, but you should fix any others that are introduced. You do need to document it.

Patch subjects for this driver should be written as "staging: rtl8188eu: .....".

Larry

#2 lore raw
Quoted 7 lines · Larry Finger
Quoted 6 lines · Anant Thazhemadam

Running the checkpatch.pl script on the file for which patch was created, the following error was found to exist.
ERROR: space required after that ',' (ctx:VxV)

Fixed the above error which was found on line #721 by inserting a blank space at the appropriate position.

[]

Quoted 1 line

drivers/staging/rtl8188eu/core/rtw_security.c

Quoted 1 line
drivers/staging/rtl8188eu/core/rtw_security.c +0 -0

[]

Quoted 5 lines
Quoted 5 lines
drivers/staging/rtl8188eu/core/rtw_security.c +0 -1
@@ -718,7 +718,7 @@ u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *precvframe)
  				res = _FAIL;
  			}
  		} else {
-			RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("%s: stainfo==NULL!!!\n",__func__));
Quoted 8 lines

drivers/staging/rtl8188eu/core/rtw_security.c u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *precvframe) · line 724

Quoted 4 lines
drivers/staging/rtl8188eu/core/rtw_security.c +1 -0
+			RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("%s: stainfo==NULL!!!\n", __func__));
  			res = _FAIL;
  		}
  	}

In fixing one checkpatch.pl condition, you introduced another - the resulting line is too long. You should fix only one such condition, but you should fix any others that are introduced. You do need to document it.

I think that doesn't matter as it was also too long before this change.

Quoted 1 line

Patch subjects for this driver should be written as "staging: rtl8188eu: .....".

How likely is it that this driver would ever be
moved to drivers/net/wireless/realtek/rtlwifi?

#3 lore raw
Quoted 25 lines · Joe Perches
Quoted 7 lines · Larry Finger
Quoted 6 lines · Anant Thazhemadam

Running the checkpatch.pl script on the file for which patch was created, the following error was found to exist.
ERROR: space required after that ',' (ctx:VxV)

Fixed the above error which was found on line #721 by inserting a blank space at the appropriate position.

[]

Quoted 1 line

drivers/staging/rtl8188eu/core/rtw_security.c

Quoted 1 line
drivers/staging/rtl8188eu/core/rtw_security.c +0 -0

[]

Quoted 5 lines
Quoted 5 lines
drivers/staging/rtl8188eu/core/rtw_security.c +0 -1
@@ -718,7 +718,7 @@ u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *precvframe)
   				res = _FAIL;
   			}
   		} else {
-			RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("%s: stainfo==NULL!!!\n",__func__));
Quoted 8 lines

drivers/staging/rtl8188eu/core/rtw_security.c u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *precvframe) · line 724

Quoted 4 lines
drivers/staging/rtl8188eu/core/rtw_security.c +1 -0
+			RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("%s: stainfo==NULL!!!\n", __func__));
   			res = _FAIL;
   		}
   	}

In fixing one checkpatch.pl condition, you introduced another - the resulting line is too long. You should fix only one such condition, but you should fix any others that are introduced. You do need to document it.

Quoted 7 lines

I think that doesn't matter as it was also too long before this change.

Quoted 1 line

Patch subjects for this driver should be written as "staging: rtl8188eu: .....".

How likely is it that this driver would ever be
moved to drivers/net/wireless/realtek/rtlwifi?

Very unlikely. It I wanted to undertake that kind of effort, I would switch to one of the later versions from Realtek that uses nl80211/cfg80211. Despite that, it is likely that only the USB driver from rtlwifi could be used.

Larry