Skip to contentSkip to conversation

libpeas: this depends on gtk3+ add FEATURE CHECK

PATCH In review akuster 2 participants 4 messages Jul 26, 2020 – Jul 27, 2020

lore
Share & tools
lore

akuster

author
#0 lore raw

PATCH 1/2 libpeas: this depends on gtk3+ add FEATURE CHECK

This has a dependancy on GTK3DISTROFEATURES so add the check

ERROR: Nothing PROVIDES 'gtk+3' (but /.../meta-openembedded/meta-oe/recipes-gnome/libpeas/libpeas_1.25.3.bb, /.../poky/meta/recipes-gnome/gnome/adwaita-icon-theme_3.36.1.bb DEPENDS on or otherwise requires it) gtk+3 was skipped: one of 'wayland x11' needs to be in DISTRO_FEATURES

---
 meta-oe/recipes-gnome/libpeas/libpeas_1.25.3.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
meta-oe/recipes-gnome/libpeas/libpeas_1.25.3.bb +3 -1
index 57419a4275..78314007e3 100644
@@ -8,7 +8,9 @@ DEPENDS = "gtk+3"
 GNOMEBASEBUILDCLASS = "meson"
 GTKDOC_MESON_OPTION = "gtk_doc"
 
-inherit gnomebase gobject-introspection gtk-doc gtk-icon-cache
+inherit gnomebase gobject-introspection gtk-doc gtk-icon-cache features_check
+
+ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}"
 
 SRC_URI[archive.md5sum] = "08bfff8f9688cf630dcb0f950617661f"
 SRC_URI[archive.sha256sum] = "1c9bbb29740c29cd6e1dd0c9964722ff08cd5e6f68f1b5c135bc391a6ce97639"
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH 2/2 khronos: includes virtual/libgles2 , needs opengl

add FEATURE_CHECK on opengl.

---
 meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc +3 -1
index bd75cdb1f4..1cd0a476aa 100644
@@ -16,7 +16,9 @@ SRCREV_FORMAT = "vk-gl-cts"
 
 S = "${WORKDIR}/git"
 
-inherit pkgconfig cmake
+inherit pkgconfig cmake features_check
+
+REQUIRED_DISTRO_FEATURES = "opengl"
 
 DEPENDS += "libpng zlib virtual/libgles2 virtual/egl"
 
Signature · 1 line
2.17.1
#2 lore raw

Re: [oe] [PATCH 2/2] khronos: includes virtual/libgles2 , needs opengl

Hi,

I've already sent this one:
https://lists.openembedded.org/g/openembedded-devel/message/85932

Quoted 28 lines · akuster

add FEATURE_CHECK on opengl.

---
 meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc +3 -2
index bd75cdb1f4..1cd0a476aa 100644
@@ -16,7 +16,9 @@ SRCREV_FORMAT = "vk-gl-cts"
 
 S = "${WORKDIR}/git"
 
-inherit pkgconfig cmake
+inherit pkgconfig cmake features_check
+
+REQUIRED_DISTRO_FEATURES = "opengl"
 
 DEPENDS += "libpng zlib virtual/libgles2 virtual/egl"
 
--

2.17.1

author
#3 lore raw

Re: [oe] [PATCH 2/2] khronos: includes virtual/libgles2 , needs opengl

Quoted 4 lines · Martin Jansa

Hi,

I've already sent this one:
https://lists.openembedded.org/g/openembedded-devel/message/85932

Cool. it was faster to fix it than look search the mailing list for a fix.

it ended up being a ping in the end

looks like its in the testing queue.

- armin

Quoted 33 lines

On Sun, Jul 26, 2020 at 11:22 AM akuster <[email protected] <mailto:[email protected]>> wrote:

    add FEATURE_CHECK on opengl.

    Signed-off-by: Armin Kuster <[email protected]
    <mailto:[email protected]>>
    ---
     meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc | 4 +++-
     1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc
    b/meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc
    index bd75cdb1f4..1cd0a476aa 100644
    --- a/meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc
    +++ b/meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc
    @@ -16,7 +16,9 @@ SRCREV_FORMAT = "vk-gl-cts"

     S = "${WORKDIR}/git"

    -inherit pkgconfig cmake
    +inherit pkgconfig cmake features_check
    +
    +REQUIRED_DISTRO_FEATURES = "opengl"

     DEPENDS += "libpng zlib virtual/libgles2 virtual/egl"

    -- 
    2.17.1