Skip to contentSkip to conversation

soundwire: master: enable pm runtime

PATCH Applied Bard Liao 2 participants 2 messages Jul 27, 2020 – Aug 17, 2020 SoundWire

lore
Share & tools
lore

Bard Liao

author maintainer
#0 lore raw

PATCH v2 1/1 soundwire: master: enable pm runtime

The hierarchy of soundwire devices is platform device -> M device -> S device. A S device is physically attached on the platform device. So the platform device should be resumed when a S device is resumed. As the bridge of platform device and S device, we have to implement runtime pm on M driver. We have set runtime pm ops in M driver already, but still need to enable runtime pm.

---

Changes in v2:
- Edit the commit message to explain why we need the patch.

---
 drivers/soundwire/master.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/soundwire/master.c +2 -0
index 5f0b2189defe..3488bb824e84 100644
@@ -154,6 +154,7 @@ int sdw_master_device_add(struct sdw_bus *bus, struct device *parent,
 	bus->dev = &md->dev;
 	bus->md = md;
 
+	pm_runtime_enable(&bus->md->dev);
 device_register_err:
 	return ret;
 }
@@ -166,6 +167,7 @@ int sdw_master_device_add(struct sdw_bus *bus, struct device *parent,
  */
 int sdw_master_device_del(struct sdw_bus *bus)
 {
+	pm_runtime_disable(&bus->md->dev);
 	device_unregister(bus->dev);
 
 	return 0;
Signature · 1 line
2.17.1
maintainer Applied
#1 lore raw
Quoted 6 lines · Bard Liao

The hierarchy of soundwire devices is platform device -> M device -> S device. A S device is physically attached on the platform device. So the platform device should be resumed when a S device is resumed. As the bridge of platform device and S device, we have to implement runtime pm on M driver. We have set runtime pm ops in M driver already, but still need to enable runtime pm.

Applied, thanks

Signature · 1 line
~Vinod