iommu: amd: Fix kerneldoc
Subsystems (4)
PATCH 1/3 iommu: amd: Fix kerneldoc
Fix W=1 compile warnings (invalid kerneldoc):
drivers/iommu/amd/init.c:1586: warning: Function parameter or member 'ivrs' not described in 'get_highest_supported_ivhd_type' drivers/iommu/amd/init.c:1938: warning: Function parameter or member 'iommu' not described in 'iommu_update_intcapxt'
--- drivers/iommu/amd/init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iommu/amd/init.c +2 -2
@@ -1578,7 +1578,7 @@ static int __init init_iommu_one(struct amd_iommu *iommu, struct ivhd_header *h)/** * get_highest_supported_ivhd_type - Look up the appropriate IVHD type -* @ivrs Pointer to the IVRS header +* @ivrs: Pointer to the IVRS header * * This function search through all IVDB of the maximum supported IVHD */
@@ -1929,7 +1929,7 @@ static int iommu_setup_msi(struct amd_iommu *iommu)#define XT_INT_VEC (x) (((x) & 0xFFULL) << 32)#define XT_INT_DEST_HI (x) ((((x) >> 24) & 0xFFULL) << 56) -/** +/* * Setup the IntCapXT registers with interrupt routing information * based on the PCI MSI capability block registers, accessed via * MMIO MSI address low/hi and MSI data registers.
Signature · 1 line
2.17.1
PATCH 2/3 iommu: intel: Drop kerneldoc marker from regular comment
Fix W=1 compile warnings (invalid kerneldoc):
drivers/iommu/intel/dmar.c:389: warning: Function parameter or member 'header' not described in 'dmar_parse_one_drhd'
--- drivers/iommu/intel/dmar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/intel/dmar.c +1 -1
@@ -380,7 +380,7 @@ dmar_find_dmaru(struct acpi_dmar_hardware_unit *drhd)return NULL ; } -/** +/* * dmar_parse_one_drhd - parses exactly one DMA remapping hardware definition * structure which uniquely represent one DMA remapping hardware unit * present in the platform
Signature · 1 line
2.17.1
Re: [PATCH 2/3] iommu: intel: Drop kerneldoc marker from regular comment
Quoted 4 lines · Krzysztof Kozlowski
Fix W=1 compile warnings (invalid kerneldoc):
drivers/iommu/intel/dmar.c:389: warning: Function parameter or member 'header' not described in 'dmar_parse_one_drhd'
Quoted 21 lines
Signed-off-by Krzysztof Kozlowski <[email protected]>--- drivers/iommu/intel/dmar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/iommu/intel/dmar.c +1
-1@@ -380,7 +380,7 @@ dmar_find_dmaru(struct acpi_dmar_hardware_unit *drhd)return NULL ; } -/** +/* * dmar_parse_one_drhd - parses exactly one DMA remapping hardware definition * structure which uniquely represent one DMA remapping hardware unit * present in the platform Signature · 1 line
2.17.1
PATCH 3/3 iommu: qcom: Drop of_match_ptr to fix -Wunused-const-variable
In reply to Krzysztof KozlowskiThe of_device_id is included unconditionally by of.h header and used in the driver as well. Remove of_match_ptr to fix W=1 compile test warning with !CONFIG_OF:
drivers/iommu/qcom_iommu.c:910:34: warning: 'qcom_iommu_of_match' defined but not used [-Wunused-const-variable=]
910 | static const struct of_device_id qcom_iommu_of_match[] = {
--- drivers/iommu/qcom_iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iommu/qcom_iommu.c +2 -2
@@ -752,7 +752,7 @@ static const struct of_device_id ctx_of_match[] = {static struct platform_driver qcom_iommu_ctx_driver = { .driver = { .name ="qcom-iommu-ctx" , - .of_match_table =of_match_ptr (ctx_of_match), + .of_match_table = ctx_of_match, }, .probe = qcom_iommu_ctx_probe, .remove = qcom_iommu_ctx_remove,
@@ -915,7 +915,7 @@ static const struct of_device_id qcom_iommu_of_match[] = {static struct platform_driver qcom_iommu_driver = { .driver = { .name ="qcom-iommu" , - .of_match_table =of_match_ptr (qcom_iommu_of_match), + .of_match_table = qcom_iommu_of_match, .pm = &qcom_iommu_pm_ops, }, .probe = qcom_iommu_device_probe,
Signature · 6 lines
2.17.1 _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 3/3] iommu: qcom: Drop of_match_ptr to fix -Wunused-const-variable
Quoted 7 lines · Krzysztof Kozlowski
The
of_device_idis included unconditionally byof.hheader and used in the driver as well. Removeof_match_ptrto fix W=1 compile test warning with !CONFIG_OF:
drivers/iommu/qcom_iommu.c:910:34: warning: 'qcom_iommu_of_match' defined but not used [-Wunused-const-variable=]
910 | static const structof_device_idqcom_iommu_of_match[] = {
Quoted 30 lines
Signed-off-by Krzysztof Kozlowski <[email protected]>--- drivers/iommu/qcom_iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/iommu/qcom_iommu.c +2
-2@@ -752,7 +752,7 @@ static const struct of_device_id ctx_of_match[] = {static struct platform_driver qcom_iommu_ctx_driver = { .driver = { .name ="qcom-iommu-ctx" , - .of_match_table =of_match_ptr (ctx_of_match), + .of_match_table = ctx_of_match, }, .probe = qcom_iommu_ctx_probe, .remove = qcom_iommu_ctx_remove,@@ -915,7 +915,7 @@ static const struct of_device_id qcom_iommu_of_match[] = {static struct platform_driver qcom_iommu_driver = { .driver = { .name ="qcom-iommu" , - .of_match_table =of_match_ptr (qcom_iommu_of_match), + .of_match_table = qcom_iommu_of_match, .pm = &qcom_iommu_pm_ops, }, .probe = qcom_iommu_device_probe,Signature · 1 line
2.17.1
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Quoted 9 lines · Krzysztof Kozlowski
Fix W=1 compile warnings (invalid kerneldoc):
drivers/iommu/amd/init.c:1586: warning: Function parameter or member 'ivrs' not described in 'get_highest_supported_ivhd_type'drivers/iommu/amd/init.c:1938: warning: Function parameter or member 'iommu' not described in 'iommu_update_intcapxt'Signed-off-by Krzysztof Kozlowski <[email protected]>--- drivers/iommu/amd/init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Applied all 3, thanks.
Quoted 5 lines · Krzysztof Kozlowski
Fix W=1 compile warnings (invalid kerneldoc):
drivers/iommu/amd/init.c:1586: warning: Function parameter or member 'ivrs' not described in 'get_highest_supported_ivhd_type'drivers/iommu/amd/init.c:1938: warning: Function parameter or member 'iommu' not described in 'iommu_update_intcapxt'
Quoted 30 lines
Signed-off-by Krzysztof Kozlowski <[email protected]>--- drivers/iommu/amd/init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/iommu/amd/init.c +2
-2@@ -1578,7 +1578,7 @@ static int __init init_iommu_one(struct amd_iommu *iommu, struct ivhd_header *h)/** * get_highest_supported_ivhd_type - Look up the appropriate IVHD type -* @ivrs Pointer to the IVRS header +* @ivrs: Pointer to the IVRS header * * This function search through all IVDB of the maximum supported IVHD */ @@ -1929,7 +1929,7 @@ static int iommu_setup_msi(struct amd_iommu *iommu)#define XT_INT_VEC (x) (((x) & 0xFFULL) << 32)#define XT_INT_DEST_HI (x) ((((x) >> 24) & 0xFFULL) << 56) -/** +/* * Setup the IntCapXT registers with interrupt routing information * based on the PCI MSI capability block registers, accessed via * MMIO MSI address low/hi and MSI data registers. Signature · 1 line
2.17.1
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu