Skip to contentSkip to conversation

power: supply: cpcap-battery: Fix kerneldoc of cpcap_battery_read_accumulated()

PATCH In review Krzysztof Kozlowski 2 participants 4 messages Jul 29, 2020 Power supply

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 power: supply: cpcap-battery: Fix kerneldoc of cpcap_battery_read_accumulated()

Fix W=1 compile warnings (invalid kerneldoc):

drivers/power/supply/cpcap-battery.c:292: warning: Function parameter or member 'ccd' not described in 'cpcap_battery_read_accumulated' drivers/power/supply/cpcap-battery.c:292: warning: Excess function parameter 'regs' description in 'cpcap_battery_read_accumulated'

---
 drivers/power/supply/cpcap-battery.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/power/supply/cpcap-battery.c +1 -1
index 6e9392901b0a..90eba364664b 100644
@@ -274,7 +274,7 @@ static int cpcap_battery_cc_to_ua(struct cpcap_battery_ddata *ddata,
 /**
  * cpcap_battery_read_accumulated - reads cpcap coulomb counter
  * @ddata: device driver data
- * @regs: coulomb counter values
+ * @ccd: coulomb counter values
  *
  * Based on Motorola mapphone kernel function data_read_regs().
  * Looking at the registers, the coulomb counter seems similar to
Signature · 1 line
2.17.1
#1 lore raw

PATCH 2/2 power: supply: Fix kerneldoc of power_supply_temp2resist_simple()

Fix W=1 compile warnings (invalid kerneldoc):

drivers/power/supply/power_supply_core.c:747: warning: Function parameter or member 'temp' not described in 'power_supply_temp2resist_simple' drivers/power/supply/power_supply_core.c:747: warning: Excess function parameter 'ocv' description in 'power_supply_temp2resist_simple'

---
 drivers/power/supply/power_supply_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/power/supply/power_supply_core.c +1 -1
index 90e56736d479..ccbad435ed12 100644
@@ -733,7 +733,7 @@ EXPORT_SYMBOL_GPL(power_supply_put_battery_info);
  * percent
  * @table: Pointer to battery resistance temperature table
  * @table_len: The table length
- * @ocv: Current temperature
+ * @temp: Current temperature
  *
  * This helper function is used to look up battery internal resistance percent
  * according to current temperature value from the resistance temperature table,
Signature · 1 line
2.17.1
#3 lore raw
In reply to Krzysztof Kozlowski

Hi,

Quoted 7 lines · Krzysztof Kozlowski

Fix W=1 compile warnings (invalid kerneldoc):

drivers/power/supply/cpcap-battery.c:292: warning: Function parameter or member 'ccd' not described in 'cpcap_battery_read_accumulated' drivers/power/supply/cpcap-battery.c:292: warning: Excess function parameter 'regs' description in 'cpcap_battery_read_accumulated'

---

Thanks, merged.

-- Sebastian

Quoted 19 lines
 drivers/power/supply/cpcap-battery.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/power/supply/cpcap-battery.c +1 -1
index 6e9392901b0a..90eba364664b 100644
@@ -274,7 +274,7 @@ static int cpcap_battery_cc_to_ua(struct cpcap_battery_ddata *ddata,
 /**
  * cpcap_battery_read_accumulated - reads cpcap coulomb counter
  * @ddata: device driver data
- * @regs: coulomb counter values
+ * @ccd: coulomb counter values
  *
  * Based on Motorola mapphone kernel function data_read_regs().
  * Looking at the registers, the coulomb counter seems similar to
Signature · 1 line
2.17.1
#2 lore raw

Re: [PATCH 2/2] power: supply: Fix kerneldoc of power_supply_temp2resist_simple()

In reply to Krzysztof Kozlowski

Hi,

Quoted 7 lines · Krzysztof Kozlowski

Fix W=1 compile warnings (invalid kerneldoc):

drivers/power/supply/power_supply_core.c:747: warning: Function parameter or member 'temp' not described in 'power_supply_temp2resist_simple' drivers/power/supply/power_supply_core.c:747: warning: Excess function parameter 'ocv' description in 'power_supply_temp2resist_simple'

---

Thanks, merged.

-- Sebastian

Quoted 19 lines
 drivers/power/supply/power_supply_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/power/supply/power_supply_core.c +1 -1
index 90e56736d479..ccbad435ed12 100644
@@ -733,7 +733,7 @@ EXPORT_SYMBOL_GPL(power_supply_put_battery_info);
  * percent
  * @table: Pointer to battery resistance temperature table
  * @table_len: The table length
- * @ocv: Current temperature
+ * @temp: Current temperature
  *
  * This helper function is used to look up battery internal resistance percent
  * according to current temperature value from the resistance temperature table,
Signature · 1 line
2.17.1