Skip to contentSkip to conversation

ltp: remove OOM tests from runtest/mm

PATCH Superseded Matthew 3 participants 9 messages Jul 29, 2020 – Aug 5, 2020

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Matthew

author
#0 lore raw

PATCH v2 1/1 ltp: remove OOM tests from runtest/mm

Fixes [YOCTO #13802]

Remove the OOM tests, since they might cause oeqa ssh connection lost.

---
 ...001-Remove-OOM-tests-from-runtest-mm.patch | 33 +++++++++++++++++++
 meta/recipes-extended/ltp/ltp_20200515.bb     |  1 +
 2 files changed, 34 insertions(+)
 create mode 100644 meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from-runtest-mm.patch
meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from-runtest-mm.patch new file +33 -0
new file mode 100644
index 0000000000..2d8262be78
@@ -0,0 +1,33 @@
+From 373b21dcf7a2879c27cc3dbeac5d83f5d45d22ae Mon Sep 17 00:00:00 2001
+From: "Mingde (Matthew) Zeng" <[email protected]>
+Date: Wed, 29 Jul 2020 08:47:09 -0400
+Subject: [PATCH] Remove OOM tests from runtest/mm
+
+Disable OOM tests, as they might cause oeqa ssh connection lost
+
+Upstream-Status: Inappropriate [oe-core specific]
+Signed-off-by: Mingde (Matthew) Zeng <[email protected]>
+---
+ runtest/mm | 6 ------
+ 1 file changed, 6 deletions(-)
+
+diff --git a/runtest/mm b/runtest/mm
+index 4701a14bd..2f9888ec6 100644
+--- a/runtest/mm
++++ b/runtest/mm
+@@ -75,12 +75,6 @@ ksm06_2 ksm06 -n 10000
+
+ cpuset01 cpuset01
+
+-oom01 oom01
+-oom02 oom02
+-oom03 oom03
+-oom04 oom04
+-oom05 oom05
+-
+ swapping01 swapping01 -i 5
+
+ thp01 thp01 -I 120
+--
+2.27.0
+
meta/recipes-extended/ltp/ltp_20200515.bb +1 -0
index ece3acf0f9..0c7044d044 100644
@@ -37,6 +37,7 @@ SRC_URI = "git://github.com/linux-test-project/ltp.git \
            file://0001-ptrace01-Fix-missing-format-string.patch \
            file://0001-sigwaitinfo-Do-not-run-invalid-undefined-test-cases.patch \
            file://0001-syscalls-copy_file_range02-Expect-EFBIG-in-subcase-m.patch \
+           file://0001-Remove-OOM-tests-from-runtest-mm.patch \
            "
 
 S = "${WORKDIR}/git"

--
2.27.0

#1 lore raw
Quoted 1 line · Matthew

Fixes [YOCTO #13802]

Thanks, we can reference the bug but I don't think we can yet claim it fixes it.

The missing log issue happened again:
https://autobuilder.yoctoproject.org/typhoon/#/builders/96/builds/908
so I think there are multiple issues at play here.

Is there any way to have the logging logged to disk straight away rather than stuck internally in oeqa's logging buffers? That way we could see which tests had run before a hang?

Also, could we make the scp failure non-fatal, maybe a warning so that when it fails we can look at the rest of the logs?

Cheers,

Richard

Quoted 74 lines

Remove the OOM tests, since they might cause oeqa ssh connection lost.

---
 ...001-Remove-OOM-tests-from-runtest-mm.patch | 33
+++++++++++++++++++
 meta/recipes-extended/ltp/ltp_20200515.bb     |  1 +
 2 files changed, 34 insertions(+)
 create mode 100644 meta/recipes-extended/ltp/ltp/0001-Remove-OOM-

tests-from-runtest-mm.patch

(quoted diff) +0 -0

from-runtest-mm.patch b/meta/recipes-extended/ltp/ltp/0001-Remove- OOM-tests-from-runtest-mm.patch
new file mode 100644
index 0000000000..2d8262be78

meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from- new file +0 -0

runtest-mm.patch

meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from- new file +1 -0
@@ -0,0 +1,33 @@
+From 373b21dcf7a2879c27cc3dbeac5d83f5d45d22ae Mon Sep 17 00:00:00

2001

meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from- new file +32 -0
+From: "Mingde (Matthew) Zeng" <[email protected]>
+Date: Wed, 29 Jul 2020 08:47:09 -0400
+Subject: [PATCH] Remove OOM tests from runtest/mm
+
+Disable OOM tests, as they might cause oeqa ssh connection lost
+
+Upstream-Status: Inappropriate [oe-core specific]
+Signed-off-by: Mingde (Matthew) Zeng <[email protected]>
+---
+ runtest/mm | 6 ------
+ 1 file changed, 6 deletions(-)
+
+diff --git a/runtest/mm b/runtest/mm
+index 4701a14bd..2f9888ec6 100644
+--- a/runtest/mm
++++ b/runtest/mm
+@@ -75,12 +75,6 @@ ksm06_2 ksm06 -n 10000
+
+ cpuset01 cpuset01
+
+-oom01 oom01
+-oom02 oom02
+-oom03 oom03
+-oom04 oom04
+-oom05 oom05
+-
+ swapping01 swapping01 -i 5
+
+ thp01 thp01 -I 120
+--
+2.27.0
+
meta/recipes-extended/ltp/ltp_20200515.bb +1 -0
index ece3acf0f9..0c7044d044 100644
@@ -37,6 +37,7 @@ SRC_URI = "git://github.com/linux-test-
 project/ltp.git \
            file://0001-ptrace01-Fix-missing-format-string.patch \
            file://0001-sigwaitinfo-Do-not-run-invalid-undefined-
 test-cases.patch \
            file://0001-syscalls-copy_file_range02-Expect-EFBIG-in-
 subcase-m.patch \
+           file://0001-Remove-OOM-tests-from-runtest-mm.patch \
            "

S = "${WORKDIR}/git"
--
2.27.0

author
#2 lore raw
Quoted 5 lines · Richard Purdie
Quoted 1 line · Matthew

Fixes [YOCTO #13802]

Thanks, we can reference the bug but I don't think we can yet claim it fixes it.

Sure, would something like the following work?

Reference [YOCTO #13802]

Quoted 4 lines

The missing log issue happened again:
https://autobuilder.yoctoproject.org/typhoon/#/builders/96/builds/908
so I think there are multiple issues at play here.

Can you attach this build's log.do_testimage so I can have a further look?

Quoted 7 lines

Is there any way to have the logging logged to disk straight away rather than stuck internally in oeqa's logging buffers? That way we could see which tests had run before a hang?

Also, could we make the scp failure non-fatal, maybe a warning so that when it fails we can look at the rest of the logs?

I'll further investigate this idea.

Matthew

Quoted 75 lines

Cheers,

Richard

Quoted 70 lines

Remove the OOM tests, since they might cause oeqa ssh connection lost.

---
 ...001-Remove-OOM-tests-from-runtest-mm.patch | 33
+++++++++++++++++++
 meta/recipes-extended/ltp/ltp_20200515.bb     |  1 +
 2 files changed, 34 insertions(+)
 create mode 100644 meta/recipes-extended/ltp/ltp/0001-Remove-OOM-

tests-from-runtest-mm.patch

(quoted diff) +0 -0

from-runtest-mm.patch b/meta/recipes-extended/ltp/ltp/0001-Remove- OOM-tests-from-runtest-mm.patch
new file mode 100644
index 0000000000..2d8262be78

meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from- new file +0 -0

runtest-mm.patch

meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from- new file +1 -0
@@ -0,0 +1,33 @@
+From 373b21dcf7a2879c27cc3dbeac5d83f5d45d22ae Mon Sep 17 00:00:00

2001

meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from- new file +32 -0
+From: "Mingde (Matthew) Zeng" <[email protected]>
+Date: Wed, 29 Jul 2020 08:47:09 -0400
+Subject: [PATCH] Remove OOM tests from runtest/mm
+
+Disable OOM tests, as they might cause oeqa ssh connection lost
+
+Upstream-Status: Inappropriate [oe-core specific]
+Signed-off-by: Mingde (Matthew) Zeng <[email protected]>
+---
+ runtest/mm | 6 ------
+ 1 file changed, 6 deletions(-)
+
+diff --git a/runtest/mm b/runtest/mm
+index 4701a14bd..2f9888ec6 100644
+--- a/runtest/mm
++++ b/runtest/mm
+@@ -75,12 +75,6 @@ ksm06_2 ksm06 -n 10000
+
+ cpuset01 cpuset01
+
+-oom01 oom01
+-oom02 oom02
+-oom03 oom03
+-oom04 oom04
+-oom05 oom05
+-
+ swapping01 swapping01 -i 5
+
+ thp01 thp01 -I 120
+--
+2.27.0
+
meta/recipes-extended/ltp/ltp_20200515.bb +1 -0
index ece3acf0f9..0c7044d044 100644
@@ -37,6 +37,7 @@ SRC_URI = "git://github.com/linux-test-
 project/ltp.git \
            file://0001-ptrace01-Fix-missing-format-string.patch \
            file://0001-sigwaitinfo-Do-not-run-invalid-undefined-
 test-cases.patch \
            file://0001-syscalls-copy_file_range02-Expect-EFBIG-in-
 subcase-m.patch \
+           file://0001-Remove-OOM-tests-from-runtest-mm.patch \
            "
Quoted 4 lines
Quoted 4 lines

S = "${WORKDIR}/git"
--
2.27.0

--
Mingde (Matthew) Zeng

#3 lore raw
Quoted 5 lines · Mingde (Matthew) Zeng
Quoted 3 lines · Richard Purdie
Quoted 1 line · Matthew

Fixes [YOCTO #13802]

Quoted 7 lines
Quoted 3 lines

Thanks, we can reference the bug but I don't think we can yet claim it
fixes it.

Sure, would something like the following work?

Reference [YOCTO #13802]

Simply "[YOCTO #13802]" is fine (I'll tweak the commit message as I merge).

Quoted 6 lines
Quoted 3 lines

The missing log issue happened again:
https://autobuilder.yoctoproject.org/typhoon/#/builders/96/builds/908
so I think there are multiple issues at play here.

Can you attach this build's log.do_testimage so I can have a further look?

Sorry, that build directory has been reused in this case :( Next time that happens I'll try and spot/grab it.

Quoted 9 lines
Quoted 7 lines

Is there any way to have the logging logged to disk straight away rather than stuck internally in oeqa's logging buffers? That way we could see which tests had run before a hang?

Also, could we make the scp failure non-fatal, maybe a warning so that
when it fails we can look at the rest of the logs?

I'll further investigate this idea.

Thanks!

Cheers,

Richard

#4 lore raw

on master-next I am also seeing

step1b: WARNING: ltp-20200515-r0 do_patch: QA Issue: Patch log indicates that patches do not apply cleanly. [patch-fuzz]

I wonder if its related to this as well.

Quoted 45 lines · Richard Purdie
Quoted 5 lines · Mingde (Matthew) Zeng
Quoted 3 lines · Richard Purdie
Quoted 1 line · Matthew

Fixes [YOCTO #13802]

Quoted 7 lines
Quoted 3 lines

Thanks, we can reference the bug but I don't think we can yet claim it
fixes it.

Sure, would something like the following work?

Reference [YOCTO #13802]

Simply "[YOCTO #13802]" is fine (I'll tweak the commit message as I merge).

Quoted 6 lines
Quoted 3 lines

The missing log issue happened again:
https://autobuilder.yoctoproject.org/typhoon/#/builders/96/builds/908
so I think there are multiple issues at play here.

Can you attach this build's log.do_testimage so I can have a further look?

Sorry, that build directory has been reused in this case :( Next time that happens I'll try and spot/grab it.

Quoted 9 lines
Quoted 7 lines

Is there any way to have the logging logged to disk straight away rather than stuck internally in oeqa's logging buffers? That way we could see which tests had run before a hang?

Also, could we make the scp failure non-fatal, maybe a warning so that
when it fails we can look at the rest of the logs?

I'll further investigate this idea.

Thanks!

Cheers,

Richard

author
#5 lore raw
Quoted 6 lines · Khem Raj

on master-next I am also seeing

step1b: WARNING: ltp-20200515-r0 do_patch: QA Issue: Patch log indicates that patches do not apply cleanly. [patch-fuzz]

I wonder if its related to this as well.

My bad.

Just a couple days ago ltp master introduced a commit directly effected the line above my change, resulting the diff to look slightly different.

I could send a patch on top of this commit, or is it possible to revert this merged commit altogether and I will send a new patch, to keep the git log clean. Whichever preferred by YP.

Matthew

Quoted 41 lines
Quoted 38 lines · Richard Purdie
Quoted 5 lines · Mingde (Matthew) Zeng
Quoted 3 lines · Richard Purdie
Quoted 1 line · Matthew

Fixes [YOCTO #13802]

Quoted 7 lines
Quoted 3 lines

Thanks, we can reference the bug but I don't think we can yet claim it
fixes it.

Sure, would something like the following work?

Reference [YOCTO #13802]

Simply "[YOCTO #13802]" is fine (I'll tweak the commit message as I merge).

Quoted 6 lines
Quoted 3 lines

The missing log issue happened again:
https://autobuilder.yoctoproject.org/typhoon/#/builders/96/builds/908
so I think there are multiple issues at play here.

Can you attach this build's log.do_testimage so I can have a further look?

Sorry, that build directory has been reused in this case :( Next time that happens I'll try and spot/grab it.

Quoted 9 lines
Quoted 7 lines

Is there any way to have the logging logged to disk straight away rather than stuck internally in oeqa's logging buffers? That way we could see which tests had run before a hang?

Also, could we make the scp failure non-fatal, maybe a warning so that
when it fails we can look at the rest of the logs?

I'll further investigate this idea.

Quoted 7 lines
Quoted 7 lines

Thanks!

Cheers,

Richard

--
Mingde (Matthew) Zeng

#6 lore raw
Quoted 9 lines · Mingde (Matthew) Zeng
Quoted 5 lines · Khem Raj

on master-next I am also seeing

step1b: WARNING: ltp-20200515-r0 do_patch: QA Issue: Patch log indicates that patches do not apply cleanly. [patch-fuzz]

Quoted 8 lines
Quoted 1 line

I wonder if its related to this as well.

My bad.

Just a couple days ago ltp master introduced a commit directly effected the line above my change, resulting the diff to look slightly different.

I could send a patch on top of this commit, or is it possible to revert this merged commit altogether and I will send a new patch, to keep the git log clean. Whichever preferred by YP.

its not in master yet so please send a v2.

Quoted 55 lines

Matthew

Quoted 41 lines
Quoted 38 lines · Richard Purdie
Quoted 5 lines · Mingde (Matthew) Zeng
Quoted 3 lines · Richard Purdie
Quoted 1 line · Matthew

Fixes [YOCTO #13802]

Quoted 7 lines
Quoted 3 lines

Thanks, we can reference the bug but I don't think we can yet claim it
fixes it.

Sure, would something like the following work?

Reference [YOCTO #13802]

Simply "[YOCTO #13802]" is fine (I'll tweak the commit message as I merge).

Quoted 6 lines
Quoted 3 lines

The missing log issue happened again:
https://autobuilder.yoctoproject.org/typhoon/#/builders/96/builds/908
so I think there are multiple issues at play here.

Can you attach this build's log.do_testimage so I can have a further look?

Sorry, that build directory has been reused in this case :( Next time that happens I'll try and spot/grab it.

Quoted 9 lines
Quoted 7 lines

Is there any way to have the logging logged to disk straight away rather than stuck internally in oeqa's logging buffers? That way we could see which tests had run before a hang?

Also, could we make the scp failure non-fatal, maybe a warning so that
when it fails we can look at the rest of the logs?

I'll further investigate this idea.

Quoted 7 lines
Quoted 7 lines

Thanks!

Cheers,

Richard

--
Mingde (Matthew) Zeng

author
#7 lore raw
Quoted 13 lines · Khem Raj
Quoted 11 lines · Mingde (Matthew) Zeng
Quoted 6 lines · Khem Raj

on master-next I am also seeing

step1b: WARNING: ltp-20200515-r0 do_patch: QA Issue: Patch log indicates that patches do not apply cleanly. [patch-fuzz]

I wonder if its related to this as well.

Quoted 8 lines
Quoted 6 lines

My bad.

Just a couple days ago ltp master introduced a commit directly effected the line above my change, resulting the diff to look slightly different.

I could send a patch on top of this commit, or is it possible to revert this merged commit altogether and I will send a new patch, to keep the git log clean. Whichever preferred by YP.

its not in master yet so please send a v2.

Done.

Quoted 49 lines
Quoted 49 lines

Matthew

Quoted 45 lines
Quoted 42 lines · Richard Purdie
Quoted 5 lines · Mingde (Matthew) Zeng
Quoted 3 lines · Richard Purdie
Quoted 1 line · Matthew

Fixes [YOCTO #13802]

Quoted 7 lines
Quoted 3 lines

Thanks, we can reference the bug but I don't think we can yet claim it
fixes it.

Sure, would something like the following work?

Reference [YOCTO #13802]

Simply "[YOCTO #13802]" is fine (I'll tweak the commit message as I merge).

Quoted 6 lines
Quoted 3 lines

The missing log issue happened again:
https://autobuilder.yoctoproject.org/typhoon/#/builders/96/builds/908
so I think there are multiple issues at play here.

Can you attach this build's log.do_testimage so I can have a further look?

Sorry, that build directory has been reused in this case :( Next time that happens I'll try and spot/grab it.

Quoted 9 lines
Quoted 7 lines

Is there any way to have the logging logged to disk straight away rather than stuck internally in oeqa's logging buffers? That way we could see which tests had run before a hang?

Also, could we make the scp failure non-fatal, maybe a warning so that
when it fails we can look at the rest of the logs?

I'll further investigate this idea.

Thanks!

Cheers,

Quoted 7 lines
Quoted 7 lines
Quoted 3 lines
Quoted 3 lines

Richard

--
Mingde (Matthew) Zeng

--
Mingde (Matthew) Zeng

author
#8 lore raw
In reply to Richard Purdie
Quoted 6 lines · Richard Purdie
Quoted 1 line · Matthew

Fixes [YOCTO #13802]

Thanks, we can reference the bug but I don't think we can yet claim it fixes it.

Quoted 7 lines

The missing log issue happened again:
https://autobuilder.yoctoproject.org/typhoon/#/builders/96/builds/908
so I think there are multiple issues at play here.

Is there any way to have the logging logged to disk straight away rather than stuck internally in oeqa's logging buffers? That way we could see which tests had run before a hang?

Ltp comes with zoo file already, is it what you're looking for?

Quoted 3 lines

Also, could we make the scp failure non-fatal, maybe a warning so that when it fails we can look at the rest of the logs?

I submitted a patch that I think should achieve this idea, please have a look.

Quoted 75 lines

Cheers,

Richard

Quoted 70 lines

Remove the OOM tests, since they might cause oeqa ssh connection lost.

---
 ...001-Remove-OOM-tests-from-runtest-mm.patch | 33
+++++++++++++++++++
 meta/recipes-extended/ltp/ltp_20200515.bb     |  1 +
 2 files changed, 34 insertions(+)
 create mode 100644 meta/recipes-extended/ltp/ltp/0001-Remove-OOM-

tests-from-runtest-mm.patch

(quoted diff) +0 -0

from-runtest-mm.patch b/meta/recipes-extended/ltp/ltp/0001-Remove- OOM-tests-from-runtest-mm.patch
new file mode 100644
index 0000000000..2d8262be78

meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from- new file +0 -0

runtest-mm.patch

meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from- new file +1 -0
@@ -0,0 +1,33 @@
+From 373b21dcf7a2879c27cc3dbeac5d83f5d45d22ae Mon Sep 17 00:00:00

2001

meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from- new file +32 -0
+From: "Mingde (Matthew) Zeng" <[email protected]>
+Date: Wed, 29 Jul 2020 08:47:09 -0400
+Subject: [PATCH] Remove OOM tests from runtest/mm
+
+Disable OOM tests, as they might cause oeqa ssh connection lost
+
+Upstream-Status: Inappropriate [oe-core specific]
+Signed-off-by: Mingde (Matthew) Zeng <[email protected]>
+---
+ runtest/mm | 6 ------
+ 1 file changed, 6 deletions(-)
+
+diff --git a/runtest/mm b/runtest/mm
+index 4701a14bd..2f9888ec6 100644
+--- a/runtest/mm
++++ b/runtest/mm
+@@ -75,12 +75,6 @@ ksm06_2 ksm06 -n 10000
+
+ cpuset01 cpuset01
+
+-oom01 oom01
+-oom02 oom02
+-oom03 oom03
+-oom04 oom04
+-oom05 oom05
+-
+ swapping01 swapping01 -i 5
+
+ thp01 thp01 -I 120
+--
+2.27.0
+
meta/recipes-extended/ltp/ltp_20200515.bb +1 -0
index ece3acf0f9..0c7044d044 100644
@@ -37,6 +37,7 @@ SRC_URI = "git://github.com/linux-test-
 project/ltp.git \
            file://0001-ptrace01-Fix-missing-format-string.patch \
            file://0001-sigwaitinfo-Do-not-run-invalid-undefined-
 test-cases.patch \
            file://0001-syscalls-copy_file_range02-Expect-EFBIG-in-
 subcase-m.patch \
+           file://0001-Remove-OOM-tests-from-runtest-mm.patch \
            "
Quoted 4 lines
Quoted 4 lines

S = "${WORKDIR}/git"
--
2.27.0

--
Mingde (Matthew) Zeng