Skip to contentSkip to conversation

xfs/030: repair should actually find the zeroed block pointer in the agfl

PATCH In review Darrick J. Wong 2 participants 2 messages Jul 29, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 xfs/030: repair should actually find the zeroed block pointer in the agfl

From: Darrick J. Wong <[email protected]>

In xfs/030, we zero the entire AGFL which makes it corrupt because the AG superblock block is /never/ free. In commit dcd6c2e1 ("xfs_repair:
convert to libxfs_verify_agbno") we enhanced repair to complain about zeroed entries in the AGFL, so add that to the golden output.

---
v2: point out which commit we're testing

---
 tests/xfs/030.out |    1 +
 1 file changed, 1 insertion(+)
tests/xfs/030.out +1 -0
index 4a7c4b8b..53299438 100644
@@ -105,6 +105,7 @@ Phase 1 - find and verify superblock...
 Phase 2 - using <TYPEOF> log
         - zero log...
         - scan filesystem freespace and inode maps...
+bad agbno AGBNO in agfl, agno 0
         - found root inode chunk
 Phase 3 - for each AG...
         - scan and clear agi unlinked lists...
Reviewed-by on v2 1/1
#1 lore raw
Quoted 10 lines · Darrick J. Wong

From: Darrick J. Wong <[email protected]>

In xfs/030, we zero the entire AGFL which makes it corrupt because the AG superblock block is /never/ free. In commit dcd6c2e1 ("xfs_repair:
convert to libxfs_verify_agbno") we enhanced repair to complain about zeroed entries in the AGFL, so add that to the golden output.

---
v2: point out which commit we're testing

Thanks for pointing out the commit.

Quoted 17 lines
---
 tests/xfs/030.out |    1 +
 1 file changed, 1 insertion(+)
tests/xfs/030.out +1 -0
index 4a7c4b8b..53299438 100644
@@ -105,6 +105,7 @@ Phase 1 - find and verify superblock...
 Phase 2 - using <TYPEOF> log
         - zero log...
         - scan filesystem freespace and inode maps...
+bad agbno AGBNO in agfl, agno 0
         - found root inode chunk
 Phase 3 - for each AG...
         - scan and clear agi unlinked lists...