habanalabs: unmap PCI bars upon iATU failure
PATCH 1/1 habanalabs: unmap PCI bars upon iATU failure
From: Ofir Bitton <[email protected]>
In case the driver fails to configure the PCI controller iATU, it needs to unmap the PCI bars before exiting so if the driver is removed, the bars won't be left mapped.
Signed-off-by Ofir Bitton <[email protected]>
Reviewed-by Oded Gabbay <[email protected]>
Signed-off-by Oded Gabbay <[email protected]>
--- drivers/misc/habanalabs/common/pci.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/misc/habanalabs/common/pci.c +4 -2
@@ -369,15 +369,17 @@ int hl_pci_init(struct hl_device *hdev) rc = hdev->asic_funcs->init_iatu (hdev);if (rc) {dev_err (hdev->dev,"Failed to initialize iATU\n" ); - goto disable_device; + goto unmap_pci_bars; } rc =hl_pci_set_dma_mask (hdev);if (rc) - goto disable_device; + goto unmap_pci_bars;return 0 ; +unmap_pci_bars: +hl_pci_bars_unmap (hdev); disable_device:pci_clear_master (pdev);pci_disable_device (pdev);
Signature · 1 line
2.17.1