Skip to contentSkip to conversation

gitlab-ci.yml: Compile some jobs out-of-tree

PATCH Applied Thomas Huth 2 participants 3 messages Jul 31, 2020 – Sep 4, 2020 KVM

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gitlab-ci.yml: Compile some jobs out-of-tree

So far we only compiled all jobs in-tree in the gitlab-CI. For the code that gets compiled twice (one time for 64-bit and one time for 32-bit for example), we can easily move one of the two jobs to out-of-tree build mode to increase the build test coverage a little bit.

---
 .gitlab-ci.yml | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
.gitlab-ci.yml +9 -3
index 1ec9797..6613c7b 100644
@@ -19,7 +19,9 @@ build-aarch64:
 build-arm:
  script:
  - dnf install -y qemu-system-arm gcc-arm-linux-gnu
- - ./configure --arch=arm --cross-prefix=arm-linux-gnu-
+ - mkdir build
+ - cd build
+ - ../configure --arch=arm --cross-prefix=arm-linux-gnu-
  - make -j2
  - ACCEL=tcg MAX_SMP=8 ./run_tests.sh
      selftest-setup selftest-vectors-kernel selftest-vectors-user selftest-smp
@@ -31,7 +33,9 @@ build-arm:
 build-ppc64be:
  script:
  - dnf install -y qemu-system-ppc gcc-powerpc64-linux-gnu
- - ./configure --arch=ppc64 --endian=big --cross-prefix=powerpc64-linux-gnu-
+ - mkdir build
+ - cd build
+ - ../configure --arch=ppc64 --endian=big --cross-prefix=powerpc64-linux-gnu-
  - make -j2
  - ACCEL=tcg ./run_tests.sh
      selftest-setup spapr_hcall rtas-get-time-of-day rtas-get-time-of-day-base
@@ -77,7 +81,9 @@ build-x86_64:
 build-i386:
  script:
  - dnf install -y qemu-system-x86 gcc
- - ./configure --arch=i386
+ - mkdir build
+ - cd build
+ - ../configure --arch=i386
  - make -j2
  - ACCEL=tcg ./run_tests.sh
      cmpxchg8b vmexit_cpuid vmexit_mov_from_cr8 vmexit_mov_to_cr8
Signature · 1 line
2.18.1
maintainer Applied
#1 lore raw
Quoted 38 lines · Thomas Huth

So far we only compiled all jobs in-tree in the gitlab-CI. For the code that gets compiled twice (one time for 64-bit and one time for 32-bit for example), we can easily move one of the two jobs to out-of-tree build mode to increase the build test coverage a little bit.

---
 .gitlab-ci.yml | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
.gitlab-ci.yml +6 -2
index 1ec9797..6613c7b 100644
@@ -19,7 +19,9 @@ build-aarch64:
 build-arm:
  script:
  - dnf install -y qemu-system-arm gcc-arm-linux-gnu
- - ./configure --arch=arm --cross-prefix=arm-linux-gnu-
+ - mkdir build
+ - cd build
+ - ../configure --arch=arm --cross-prefix=arm-linux-gnu-
  - make -j2
  - ACCEL=tcg MAX_SMP=8 ./run_tests.sh
      selftest-setup selftest-vectors-kernel selftest-vectors-user selftest-smp
@@ -31,7 +33,9 @@ build-arm:
 build-ppc64be:
  script:
  - dnf install -y qemu-system-ppc gcc-powerpc64-linux-gnu
- - ./configure --arch=ppc64 --endian=big --cross-prefix=powerpc64-linux-gnu-
+ - mkdir build
+ - cd build
+ - ../configure --arch=ppc64 --endian=big --cross-prefix=powerpc64-linux-gnu-
  - make -j2
  - ACCEL=tcg ./run_tests.sh
      selftest-setup spapr_hcall rtas-get-time-of-day rtas-get-time-of-day-base

.gitlab-ci.yml build-x86_64: · line 89

Quoted 10 lines
.gitlab-ci.yml +3 -1
@@ -77,7 +81,9 @@ build-x86_64:
 build-i386:
  script:
  - dnf install -y qemu-system-x86 gcc
- - ./configure --arch=i386
+ - mkdir build
+ - cd build
+ - ../configure --arch=i386
  - make -j2
  - ACCEL=tcg ./run_tests.sh
      cmpxchg8b vmexit_cpuid vmexit_mov_from_cr8 vmexit_mov_to_cr8

Applied, thanks.

Paolo

#2 lore raw
Quoted 43 lines · Paolo Bonzini
Quoted 42 lines · Thomas Huth

So far we only compiled all jobs in-tree in the gitlab-CI. For the code that gets compiled twice (one time for 64-bit and one time for 32-bit for example), we can easily move one of the two jobs to out-of-tree build mode to increase the build test coverage a little bit.

---
 .gitlab-ci.yml | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
.gitlab-ci.yml +7 -3
index 1ec9797..6613c7b 100644
@@ -19,7 +19,9 @@ build-aarch64:
 build-arm:
  script:
  - dnf install -y qemu-system-arm gcc-arm-linux-gnu
- - ./configure --arch=arm --cross-prefix=arm-linux-gnu-
+ - mkdir build
+ - cd build
+ - ../configure --arch=arm --cross-prefix=arm-linux-gnu-
  - make -j2
  - ACCEL=tcg MAX_SMP=8 ./run_tests.sh
      selftest-setup selftest-vectors-kernel selftest-vectors-user selftest-smp
@@ -31,7 +33,9 @@ build-arm:
 build-ppc64be:
  script:
  - dnf install -y qemu-system-ppc gcc-powerpc64-linux-gnu
- - ./configure --arch=ppc64 --endian=big --cross-prefix=powerpc64-linux-gnu-
+ - mkdir build
+ - cd build
+ - ../configure --arch=ppc64 --endian=big --cross-prefix=powerpc64-linux-gnu-
  - make -j2
  - ACCEL=tcg ./run_tests.sh
      selftest-setup spapr_hcall rtas-get-time-of-day rtas-get-time-of-day-base
@@ -77,7 +81,9 @@ build-x86_64:
 build-i386:
  script:
  - dnf install -y qemu-system-x86 gcc
- - ./configure --arch=i386
+ - mkdir build
Quoted 8 lines

.gitlab-ci.yml build-x86_64: · line 89

Quoted 6 lines
.gitlab-ci.yml +2 -0
+ - cd build
+ - ../configure --arch=i386
  - make -j2
  - ACCEL=tcg ./run_tests.sh
      cmpxchg8b vmexit_cpuid vmexit_mov_from_cr8 vmexit_mov_to_cr8

Applied, thanks.

... but never pushed?

Thomas