Fixes and improvements for Xen pvdrm
Subsystems (4)
cover Fixes and improvements for Xen pvdrm
From: Oleksandr Andrushchenko <[email protected]>
Hello,
This series contains an assorted set of fixes and improvements for the Xen para-virtualized display driver and grant device driver which I have collected over the last couple of months:
1. Minor fixes to grant device driver and drm/xen-front.
2. New format (YUYV) added to the list of the PV DRM supported formats which allows the driver to be used in zero-copying use-cases when a camera device is the source of the dma-bufs.
3. Synchronization with the latest para-virtualized protocol definition in Xen [1].
4. SGT offset is now propagated to the backend: while importing a dmabuf it is possible that the data of the buffer is put with offset which is indicated by the SGT offset. This is needed for some GPUs which have non-zero offset.
5. Version 2 of the Xen displif protocol adds XENDISPL_OP_GET_EDID request which allows frontends to request EDID structure per connector. This request is optional and if not supported by the backend then visible area is still defined by the relevant XenStore's "resolution" property.
If backend provides EDID with XENDISPL_OP_GET_EDID request then its values must take precedence over the resolutions defined in XenStore.
Thank you,
Oleksandr Andrushchenko
[1] https://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=c27a184225eab54d20435c8cab5ad0ef384dc2c0
Oleksandr Andrushchenko (6):
xen/gntdev: Fix dmabuf import with non-zero sgt offset drm/xen-front: Fix misused IS_ERR_OR_NULL checks drm/xen-front: Add YUYV to supported formats
xen: Sync up with the canonical protocol definition in Xen drm/xen-front: Pass dumb buffer data offset to the backend drm/xen-front: Add support for EDID based configuration
drivers/gpu/drm/xen/xen_drm_front.c | 72 +++++++++++++++- drivers/gpu/drm/xen/xen_drm_front.h | 11 ++- drivers/gpu/drm/xen/xen_drm_front_cfg.c | 82 +++++++++++++++++++ drivers/gpu/drm/xen/xen_drm_front_cfg.h | 7 ++ drivers/gpu/drm/xen/xen_drm_front_conn.c | 27 +++++- drivers/gpu/drm/xen/xen_drm_front_evtchnl.c | 3 + drivers/gpu/drm/xen/xen_drm_front_evtchnl.h | 3 + drivers/gpu/drm/xen/xen_drm_front_gem.c | 11 +-- drivers/gpu/drm/xen/xen_drm_front_kms.c | 7 +- drivers/xen/gntdev-dmabuf.c | 8 ++ include/xen/interface/io/displif.h | 91 ++++++++++++++++++++- 11 files changed, 305 insertions(+), 17 deletions(-)
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH 1/6 xen/gntdev: Fix dmabuf import with non-zero sgt offset
From: Oleksandr Andrushchenko <[email protected]>
It is possible that the scatter-gather table during dmabuf import has non-zero offset of the data, but user-space doesn't expect that. Fix this by failing the import, so user-space doesn't access wrong data.
--- drivers/xen/gntdev-dmabuf.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/xen/gntdev-dmabuf.c +8 -0
@@ -613,6 +613,14 @@ dmabuf_imp_to_refs(struct gntdev_dmabuf_priv *priv, struct device *dev, goto fail_detach; } +/* Check that we have zero offset. */ +if (sgt->sgl->offset) { + ret =ERR_PTR (-EINVAL ); +pr_debug ("DMA buffer has %d bytes offset, user-space expects 0\n" , + sgt->sgl->offset); + goto fail_unmap; + } +/* Check number of pages that imported buffer has. */ if (attach->dmabuf->size != gntdev_dmabuf->nr_pages <<PAGE_SHIFT ) { ret =ERR_PTR (-EINVAL );
Signature · 1 line
2.17.1
PATCH 2/6 drm/xen-front: Fix misused IS_ERR_OR_NULL checks
In reply to Oleksandr AndrushchenkoFrom: Oleksandr Andrushchenko <[email protected]>
The patch c575b7eeb89f: "drm/xen-front: Add support for Xen PV display frontend" from Apr 3, 2018, leads to the following static checker warning:
drivers/gpu/drm/xen/xen_drm_front_gem.c:140 xen_drm_front_gem_create() warn: passing zero to 'ERR_CAST'
drivers/gpu/drm/xen/xen_drm_front_gem.c
133 struct drm_gem_object *xen_drm_front_gem_create(struct drm_device *dev,
134 size_t size)
135 {
136 struct xen_gem_object *xen_obj;
137
138 xen_obj = gem_create(dev, size);
139 if (IS_ERR_OR_NULL(xen_obj))
140 return ERR_CAST(xen_obj);
Fix this and the rest of misused places with IS_ERR_OR_NULL in the driver.
--- drivers/gpu/drm/xen/xen_drm_front.c | 4 ++-- drivers/gpu/drm/xen/xen_drm_front_gem.c | 8 ++++---- drivers/gpu/drm/xen/xen_drm_front_kms.c | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-)
drivers/gpu/drm/xen/xen_drm_front.c +2 -2
@@ -400,8 +400,8 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp, args->size = args->pitch * args->height; obj =xen_drm_front_gem_create (dev, args->size); -if (IS_ERR_OR_NULL (obj)) { - ret =PTR_ERR_OR_ZERO (obj); +if (IS_ERR (obj)) { + ret =PTR_ERR (obj); goto fail; }
drivers/gpu/drm/xen/xen_drm_front_gem.c +4 -4
@@ -83,7 +83,7 @@ static struct xen_gem_object *gem_create(struct drm_device *dev, size_t size) size =round_up (size,PAGE_SIZE ); xen_obj =gem_create_obj (dev, size); -if (IS_ERR_OR_NULL (xen_obj)) +if (IS_ERR (xen_obj))return xen_obj;if (drm_info->front_info->cfg.be_alloc) {
@@ -117,7 +117,7 @@ static struct xen_gem_object *gem_create(struct drm_device *dev, size_t size)*/ xen_obj->num_pages =DIV_ROUND_UP (size,PAGE_SIZE ); xen_obj->pages =drm_gem_get_pages (&xen_obj->base); -if (IS_ERR_OR_NULL (xen_obj->pages)) { +if (IS_ERR (xen_obj->pages)) { ret =PTR_ERR (xen_obj->pages); xen_obj->pages =NULL ; goto fail;
@@ -136,7 +136,7 @@ struct drm_gem_object *xen_drm_front_gem_create(struct drm_device *dev,struct xen_gem_object *xen_obj; xen_obj =gem_create (dev, size); -if (IS_ERR_OR_NULL (xen_obj)) +if (IS_ERR (xen_obj))return ERR_CAST (xen_obj);return &xen_obj->base;
@@ -194,7 +194,7 @@ xen_drm_front_gem_import_sg_table(struct drm_device *dev, size = attach->dmabuf->size; xen_obj =gem_create_obj (dev, size); -if (IS_ERR_OR_NULL (xen_obj)) +if (IS_ERR (xen_obj))return ERR_CAST (xen_obj); ret =gem_alloc_pages_array (xen_obj, size);
drivers/gpu/drm/xen/xen_drm_front_kms.c +1 -1
@@ -60,7 +60,7 @@ fb_create(struct drm_device *dev, struct drm_file *filp,int ret; fb =drm_gem_fb_create_with_funcs (dev, filp, mode_cmd, &fb_funcs); -if (IS_ERR_OR_NULL (fb)) +if (IS_ERR (fb))return fb; gem_obj = fb->obj[0 ];
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH 3/6 drm/xen-front: Add YUYV to supported formats
In reply to Oleksandr AndrushchenkoFrom: Oleksandr Andrushchenko <[email protected]>
Add YUYV to supported formats, so the frontend can work with the formats used by cameras and other HW.
--- drivers/gpu/drm/xen/xen_drm_front_conn.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/xen/xen_drm_front_conn.c +1 -0
@@ -33,6 +33,7 @@ static const u32 plane_formats[] = {DRM_FORMAT_ARGB4444 ,DRM_FORMAT_XRGB1555 ,DRM_FORMAT_ARGB1555 , + DRM_FORMAT_YUYV, };const u32 *xen_drm_front_conn_get_formats (int *format_count)
Signature · 1 line
2.17.1
PATCH 5/6 drm/xen-front: Pass dumb buffer data offset to the backend
In reply to Oleksandr AndrushchenkoFrom: Oleksandr Andrushchenko <[email protected]>
While importing a dmabuf it is possible that the data of the buffer is put with offset which is indicated by the SGT offset. Respect the offset value and forward it to the backend.
--- drivers/gpu/drm/xen/xen_drm_front.c | 6 ++++-- drivers/gpu/drm/xen/xen_drm_front.h | 2 +- drivers/gpu/drm/xen/xen_drm_front_gem.c | 3 ++- 3 files changed, 7 insertions(+), 4 deletions(-)
drivers/gpu/drm/xen/xen_drm_front.c +4 -2
@@ -157,7 +157,8 @@ int xen_drm_front_mode_set(struct xen_drm_front_drm_pipeline *pipeline,int xen_drm_front_dbuf_create (struct xen_drm_front_info *front_info,u64 dbuf_cookie,u32 width,u32 height, -u32 bpp,u64 size,struct page **pages) +u32 bpp,u64 size,u32 offset, +struct page **pages) {struct xen_drm_front_evtchnl *evtchnl;struct xen_drm_front_dbuf *dbuf;
@@ -194,6 +195,7 @@ int xen_drm_front_dbuf_create(struct xen_drm_front_info *front_info, req->op.dbuf_create.gref_directory =xen_front_pgdir_shbuf_get_dir_start (&dbuf->shbuf); req->op.dbuf_create.buffer_sz = size; + req->op.dbuf_create.data_ofs = offset; req->op.dbuf_create.dbuf_cookie = dbuf_cookie; req->op.dbuf_create.width = width; req->op.dbuf_create.height = height;
@@ -408,7 +410,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp, ret =xen_drm_front_dbuf_create (drm_info->front_info,xen_drm_front_dbuf_to_cookie (obj), args->width, args->height, args->bpp, - args->size, + args->size,0 ,xen_drm_front_gem_get_pages (obj));if (ret) goto fail_backend;
drivers/gpu/drm/xen/xen_drm_front.h +1 -1
@@ -145,7 +145,7 @@ int xen_drm_front_mode_set(struct xen_drm_front_drm_pipeline *pipeline,int xen_drm_front_dbuf_create (struct xen_drm_front_info *front_info,u64 dbuf_cookie,u32 width,u32 height, -u32 bpp,u64 size,struct page **pages); +u32 bpp,u64 size,u32 offset,struct page **pages); int xen_drm_front_fb_attach(struct xen_drm_front_info *front_info, u64 dbuf_cookie, u64 fb_cookie, u32 width,
drivers/gpu/drm/xen/xen_drm_front_gem.c +2 -1
@@ -210,7 +210,8 @@ xen_drm_front_gem_import_sg_table(struct drm_device *dev, ret =xen_drm_front_dbuf_create (drm_info->front_info,xen_drm_front_dbuf_to_cookie (&xen_obj->base), -0 ,0 ,0 , size, xen_obj->pages); +0 ,0 ,0 , size, sgt->sgl->offset, + xen_obj->pages);if (ret <0 )return ERR_PTR (ret);
Signature · 1 line
2.17.1
PATCH 4/6 xen: Sync up with the canonical protocol definition in Xen
In reply to Oleksandr AndrushchenkoFrom: Oleksandr Andrushchenko <[email protected]>
This is the sync up with the canonical definition of the display protocol in Xen.
1. Add protocol version as an integer
Version string, which is in fact an integer, is hard to handle in the code that supports different protocol versions. To simplify that also add the version as an integer.
2. Pass buffer offset with XENDISPL_OP_DBUF_CREATE
There are cases when display data buffer is created with non-zero offset to the data start. Handle such cases and provide that offset while creating a display buffer.
3. Add XENDISPL_OP_GET_EDID command
Add an optional request for reading Extended Display Identification Data (EDID) structure which allows better configuration of the display connectors over the configuration set in XenStore. With this change connectors may have multiple resolutions defined with respect to detailed timing definitions and additional properties normally provided by displays.
If this request is not supported by the backend then visible area is defined by the relevant XenStore's "resolution" property.
If backend provides extended display identification data (EDID) with XENDISPL_OP_GET_EDID request then EDID values must take precedence over the resolutions defined in XenStore.
4. Bump protocol version to 2.
--- include/xen/interface/io/displif.h | 91 +++++++++++++++++++++++++++++- 1 file changed, 88 insertions(+), 3 deletions(-)
include/xen/interface/io/displif.h +88 -3
@@ -38,7 +38,8 @@* Protocol version ****************************************************************************** */ -#define XENDISPL_PROTOCOL_VERSION "1" +#define XENDISPL_PROTOCOL_VERSION "2" +#define XENDISPL_PROTOCOL_VERSION_INT 2/* ******************************************************************************
@@ -202,6 +203,9 @@* Width and height of the connector in pixels separated by * XENDISPL_RESOLUTION_SEPARATOR. This defines visible area of the * display. +* If backend provides extended display identification data (EDID) with +* XENDISPL_OP_GET_EDID request then EDID values must take precedence +* over the resolutions defined here. * *------------------ Connector Request Transport Parameters ------------------- *
@@ -349,6 +353,8 @@#define XENDISPL_OP_FB_DETACH 0x13#define XENDISPL_OP_SET_CONFIG 0x14#define XENDISPL_OP_PG_FLIP 0x15 +/* The below command is available in protocol version 2 and above. */ +#define XENDISPL_OP_GET_EDID 0x16/* ******************************************************************************
@@ -377,6 +383,10 @@#define XENDISPL_FIELD_BE_ALLOC "be-alloc"#define XENDISPL_FIELD_UNIQUE_ID "unique-id" +#define XENDISPL_EDID_BLOCK_SIZE 128 +#define XENDISPL_EDID_BLOCK_COUNT 256 +#define XENDISPL_EDID_MAX_SIZE (XENDISPL_EDID_BLOCK_SIZE * XENDISPL_EDID_BLOCK_COUNT) +/* ****************************************************************************** * STATUS RETURN CODES
@@ -451,7 +461,9 @@* +----------------+----------------+----------------+----------------+ * | gref_directory | 40 * +----------------+----------------+----------------+----------------+ -* | reserved | 44 +* | data_ofs | 44 +* +----------------+----------------+----------------+----------------+ +* | reserved | 48 * +----------------+----------------+----------------+----------------+ * |/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/| * +----------------+----------------+----------------+----------------+
@@ -494,6 +506,7 @@* buffer size (buffer_sz) exceeds what can be addressed by this single page, * then reference to the next page must be supplied (see gref_dir_next_page * below) +* data_ofs - uint32_t, offset of the data in the buffer, octets */ #define XENDISPL_DBUF_FLG_REQ_ALLOC (1 << 0)
@@ -506,6 +519,7 @@ struct xendispl_dbuf_create_req {uint32_t buffer_sz;uint32_t flags;grant_ref_t gref_directory; +uint32_t data_ofs; };/*
@@ -731,6 +745,44 @@ struct xendispl_page_flip_req {uint64_t fb_cookie; }; +/* +* Request EDID - request EDID describing current connector: +* 0 1 2 3 octet +* +----------------+----------------+----------------+----------------+ +* | id | _OP_GET_EDID | reserved | 4 +* +----------------+----------------+----------------+----------------+ +* | buffer_sz | 8 +* +----------------+----------------+----------------+----------------+ +* | gref_directory | 12 +* +----------------+----------------+----------------+----------------+ +* | reserved | 16 +* +----------------+----------------+----------------+----------------+ +* |/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/| +* +----------------+----------------+----------------+----------------+ +* | reserved | 64 +* +----------------+----------------+----------------+----------------+ +* +* Notes: +* - This command is not available in protocol version 1 and should be +* ignored. +* - This request is optional and if not supported then visible area +* is defined by the relevant XenStore's "resolution" property. +* - Shared buffer, allocated for EDID storage, must not be less then +* XENDISPL_EDID_MAX_SIZE octets. +* +* buffer_sz - uint32_t, buffer size to be allocated, octets +* gref_directory - grant_ref_t, a reference to the first shared page +* describing EDID buffer references. See XENDISPL_OP_DBUF_CREATE for +* grant page directory structure (struct xendispl_page_directory). +* +* See response format for this request. +*/ + +struct xendispl_get_edid_req { +uint32_t buffer_sz; +grant_ref_t gref_directory; +}; +/* *---------------------------------- Responses -------------------------------- *
@@ -753,6 +805,35 @@ struct xendispl_page_flip_req {* id - uint16_t, private guest value, echoed from request * status - int32_t, response status, zero on success and -XEN_EXX on failure * +* +* Get EDID response - response for XENDISPL_OP_GET_EDID: +* 0 1 2 3 octet +* +----------------+----------------+----------------+----------------+ +* | id | operation | reserved | 4 +* +----------------+----------------+----------------+----------------+ +* | status | 8 +* +----------------+----------------+----------------+----------------+ +* | edid_sz | 12 +* +----------------+----------------+----------------+----------------+ +* | reserved | 16 +* +----------------+----------------+----------------+----------------+ +* |/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/| +* +----------------+----------------+----------------+----------------+ +* | reserved | 64 +* +----------------+----------------+----------------+----------------+ +* +* Notes: +* - This response is not available in protocol version 1 and should be +* ignored. +* +* edid_sz - uint32_t, size of the EDID, octets +*/ + +struct xendispl_get_edid_resp { +uint32_t edid_sz; +}; + +/* *----------------------------------- Events ---------------------------------- * * Events are sent via a shared page allocated by the front and propagated by
@@ -804,6 +885,7 @@ struct xendispl_req {struct xendispl_fb_detach_req fb_detach;struct xendispl_set_config_req set_config;struct xendispl_page_flip_req pg_flip; +struct xendispl_get_edid_req get_edid;uint8_t reserved[56 ]; } op; };
@@ -813,7 +895,10 @@ struct xendispl_resp {uint8_t operation;uint8_t reserved;int32_t status; -uint8_t reserved1[56 ]; +union { +struct xendispl_get_edid_resp get_edid; +uint8_t reserved1[56 ]; + } op; };struct xendispl_evt {
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH 6/6 drm/xen-front: Add support for EDID based configuration
In reply to Oleksandr AndrushchenkoFrom: Oleksandr Andrushchenko <[email protected]>
Version 2 of the Xen displif protocol adds XENDISPL_OP_GET_EDID request which allows frontends to request EDID structure per connector. This request is optional and if not supported by the backend then visible area is still defined by the relevant XenStore's "resolution" property.
If backend provides EDID with XENDISPL_OP_GET_EDID request then its values must take precedence over the resolutions defined in XenStore.
--- drivers/gpu/drm/xen/xen_drm_front.c | 62 ++++++++++++++++ drivers/gpu/drm/xen/xen_drm_front.h | 9 ++- drivers/gpu/drm/xen/xen_drm_front_cfg.c | 82 +++++++++++++++++++++ drivers/gpu/drm/xen/xen_drm_front_cfg.h | 7 ++ drivers/gpu/drm/xen/xen_drm_front_conn.c | 26 ++++++- drivers/gpu/drm/xen/xen_drm_front_evtchnl.c | 3 + drivers/gpu/drm/xen/xen_drm_front_evtchnl.h | 3 + drivers/gpu/drm/xen/xen_drm_front_kms.c | 5 ++ 8 files changed, 194 insertions(+), 3 deletions(-)
drivers/gpu/drm/xen/xen_drm_front.c +62 -0
@@ -381,6 +381,59 @@ void xen_drm_front_on_frame_done(struct xen_drm_front_info *front_info, fb_cookie); } +int xen_drm_front_get_edid (struct xen_drm_front_info *front_info, +int conn_idx,struct page **pages, +u32 buffer_sz,u32 *edid_sz) +{ +struct xen_drm_front_evtchnl *evtchnl; +struct xen_front_pgdir_shbuf_cfg buf_cfg; +struct xen_front_pgdir_shbuf shbuf; +struct xendispl_req *req; +unsigned long flags; +int ret; + +if (unlikely (conn_idx >= front_info->num_evt_pairs)) +return -EINVAL ; + +memset (&buf_cfg,0 ,sizeof (buf_cfg)); + buf_cfg.xb_dev = front_info->xb_dev; + buf_cfg.num_pages =DIV_ROUND_UP (buffer_sz,PAGE_SIZE ); + buf_cfg.pages = pages; + buf_cfg.pgdir = &shbuf; + buf_cfg.be_alloc = false; + + ret =xen_front_pgdir_shbuf_alloc (&buf_cfg); +if (ret <0 ) +return ret; + + evtchnl = &front_info->evt_pairs[conn_idx].req; + +mutex_lock (&evtchnl->u.req.req_io_lock); + +spin_lock_irqsave (&front_info->io_lock, flags); + req =be_prepare_req (evtchnl,XENDISPL_OP_GET_EDID ); + req->op.get_edid.gref_directory = +xen_front_pgdir_shbuf_get_dir_start (&shbuf); + req->op.get_edid.buffer_sz = buffer_sz; + + ret =be_stream_do_io (evtchnl, req); +spin_unlock_irqrestore (&front_info->io_lock, flags); + +if (ret <0 ) + goto fail; + + ret =be_stream_wait_io (evtchnl); +if (ret <0 ) + goto fail; + + *edid_sz = evtchnl->u.req.resp.get_edid.edid_sz; + +fail: +mutex_unlock (&evtchnl->u.req.req_io_lock); +xen_front_pgdir_shbuf_free (&shbuf); +return ret; +} +static int xen_drm_drv_dumb_create (struct drm_file *filp,struct drm_device *dev,struct drm_mode_create_dumb *args)
@@ -466,6 +519,7 @@ static void xen_drm_drv_release(struct drm_device *dev)xenbus_switch_state (front_info->xb_dev, XenbusStateInitialising); +xen_drm_front_cfg_free (front_info, &front_info->cfg);kfree (drm_info); }
@@ -562,6 +616,7 @@ static int xen_drm_drv_init(struct xen_drm_front_info *front_info)drm_mode_config_cleanup (drm_dev);drm_dev_put (drm_dev); fail: +xen_drm_front_cfg_free (front_info, &front_info->cfg);kfree (drm_info);return ret; }
@@ -622,7 +677,14 @@ static int displback_initwait(struct xen_drm_front_info *front_info)static int displback_connect (struct xen_drm_front_info *front_info) { +int ret; +xen_drm_front_evtchnl_set_state (front_info,EVTCHNL_STATE_CONNECTED ); + +/* We are all set to read additional configuration from the backend. */ + ret =xen_drm_front_cfg_tail (front_info, &front_info->cfg); +if (ret <0 ) +return ret;return xen_drm_drv_init (front_info); }
drivers/gpu/drm/xen/xen_drm_front.h +8 -1
@@ -112,9 +112,12 @@ struct xen_drm_front_drm_pipeline {struct drm_simple_display_pipe pipe;struct drm_connector conn; -/* These are only for connector mode checking */ +/* These are only for connector mode checking if no EDID present */ int width, height; +/* Is not NULL if EDID is used for connector configuration. */ +struct edid *edid; +struct drm_pending_vblank_event *pending_event;struct delayed_work pflip_to_worker;
@@ -160,4 +163,8 @@ int xen_drm_front_page_flip(struct xen_drm_front_info *front_info,void xen_drm_front_on_frame_done (struct xen_drm_front_info *front_info,int conn_idx,u64 fb_cookie); +int xen_drm_front_get_edid (struct xen_drm_front_info *front_info, +int conn_idx,struct page **pages, +u32 buffer_sz,u32 *edid_sz); +#endif /* __XEN_DRM_FRONT_H_ */
drivers/gpu/drm/xen/xen_drm_front_cfg.c +82 -0
91 lines not on this page · raw message
drivers/gpu/drm/xen/xen_drm_front_cfg.h +7 -0
@@ -19,6 +19,7 @@ struct xen_drm_front_cfg_connector {int width;int height;char *xenstore_path; +struct edid *edid; };struct xen_drm_front_cfg {
@@ -34,4 +35,10 @@ struct xen_drm_front_cfg {int xen_drm_front_cfg_card (struct xen_drm_front_info *front_info,struct xen_drm_front_cfg *cfg); +int xen_drm_front_cfg_tail (struct xen_drm_front_info *front_info, +struct xen_drm_front_cfg *cfg); + +void xen_drm_front_cfg_free (struct xen_drm_front_info *front_info, +struct xen_drm_front_cfg *cfg); +#endif /* __XEN_DRM_FRONT_CFG_H_ */
drivers/gpu/drm/xen/xen_drm_front_conn.c +24 -2
@@ -66,6 +66,16 @@ static int connector_get_modes(struct drm_connector *connector)struct videomode videomode;int width, height; +if (pipeline->edid) { +int count; + +drm_connector_update_edid_property (connector, + pipeline->edid); + count =drm_add_edid_modes (connector, pipeline->edid); +if (count) +return count; + } + mode =drm_mode_create (connector->dev);if (!mode)return 0 ;
@@ -103,6 +113,7 @@ int xen_drm_front_conn_init(struct xen_drm_front_drm_info *drm_info, {struct xen_drm_front_drm_pipeline *pipeline =to_xen_drm_pipeline (connector); +int ret;drm_connector_helper_add (connector, &connector_helper_funcs);
@@ -111,6 +122,17 @@ int xen_drm_front_conn_init(struct xen_drm_front_drm_info *drm_info, connector->polled =DRM_CONNECTOR_POLL_CONNECT |DRM_CONNECTOR_POLL_DISCONNECT ; -return drm_connector_init (drm_info->drm_dev, connector, - &connector_funcs,DRM_MODE_CONNECTOR_VIRTUAL ); + ret =drm_connector_init (drm_info->drm_dev, connector, + &connector_funcs,DRM_MODE_CONNECTOR_VIRTUAL ); +if (ret <0 ) +return ret; + +/* +* Virtual connectors do not have EDID property, but we do, +* so add it manually if EDID is present. +*/ +if (pipeline->edid) +drm_connector_attach_edid_property (connector); + +return 0 ; }
drivers/gpu/drm/xen/xen_drm_front_evtchnl.c +3 -0
@@ -44,6 +44,9 @@ static irqreturn_t evtchnl_interrupt_ctrl(int irq, void *dev_id)continue ;switch (resp->operation) { +case XENDISPL_OP_GET_EDID : + evtchnl->u.req.resp.get_edid = + resp->op.get_edid;case XENDISPL_OP_PG_FLIP :case XENDISPL_OP_FB_ATTACH :case XENDISPL_OP_FB_DETACH :
drivers/gpu/drm/xen/xen_drm_front_evtchnl.h +3 -0
@@ -53,6 +53,9 @@ struct xen_drm_front_evtchnl {struct completion completion;/* latest response status */ int resp_status; +union { +struct xendispl_get_edid_resp get_edid; + } resp;/* serializer for backend IO: request/response */ struct mutex req_io_lock; } req;
drivers/gpu/drm/xen/xen_drm_front_kms.c +5 -0
@@ -288,6 +288,10 @@ display_mode_valid(struct drm_simple_display_pipe *pipe, container_of(pipe, struct xen_drm_front_drm_pipeline, pipe); +/* We have nothing to check if EDID is present. */ +if (pipeline->edid) +return MODE_OK ; +if (mode->hdisplay != pipeline->width)return MODE_ERROR ;
@@ -319,6 +323,7 @@ static int display_pipe_init(struct xen_drm_front_drm_info *drm_info, pipeline->index = index; pipeline->height = cfg->height; pipeline->width = cfg->width; + pipeline->edid = cfg->edid;INIT_DELAYED_WORK (&pipeline->pflip_to_worker, pflip_to_worker);
Signature · 1 line
2.17.1
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fixes and improvements for Xen pvdrm
In reply to Oleksandr Andrushchenko== Series Details ==
== Series Details ==
Series: Fixes and improvements for Xen pvdrm
URL : https://patchwork.freedesktop.org/series/80141/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
7d48f149439c xen/gntdev: Fix dmabuf import with non-zero sgt offset
-:10: WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '37ccb44d0b00', maybe rebased or not pulled?
#10:
Fixes: 37ccb44d0b00 ("xen/gntdev: Implement dma-buf import functionality")total: 0 errors, 1 warnings, 0 checks, 14 lines checkedc9e3448681cf drm/xen-front: Fix misused IS_ERR_OR_NULL checks
-:14: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #14:
133 struct drm_gem_object *xen_drm_front_gem_create(struct drm_device *dev,
total: 0 errors, 1 warnings, 0 checks, 50 lines checked 3efddbd31e3b drm/xen-front: Add YUYV to supported formats e17f2c5fcaec xen: Sync up with the canonical protocol definition in Xen -:108: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t' #108: FILE: include/xen/interface/io/displif.h:522:
+ uint32_t data_ofs;
-:150: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t' #150: FILE: include/xen/interface/io/displif.h:782:
+ uint32_t buffer_sz;
-:186: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t' #186: FILE: include/xen/interface/io/displif.h:833:
+ uint32_t edid_sz;
-:207: WARNING:TABSTOP: Statements should start on a tabstop #207: FILE: include/xen/interface/io/displif.h:899:
+ struct xendispl_get_edid_resp get_edid;
-:208: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u8' over 'uint8_t' #208: FILE: include/xen/interface/io/displif.h:900:
+ uint8_t reserved1[56];
total: 0 errors, 1 warnings, 4 checks, 157 lines checked 62e66d848083 drm/xen-front: Pass dumb buffer data offset to the backend b9a322b906d6 drm/xen-front: Add support for EDID based configuration -:253: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #253: FILE: drivers/gpu/drm/xen/xen_drm_front_cfg.h:39:
+int xen_drm_front_cfg_tail(struct xen_drm_front_info *front_info,
+ struct xen_drm_front_cfg *cfg);
-:256: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #256: FILE: drivers/gpu/drm/xen/xen_drm_front_cfg.h:42:
+void xen_drm_front_cfg_free(struct xen_drm_front_info *front_info,
+ struct xen_drm_front_cfg *cfg);
total: 0 errors, 0 warnings, 2 checks, 293 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for Fixes and improvements for Xen pvdrm
In reply to Oleksandr Andrushchenko== Series Details ==
== Series Details ==
Series: Fixes and improvements for Xen pvdrm
URL : https://patchwork.freedesktop.org/series/80141/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8822 -> Patchwork_18285
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/index.html
Known issues
------------
Here are the changes found in Patchwork_18285 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s0:
- fi-tgl-u2: [PASS][1] -> [FAIL][2] ([i915#1888])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/fi-tgl-u2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/fi-tgl-u2/igt@[email protected]
* igt@i915_selftest@live@execlists:
- fi-cfl-8109u: [PASS][3] -> [INCOMPLETE][4] ([i915#2089])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/fi-cfl-8109u/igt@i915_selftest@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/fi-cfl-8109u/igt@i915_selftest@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-byt-j1900: [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/fi-byt-j1900/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/fi-byt-j1900/igt@[email protected]
- fi-kbl-r: [PASS][7] -> [DMESG-WARN][8] ([i915#1982])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/fi-kbl-r/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/fi-kbl-r/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-u2: [FAIL][9] ([i915#1888]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/fi-tgl-u2/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/fi-tgl-u2/igt@[email protected]
* igt@i915_module_load@reload:
- fi-bsw-kefka: [DMESG-WARN][11] ([i915#1982]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/fi-bsw-kefka/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/fi-bsw-kefka/igt@[email protected]
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-byt-j1900: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/fi-byt-j1900/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/fi-byt-j1900/igt@[email protected]
* igt@i915_pm_rpm@module-reload:
- fi-bsw-n3050: [DMESG-WARN][15] ([i915#1982]) -> [PASS][16] +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/fi-bsw-n3050/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/fi-bsw-n3050/igt@[email protected]
* igt@kms_busy@basic@flip:
- {fi-tgl-dsi}: [DMESG-WARN][17] ([i915#1982]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/fi-tgl-dsi/igt@kms_busy@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/fi-tgl-dsi/igt@kms_busy@[email protected]
- fi-kbl-x1275: [DMESG-WARN][19] ([i915#62] / [i915#92] / [i915#95]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/fi-kbl-x1275/igt@kms_busy@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/fi-kbl-x1275/igt@kms_busy@[email protected]
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7500u: [DMESG-WARN][21] ([i915#2203]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/fi-kbl-7500u/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/fi-kbl-7500u/igt@[email protected]
* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- fi-icl-u2: [DMESG-WARN][23] ([i915#1982]) -> [PASS][24] +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/fi-icl-u2/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/fi-icl-u2/igt@[email protected]
#### Warnings ####
* igt@gem_exec_suspend@basic-s0:
- fi-kbl-x1275: [DMESG-WARN][25] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][26] ([i915#62] / [i915#92]) +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/fi-kbl-x1275/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/fi-kbl-x1275/igt@[email protected]
* igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size:
- fi-kbl-x1275: [DMESG-WARN][27] ([i915#62] / [i915#92]) -> [DMESG-WARN][28] ([i915#62] / [i915#92] / [i915#95]) +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/fi-kbl-x1275/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/fi-kbl-x1275/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2089]: https://gitlab.freedesktop.org/drm/intel/issues/2089
[i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (42 -> 36)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_8822 -> Patchwork_18285
CI-20190529: 20190529
CI_DRM_8822: 26bcf5c3ceadd2c69181a320c4363f58ae34be46 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5755: e9ef5db4cd286fb4bf151a24efcd7a62a4df18f1 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18285: b9a322b906d6b3b79e9ae93a0c4043f2f2a4e90d @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
b9a322b906d6 drm/xen-front: Add support for EDID based configuration 62e66d848083 drm/xen-front: Pass dumb buffer data offset to the backend e17f2c5fcaec xen: Sync up with the canonical protocol definition in Xen 3efddbd31e3b drm/xen-front: Add YUYV to supported formats c9e3448681cf drm/xen-front: Fix misused IS_ERR_OR_NULL checks 7d48f149439c xen/gntdev: Fix dmabuf import with non-zero sgt offset
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for Fixes and improvements for Xen pvdrm
In reply to Oleksandr Andrushchenko== Series Details ==
== Series Details ==
Series: Fixes and improvements for Xen pvdrm
URL : https://patchwork.freedesktop.org/series/80141/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8822_full -> Patchwork_18285_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_18285_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_create@madvise:
- shard-glk: [PASS][1] -> [DMESG-WARN][2] ([i915#118] / [i915#95])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-glk4/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-glk3/igt@[email protected]
* igt@gem_userptr_blits@invalid-mmap-offset-unsync@wb:
- shard-iclb: [PASS][3] -> [INCOMPLETE][4] ([i915#2119])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-iclb5/igt@gem_userptr_blits@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-iclb8/igt@gem_userptr_blits@[email protected]
* igt@kms_big_fb@y-tiled-64bpp-rotate-180:
- shard-glk: [PASS][5] -> [DMESG-FAIL][6] ([i915#118] / [i915#95])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-glk2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-glk8/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-skl: [PASS][7] -> [INCOMPLETE][8] ([i915#300])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-skl10/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-skl7/igt@[email protected]
* igt@kms_flip@2x-plain-flip-fb-recreate@ab-vga1-hdmi-a1:
- shard-hsw: [PASS][9] -> [DMESG-WARN][10] ([i915#1982])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-hsw6/igt@kms_flip@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-hsw8/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@b-edp1:
- shard-skl: [PASS][11] -> [FAIL][12] ([i915#79])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-skl8/igt@kms_flip@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-skl8/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: [PASS][13] -> [DMESG-WARN][14] ([i915#180]) +7 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-kbl2/igt@kms_flip@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-kbl3/igt@kms_flip@[email protected]
* igt@kms_flip_tiling@flip-changes-tiling:
- shard-skl: [PASS][15] -> [DMESG-WARN][16] ([i915#1982]) +9 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-skl4/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-skl7/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack:
- shard-kbl: [PASS][17] -> [DMESG-WARN][18] ([i915#1982])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-kbl2/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-kbl7/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-badstride:
- shard-glk: [PASS][19] -> [DMESG-WARN][20] ([i915#1982]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-glk7/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-glk8/igt@[email protected]
- shard-tglb: [PASS][21] -> [DMESG-WARN][22] ([i915#1982])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-tglb2/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-tglb6/igt@[email protected]
* igt@kms_hdr@bpc-switch:
- shard-skl: [PASS][23] -> [FAIL][24] ([i915#1188])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-skl4/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-skl3/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [PASS][25] -> [FAIL][26] ([fdo#108145] / [i915#265])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-skl9/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-skl10/igt@[email protected]
* igt@kms_psr@psr2_basic:
- shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#109441]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-iclb2/igt@kms_psr@psr2_basic.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-iclb3/igt@kms_psr@psr2_basic.html
* igt@kms_setmode@basic:
- shard-kbl: [PASS][29] -> [FAIL][30] ([i915#31])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-kbl4/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-kbl6/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_whisper@basic-queues-priority:
- shard-glk: [DMESG-WARN][31] ([i915#118] / [i915#95]) -> [PASS][32] +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-glk2/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-glk6/igt@[email protected]
* igt@gem_exec_whisper@basic-sync:
- shard-hsw: [DMESG-WARN][33] ([i915#1982]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-hsw6/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-hsw8/igt@[email protected]
* igt@gem_mmap_gtt@cpuset-big-copy:
- shard-iclb: [DMESG-WARN][35] ([i915#1982]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-iclb2/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-iclb3/igt@[email protected]
* igt@kms_cursor_legacy@cursora-vs-flipa-varying-size:
- shard-skl: [DMESG-WARN][37] ([i915#1982]) -> [PASS][38] +9 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-skl1/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-skl4/igt@[email protected]
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][39] ([i915#79]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-glk3/igt@kms_flip@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-glk7/igt@kms_flip@[email protected]
* igt@kms_flip@2x-plain-flip-fb-recreate@ab-hdmi-a1-hdmi-a2:
- shard-glk: [DMESG-WARN][41] ([i915#1982]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-glk8/igt@kms_flip@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-glk9/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-skl: [FAIL][43] ([i915#79]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-skl8/igt@kms_flip@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-skl8/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-cpu:
- shard-tglb: [DMESG-WARN][45] ([i915#1982]) -> [PASS][46] +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-tglb1/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-tglb3/igt@[email protected]
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][47] ([i915#1188]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-skl4/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-skl7/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [FAIL][49] ([fdo#108145] / [i915#265]) -> [PASS][50] +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-skl5/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-skl6/igt@[email protected]
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][51] ([fdo#109441]) -> [PASS][52] +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-iclb1/igt@kms_psr@psr2_primary_mmap_cpu.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [DMESG-WARN][53] ([i915#180]) -> [PASS][54] +7 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-kbl2/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-kbl3/igt@[email protected]
* igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
- shard-kbl: [DMESG-WARN][55] ([i915#165]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-kbl7/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-kbl2/igt@[email protected]
* igt@prime_busy@before-wait@vecs0:
- shard-hsw: [FAIL][57] -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-hsw7/igt@prime_busy@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-hsw1/igt@prime_busy@[email protected]
#### Warnings ####
* igt@gem_workarounds@suspend-resume-context:
- shard-kbl: [DMESG-WARN][59] ([i915#180]) -> [DMESG-WARN][60] ([i915#165])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-kbl1/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-kbl4/igt@[email protected]
* igt@i915_pm_dc@dc6-psr:
- shard-skl: [FAIL][61] ([i915#454]) -> [DMESG-FAIL][62] ([i915#1982])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-skl10/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-skl7/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-apl: [FAIL][63] ([fdo#108145] / [i915#1635] / [i915#265]) -> [DMESG-FAIL][64] ([fdo#108145] / [i915#1635] / [i915#1982])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-apl8/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-apl1/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
- shard-skl: [FAIL][65] ([fdo#108145] / [i915#265]) -> [DMESG-FAIL][66] ([fdo#108145] / [i915#1982])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-skl2/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-skl10/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [DMESG-FAIL][67] ([fdo#108145] / [i915#1982]) -> [DMESG-WARN][68] ([i915#1982])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8822/shard-skl6/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/shard-skl9/igt@[email protected]
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2119]: https://gitlab.freedesktop.org/drm/intel/issues/2119
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#300]: https://gitlab.freedesktop.org/drm/intel/issues/300
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_8822 -> Patchwork_18285
CI-20190529: 20190529
CI_DRM_8822: 26bcf5c3ceadd2c69181a320c4363f58ae34be46 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5755: e9ef5db4cd286fb4bf151a24efcd7a62a4df18f1 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18285: b9a322b906d6b3b79e9ae93a0c4043f2f2a4e90d @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18285/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 1/6] xen/gntdev: Fix dmabuf import with non-zero sgt offset
In reply to Oleksandr AndrushchenkoQuoted 7 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
It is possible that the scatter-gather table during dmabuf import has non-zero offset of the data, but user-space doesn't expect that. Fix this by failing the import, so user-space doesn't access wrong data.
Fixes 37ccb44d0b00 ("xen/gntdev: Implement dma-buf import functionality")
I can't find this commit in the tree. Did you mean bf8dc55b1358?
And don't you want to Cc stable for this patch, too?
Quoted 2 lines
Signed-off-by Oleksandr Andrushchenko <[email protected]>
Juergen
Jürgen Groß
maintainerRe: [PATCH 2/6] drm/xen-front: Fix misused IS_ERR_OR_NULL checks
In reply to Oleksandr AndrushchenkoQuoted 19 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
The patch
c575b7eeb89f: "drm/xen-front: Add support for Xen PV display frontend" from Apr 3, 2018, leads to the following static checker warning:drivers/gpu/drm/xen/xen_drm_front_gem.c:140 xen_drm_front_gem_create() warn: passing zero to 'ERR_CAST'
drivers/gpu/drm/xen/xen_drm_front_gem.c133 struct drm_gem_object *xen_drm_front_gem_create(struct drm_device *dev, 134 size_t size) 135 { 136 struct xen_gem_object *xen_obj; 137 138 xen_obj = gem_create(dev, size); 139 if (IS_ERR_OR_NULL(xen_obj)) 140 return ERR_CAST(xen_obj);
Quoted 4 lines
Fix this and the rest of misused places with
IS_ERR_OR_NULLin the driver.Fixes c575b7eeb89f: "drm/xen-front: Add support for Xen PV display frontend"
Again forgot to Cc stable?
Juergen
Re: [PATCH 4/6] xen: Sync up with the canonical protocol definition in Xen
In reply to Oleksandr AndrushchenkoQuoted 29 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
This is the sync up with the canonical definition of the display protocol in Xen.
1. Add protocol version as an integer
Version string, which is in fact an integer, is hard to handle in the code that supports different protocol versions. To simplify that also add the version as an integer.
2. Pass buffer offset with
XENDISPL_OP_DBUF_CREATEThere are cases when display data buffer is created with non-zero offset to the data start. Handle such cases and provide that offset while creating a display buffer.
3. Add
XENDISPL_OP_GET_EDIDcommandAdd an optional request for reading Extended Display Identification Data (EDID) structure which allows better configuration of the display connectors over the configuration set in XenStore. With this change connectors may have multiple resolutions defined with respect to detailed timing definitions and additional properties normally provided by displays.
If this request is not supported by the backend then visible area is defined by the relevant XenStore's "resolution" property.
Quoted 7 lines
If backend provides extended display identification data (EDID) with
XENDISPL_OP_GET_EDIDrequest then EDID values must take precedence over the resolutions defined in XenStore.4. Bump protocol version to 2.
Signed-off-by Oleksandr Andrushchenko <[email protected]>
Juergen
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Oleksandr Andrushchenko
maintainerRe: [PATCH 1/6] xen/gntdev: Fix dmabuf import with non-zero sgt offset
In reply to Jürgen GroßQuoted 10 lines · Jürgen Groß
Quoted 7 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
It is possible that the scatter-gather table during dmabuf import has non-zero offset of the data, but user-space doesn't expect that. Fix this by failing the import, so user-space doesn't access wrong data.
Fixes 37ccb44d0b00 ("xen/gntdev: Implement dma-buf import functionality")I can't find this commit in the tree. Did you mean
bf8dc55b1358?
I'll double-check, thank you
Quoted 2 lines
And don't you want to Cc stable for this patch, too?
Hm, yes, sounds reasonable
Quoted 8 lines
Quoted 3 lines
Signed-off-by Oleksandr Andrushchenko <[email protected]>Acked-by Juergen Gross <[email protected]>Juergen
Oleksandr Andrushchenko
maintainerRe: [PATCH 2/6] drm/xen-front: Fix misused IS_ERR_OR_NULL checks
In reply to Jürgen GroßQuoted 20 lines · Jürgen Groß
Quoted 19 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
The patch
c575b7eeb89f: "drm/xen-front: Add support for Xen PV display frontend" from Apr 3, 2018, leads to the following static checker warning:drivers/gpu/drm/xen/xen_drm_front_gem.c:140
xen_drm_front_gem_create()
warn: passing zero to 'ERR_CAST'
drivers/gpu/drm/xen/xen_drm_front_gem.c
133 structdrm_gem_object*xen_drm_front_gem_create(structdrm_device*dev, 134size_tsize) 135 {
136 structxen_gem_object*xen_obj;
137
138xen_obj=gem_create(dev, size);
139 if (IS_ERR_OR_NULL(xen_obj))
140 returnERR_CAST(xen_obj);
Quoted 6 lines
Quoted 4 lines
Fix this and the rest of misused places with
IS_ERR_OR_NULLin the driver.Fixes c575b7eeb89f: "drm/xen-front: Add support for Xen PV display frontend"Again forgot to Cc stable?
I was just not sure if these minor fixes need to go the stable, but I will add
Thank you
Quoted 3 lines
Juergen
Jürgen Groß
maintainerRe: [PATCH 2/6] drm/xen-front: Fix misused IS_ERR_OR_NULL checks
Quoted 22 lines · Oleksandr Andrushchenko
Quoted 20 lines · Jürgen Groß
Quoted 19 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
The patch
c575b7eeb89f: "drm/xen-front: Add support for Xen PV display frontend" from Apr 3, 2018, leads to the following static checker warning:drivers/gpu/drm/xen/xen_drm_front_gem.c:140
xen_drm_front_gem_create()
warn: passing zero to 'ERR_CAST'
drivers/gpu/drm/xen/xen_drm_front_gem.c
133 structdrm_gem_object*xen_drm_front_gem_create(structdrm_device*dev, 134size_tsize) 135 {
136 structxen_gem_object*xen_obj;
137
138xen_obj=gem_create(dev, size);
139 if (IS_ERR_OR_NULL(xen_obj))
140 returnERR_CAST(xen_obj);
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Fix this and the rest of misused places with
IS_ERR_OR_NULLin the driver.Fixes c575b7eeb89f: "drm/xen-front: Add support for Xen PV display frontend"Again forgot to Cc stable?
I was just not sure if these minor fixes need to go the stable, but I will add
I'm fine both ways.
Its just a reflex when I'm seeing a Fixes: tag but no Cc: stable. :-)
Juergen
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
kernel test robot
build botRe: [Intel-gfx] [PATCH 6/6] drm/xen-front: Add support for EDID based configuration
In reply to Oleksandr AndrushchenkoI love your patch! Perhaps something to improve:
Hi Oleksandr,
I love your patch! Perhaps something to improve:
[auto build test WARNING on drm-exynos/exynos-drm-next]
[also build test WARNING on drm-intel/for-linux-next tegra-drm/drm/tegra/for-next drm-tip/drm-tip linus/master v5.8 next-20200804] [cannot apply to xen-tip/linux-next drm/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Oleksandr-Andrushchenko/Fixes-and-improvements-for-Xen-pvdrm/20200731-205350 base: https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git exynos-drm-next compiler: aarch64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
cppcheck warnings: (new ones prefixed by >>)
>> drivers/irqchip/irq-gic.c:161:24: warning: Local variable gic_data shadows outer variable [shadowVar]
struct gic_chip_data *gic_data = irq_data_get_irq_chip_data(d);
^
drivers/irqchip/irq-gic.c:123:29: note: Shadowed declaration
static struct gic_chip_data gic_data[CONFIG_ARM_GIC_MAX_NR] __read_mostly;
^
drivers/irqchip/irq-gic.c:161:24: note: Shadow variable
struct gic_chip_data *gic_data = irq_data_get_irq_chip_data(d);
^
drivers/irqchip/irq-gic.c:167:24: warning: Local variable gic_data shadows outer variable [shadowVar]
struct gic_chip_data *gic_data = irq_data_get_irq_chip_data(d);
^
drivers/irqchip/irq-gic.c:123:29: note: Shadowed declaration
static struct gic_chip_data gic_data[CONFIG_ARM_GIC_MAX_NR] __read_mostly;
^
drivers/irqchip/irq-gic.c:167:24: note: Shadow variable
struct gic_chip_data *gic_data = irq_data_get_irq_chip_data(d);
^
>> drivers/irqchip/irq-gic.c:400:28: warning: Local variable gic_irq shadows outer function [shadowFunction]
unsigned int cascade_irq, gic_irq;
^
drivers/irqchip/irq-gic.c:171:28: note: Shadowed declaration
static inline unsigned int gic_irq(struct irq_data *d)
^
drivers/irqchip/irq-gic.c:400:28: note: Shadow variable
unsigned int cascade_irq, gic_irq;
^
>> drivers/irqchip/irq-gic.c:1507:14: warning: Local variable gic_cpu_base shadows outer function [shadowFunction]
phys_addr_t gic_cpu_base;
^
drivers/irqchip/irq-gic.c:165:29: note: Shadowed declaration
static inline void __iomem *gic_cpu_base(struct irq_data *d)
^
drivers/irqchip/irq-gic.c:1507:14: note: Shadow variable
phys_addr_t gic_cpu_base;
^
>> drivers/irqchip/irq-gic-v3.c:874:71: warning: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition]
gic_data.rdists.has_direct_lpi &= (!!(typer & GICR_TYPER_DirectLPIS) |
^
>> drivers/irqchip/irq-gic-v3.c:1808:6: warning: Local variable nr_redist_regions shadows outer variable [shadowVar]
u32 nr_redist_regions;
^
drivers/irqchip/irq-gic-v3.c:1880:6: note: Shadowed declaration
u32 nr_redist_regions;
^
drivers/irqchip/irq-gic-v3.c:1808:6: note: Shadow variable
u32 nr_redist_regions;
^
>> drivers/irqchip/irq-gic-v3.c:2042:6: warning: Local variable maint_irq_mode shadows outer variable [shadowVar]
int maint_irq_mode;
^
drivers/irqchip/irq-gic-v3.c:1884:6: note: Shadowed declaration
int maint_irq_mode;
^
drivers/irqchip/irq-gic-v3.c:2042:6: note: Shadow variable
int maint_irq_mode;
^
>> drivers/gpu/drm/xen/xen_drm_front_cfg.c:76:6: warning: Variable 'ret' is reassigned a value before the old one has been used. [redundantAssignment]
ret = xen_drm_front_get_edid(front_info, index, pages,
^
drivers/gpu/drm/xen/xen_drm_front_cfg.c:61:0: note: Variable 'ret' is reassigned a value before the old one has been used.
int i, npages, ret = -ENOMEM; ^
drivers/gpu/drm/xen/xen_drm_front_cfg.c:76:6: note: Variable 'ret' is reassigned a value before the old one has been used.
ret = xen_drm_front_get_edid(front_info, index, pages,
^
vim +/ret +76 drivers/gpu/drm/xen/xen_drm_front_cfg.c
54
55 static void cfg_connector_edid(struct xen_drm_front_info *front_info,
56 struct xen_drm_front_cfg_connector *connector,
57 int index)
58 {
59 struct page **pages;
60 u32 edid_sz;
61 int i, npages, ret = -ENOMEM;
62
63 connector->edid = vmalloc(XENDISPL_EDID_MAX_SIZE);
64 if (!connector->edid)
65 goto fail;
66
67 npages = DIV_ROUND_UP(XENDISPL_EDID_MAX_SIZE, PAGE_SIZE);
68 pages = kvmalloc_array(npages, sizeof(struct page *), GFP_KERNEL);
69 if (!pages)
70 goto fail_free_edid;
71
72 for (i = 0; i < npages; i++)
73 pages[i] = vmalloc_to_page((u8 *)connector->edid +
74 i * PAGE_SIZE);
75
> 76 ret = xen_drm_front_get_edid(front_info, index, pages,
77 XENDISPL_EDID_MAX_SIZE, &edid_sz);
78
79 kvfree(pages);
80
81 if (ret < 0)
82 goto fail_free_edid;
83
84 ret = -EINVAL;
85 if (!edid_sz || (edid_sz % EDID_LENGTH))
86 goto fail_free_edid;
87
88 if (!drm_edid_is_valid(connector->edid))
89 goto fail_free_edid;
90
91 DRM_INFO("Connector %s: using EDID for configuration, size %d\n",
92 connector->xenstore_path, edid_sz);
93 return;
94
95 fail_free_edid:
96 cfg_connector_free_edid(connector);
97 fail:
98 /*
99 * If any error this is not critical as we can still read 100 * connector settings from XenStore, so just warn.
101 */
102 DRM_WARN("Connector %s: cannot read or wrong EDID: %d\n",
103 connector->xenstore_path, ret);
104 }
105
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
Re: [PATCH 2/6] drm/xen-front: Fix misused IS_ERR_OR_NULL checks
In reply to Oleksandr AndrushchenkoRe: [PATCH 2/6] drm/xen-front: Fix misused IS_ERR_OR_NULL checks
In reply to Oleksandr AndrushchenkoQuoted 22 lines · Oleksandr Andrushchenko
Quoted 20 lines · Jürgen Groß
Quoted 19 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
The patch
c575b7eeb89f: "drm/xen-front: Add support for Xen PV display frontend" from Apr 3, 2018, leads to the following static checker warning:drivers/gpu/drm/xen/xen_drm_front_gem.c:140
xen_drm_front_gem_create()
warn: passing zero to 'ERR_CAST'
drivers/gpu/drm/xen/xen_drm_front_gem.c
133 structdrm_gem_object*xen_drm_front_gem_create(structdrm_device*dev, 134size_tsize) 135 {
136 structxen_gem_object*xen_obj;
137
138xen_obj=gem_create(dev, size);
139 if (IS_ERR_OR_NULL(xen_obj))
140 returnERR_CAST(xen_obj);
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Fix this and the rest of misused places with
IS_ERR_OR_NULLin the driver.Fixes c575b7eeb89f: "drm/xen-front: Add support for Xen PV display frontend"Again forgot to Cc stable?
I was just not sure if these minor fixes need to go the stable, but I will add
Correct. It's still a bug because it's setting the error code incorrectly on the impossible path. But fortunately impossible things don't affect runtime.
regards,
dan carpenter
Re: [PATCH 5/6] drm/xen-front: Pass dumb buffer data offset to the backend
In reply to Oleksandr AndrushchenkoDen 31.07.2020 14.51, skrev Oleksandr Andrushchenko:
Quoted 8 lines
From: Oleksandr Andrushchenko <[email protected]>
While importing a dmabuf it is possible that the data of the buffer is put with offset which is indicated by the SGT offset. Respect the offset value and forward it to the backend.
Signed-off-by Oleksandr Andrushchenko <[email protected]>---
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 3/6] drm/xen-front: Add YUYV to supported formats
In reply to Oleksandr AndrushchenkoDen 31.07.2020 14.51, skrev Oleksandr Andrushchenko:
Quoted 7 lines
From: Oleksandr Andrushchenko <[email protected]>
Add YUYV to supported formats, so the frontend can work with the formats used by cameras and other HW.
Signed-off-by Oleksandr Andrushchenko <[email protected]>---
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel