Skip to contentSkip to conversation

staging: rtl8723bs: os_dep: fix coding style issue in xmit_linux.c

PATCH In review Mohammed Rushad 2 participants 2 messages Aug 2, 2020 – Aug 18, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8723bs: os_dep: fix coding style issue in xmit_linux.c

This is a patch to the xmit_linux.c file that fixes brace and missing line warning found by checkpatch.pl tool

---
 drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/os_dep/xmit_linux.c +2 -2
index fec8a8caaa46..b199d355e568 100644
@@ -148,13 +148,13 @@ static int rtw_mlcst2unicst(struct adapter *padapter, struct sk_buff *skb)
 	/* free sta asoc_queue */
 	while (phead != plist) {
 		int stainfo_offset;
+
 		psta = LIST_CONTAINOR(plist, struct sta_info, asoc_list);
 		plist = get_next(plist);
 
 		stainfo_offset = rtw_stainfo_offset(pstapriv, psta);
-		if (stainfo_offset_valid(stainfo_offset)) {
+		if (stainfo_offset_valid(stainfo_offset))
 			chk_alive_list[chk_alive_num++] = stainfo_offset;
-		}
 	}
 	spin_unlock_bh(&pstapriv->asoc_list_lock);
 
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 18 lines · Mohammed Rushad

This is a patch to the xmit_linux.c file that fixes brace and missing line warning found by checkpatch.pl tool

---
 drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/os_dep/xmit_linux.c +1 -0
index fec8a8caaa46..b199d355e568 100644
@@ -148,13 +148,13 @@ static int rtw_mlcst2unicst(struct adapter *padapter, struct sk_buff *skb)
 	/* free sta asoc_queue */
 	while (phead != plist) {
 		int stainfo_offset;
+
 		psta = LIST_CONTAINOR(plist, struct sta_info, asoc_list);

drivers/staging/rtl8723bs/os_dep/xmit_linux.c static int rtw_mlcst2unicst(struct adapter *padapter, struct sk_buff *skb) · line 160

Quoted 10 lines
drivers/staging/rtl8723bs/os_dep/xmit_linux.c +1 -2
 		plist = get_next(plist);
 
 		stainfo_offset = rtw_stainfo_offset(pstapriv, psta);
-		if (stainfo_offset_valid(stainfo_offset)) {
+		if (stainfo_offset_valid(stainfo_offset))
 			chk_alive_list[chk_alive_num++] = stainfo_offset;
-		}
 	}
 	spin_unlock_bh(&pstapriv->asoc_list_lock);
 

As trivial as it is, this is still two different things in a single patch :(

If this was the last remaining issue in this file, I might consider it, but it isn't, so please break up your changes into one-type-of-change-per-patch.

thanks,

greg k-h