target/arm: Fix decode of {LD,ST}RA[AB] instructions
PATCH 1/1 target/arm: Fix decode of {LD,ST}RA[AB] instructions
These instructions use zero as the discriminator, not SP.
--- target/arm/translate-a64.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
target/arm/translate-a64.c +4 -2
@@ -3429,9 +3429,11 @@ static void disas_ldst_pac(DisasContext *s, uint32_t insn,if (s->pauth_active) {if (use_key_a) { -gen_helper_autda (dirty_addr, cpu_env, dirty_addr, cpu_X[31 ]); +gen_helper_autda (dirty_addr, cpu_env, dirty_addr, +new_tmp_a64_zero (s)); }else { -gen_helper_autdb (dirty_addr, cpu_env, dirty_addr, cpu_X[31 ]); +gen_helper_autdb (dirty_addr, cpu_env, dirty_addr, +new_tmp_a64_zero (s)); } }
Signature · 1 line
2.28.0.163.g6104cc2f0b6-goog
Quoted 2 lines · Peter Collingbourne
These instructions use zero as the discriminator, not SP.
Oh, there is no such thing as STRAA/STRAB. I must have been confused by the name of the function, disas_ldst_pac. I will send a v2 with a fixed commit message, and another patch to rename the function to disas_ld_pac.
Peter
Quoted 27 lines
Signed-off-by Peter Collingbourne <[email protected]>--- target/arm/translate-a64.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)target/arm/translate-a64.c +4
-3@@ -3429,9 +3429,11 @@ static void disas_ldst_pac(DisasContext *s, uint32_t insn,if (s->pauth_active) {if (use_key_a) { -gen_helper_autda (dirty_addr, cpu_env, dirty_addr, cpu_X[31 ]); +gen_helper_autda (dirty_addr, cpu_env, dirty_addr, +new_tmp_a64_zero (s)); }else { -gen_helper_autdb (dirty_addr, cpu_env, dirty_addr, cpu_X[31 ]); +gen_helper_autdb (dirty_addr, cpu_env, dirty_addr, +new_tmp_a64_zero (s)); } } --2.28.0.163.g6104cc2f0b6-goog
Quoted 8 lines · Peter Collingbourne
Quoted 2 lines · Peter Collingbourne
These instructions use zero as the discriminator, not SP.
Oh, there is no such thing as STRAA/STRAB. I must have been confused by the name of the function,
disas_ldst_pac. I will send a v2 with a fixed commit message, and another patch to rename the function todisas_ld_pac.
It's called decode_ldst_pac because the Arm ARM section is called "Load/store register (pac)". Page C4-311 in the F.a revision.
But yes, there are only loads defined in the section.
r~
Quoted 11 lines · Richard Henderson
Quoted 8 lines · Peter Collingbourne
Quoted 2 lines · Peter Collingbourne
These instructions use zero as the discriminator, not SP.
Oh, there is no such thing as STRAA/STRAB. I must have been confused by the name of the function,
disas_ldst_pac. I will send a v2 with a fixed commit message, and another patch to rename the function todisas_ld_pac.
Quoted 4 lines
It's called
decode_ldst_pacbecause the Arm ARM section is called "Load/store register (pac)". Page C4-311 in the F.a revision.But yes, there are only loads defined in the section.
I see. Arguably the ARM ARM section is misnamed then. There is a sibling section named "Load register (literal)", so there is precedent for naming a section after the types of instructions that are actually supported. I will send mail to [email protected] to see if the section can be renamed.
Peter