Skip to contentSkip to conversation

drm/mgag200: Set PCI option register in G200SE models

PATCH In review Thomas Zimmermann 2 participants 2 messages Aug 4, 2020

Subsystems (3)
lore
Share & tools
lore

Thomas Zimmermann

author maintainer
#0 lore raw

PATCH 1/1 drm/mgag200: Set PCI option register in G200SE models

The initial value of the PCI option register got lost while refactoring the driver init code. Restore the setting.

Fixes 2021708e0d6e ("drm/mgag200: Initialize PCI registers early during device setup")
Cc Lyude Paul <[email protected]>
Cc Dave Airlie <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Gerd Hoffmann <[email protected]>
Cc Emil Velikov <[email protected]>
---
 drivers/gpu/drm/mgag200/mgag200_drv.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/mgag200/mgag200_drv.c +1 -0
index 5c854bc7dc86..09170d46aa53 100644
@@ -74,6 +74,7 @@ static int mgag200_regs_init(struct mga_device *mdev)
 		break;
 	case G200_SE_A:
 	case G200_SE_B:
+		option = 0x40049120;
 		if (mgag200_has_sgram(mdev))
 			option |= PCI_MGA_OPTION_HARDPWMSK;
 		option2 = 0x00008000;
Signature · 6 lines
2.28.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Thomas Zimmermann

The initial value of the PCI option register got lost while refactoring the driver init code. Restore the setting.

Ooops,

Quoted 28 lines
Fixes 2021708e0d6e ("drm/mgag200: Initialize PCI registers early during device setup")
Cc Lyude Paul <[email protected]>
Cc Dave Airlie <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Gerd Hoffmann <[email protected]>
Cc Emil Velikov <[email protected]>
---
 drivers/gpu/drm/mgag200/mgag200_drv.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/mgag200/mgag200_drv.c +1 -1
index 5c854bc7dc86..09170d46aa53 100644
@@ -74,6 +74,7 @@ static int mgag200_regs_init(struct mga_device *mdev)
                break;
        case G200_SE_A:
        case G200_SE_B:
+               option = 0x40049120;
                if (mgag200_has_sgram(mdev))
                        option |= PCI_MGA_OPTION_HARDPWMSK;
                option2 = 0x00008000;
--

2.28.0

Quoted 4 lines

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel