virtio-rng: add a control queue
PATCH v3 1/1 virtio-rng: add a control queue
A control queue is needed to send command to ask the device to release the request buffers if it cannot provide data.
Changes:
5.4.2 Virtqueues
0 requestq
1 controlq
controlq only exists if VIRTIO_RNG_F_CTRL_VQ set.
5.4.3 Feature bits
VIRTIO_RNG_F_CTRL_VQ (0)
Device has a control queue
5.4.5 Device Initialization
Identify and initialize the request virtqueue. If the VIRTIO_RNG_F_CTRL_VQ feature bit is negotiated, identify the control virtqueue.
5.4.6.3 Control Virtqueue
The driver uses the control virtqueue (if VIRTIO_RNG_F_CTRL_VQ is negotiated) to send commands to control the device. All commands are of the following form:
struct virtio_rng_ctrl_hdr {
u8 cmd;};
5.4.6.4 Device Requirements: Control Virtqueue
If VIRTIO_RNG_F_CTRL_VQ is negotiated, the device MUST implement the flush command.
Any other value of cmd MUST be ignored by the device.
5.4.6.5 Request Virtqueue Flushing
When the device is not able to provide enough entropy to the driver, the driver may be stuck waiting for the device returning buffers, and cannot be removed to switch to another one. The flush command allows the driver to ask the device to release all the buffers sent to the device. This allows the driver to release resources allocated to receive data from the device.
#define VIRTIO_RNG_CMD_FLUSH 0
5.4.6.5.1 Device Requirements: Request Virtqueue Flushing When the driver sends a flush request, the device MUST release all outstanding buffers.
Bug-Link: https://github.com/oasis-tcs/virtio-spec/issues/83
---
Notes:
v3: Add devicenormative references in conformance part
Move "Request Virtqueue Flushing" from \paragraph to \subsubsection to be behind "Control Virtqueue" and not behind
"Device Requirements: Control Virtqueue"
v2: Add devicenormative for the Control Virtqueue
Add devicenormative for the Request Virtqueue Flushing Reword paragraph Request Virtqueue Flushing
conformance.tex | 2 ++ content.tex | 47 +++++++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 47 insertions(+), 2 deletions(-)
conformance.tex +2 -0
@@ -321,6 +321,8 @@ \section{Conformance Targets}\label{sec:Conformance / Conformance Targets} \begin{itemize} \item \ref{devicenormative:Device Types / Entropy Device / Device Operation} +\item \ref{devicenormative:Device Types / Entropy Device / Device Operation / Control Virtqueue} +\item \ref{devicenormative:Device Types / Entropy Device / Device Operation / Control Virtqueue / Request Virtqueue Flushing} \end{itemize} \conformance{\subsection}{Traditional Memory Balloon Device Conformance}\label{sec:Conformance / Device Conformance / Traditional Memory Balloon Device Conformance}
content.tex +45 -2
68 lines not on this page · raw message
Signature · 18 lines
2.26.2 This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: [email protected] Unsubscribe: [email protected] List help: [email protected] List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/
Quoted 46 lines · On Tue, 4 Aug 2020 17:41:27 +0200 Laurent Vivier <[email protected]> wrote:
A control queue is needed to send command to ask the device to release the request buffers if it cannot provide data.
Changes:
5.4.2 Virtqueues
0 requestq
1 controlq
controlq only exists ifVIRTIO_RNG_F_CTRL_VQset.5.4.3 Feature bits
VIRTIO_RNG_F_CTRL_VQ(0)
Device has a control queue5.4.5 Device Initialization
Identify and initialize the request virtqueue. If theVIRTIO_RNG_F_CTRL_VQfeature bit is negotiated, identify the control virtqueue.5.4.6.3 Control Virtqueue
The driver uses the control virtqueue (ifVIRTIO_RNG_F_CTRL_VQis negotiated) to send commands to control the device. All commands are of the following form:struct virtio_rng_ctrl_hdr { u8 cmd;};
5.4.6.4 Device Requirements: Control Virtqueue
IfVIRTIO_RNG_F_CTRL_VQis negotiated, the device MUST implement the flush command.
Any other value of cmd MUST be ignored by the device.5.4.6.5 Request Virtqueue Flushing
When the device is not able to provide enough entropy to the driver, the driver may be stuck waiting for the device returning buffers, and cannot be removed to switch to another one. The flush command allows the driver to ask the device to release all the buffers sent to the device. This allows the driver to release resources allocated to receive data from the device.
#defineVIRTIO_RNG_CMD_FLUSH05.4.6.5.1 Device Requirements: Request Virtqueue Flushing When the driver sends a flush request, the device MUST release all outstanding buffers.
Bug-Link: https://github.com/oasis-tcs/virtio-spec/issues/83
Quoted 8 lines
Signed-off-by Laurent Vivier <[email protected]>---
Notes:
v3: Add devicenormative references in conformance part
Move "Request Virtqueue Flushing" from \paragraph to \subsubsection to be behind "Control Virtqueue" and not behind
"Device Requirements: Control Virtqueue"
There are different ways to put the conformance statements (and what should be a paragraph vs a subsubsection), and your layout seems reasonable, avoiding nesting too deep.
Quoted 8 lines
v2: Add devicenormative for the Control Virtqueue
Add devicenormative for the Request Virtqueue Flushing Reword paragraph Request Virtqueue Flushingconformance.tex | 2 ++ content.tex | 47 +++++++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 47 insertions(+), 2 deletions(-)
This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.
Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
On Tue, Aug 04, 2020 at 05:41:27PM +0200, Laurent Vivier wrote:
Why can't the driver reset the device so that the buffers are no longer owned by the device?
Review
Quoted 3 lines
+\subsubsection{Request Virtqueue Flushing}\label{sec:Device Types / Entropy Device / Device Operation / Control Virtqueue / Request Virtqueue Flushing}
(quoted diff) +2
-0+ +When the device is not able to provide enough entropy to the driver, the driver may be stuck waiting for the device returning buffers, and cannot be removed to switch to another one.
s/returning/to return/
"cannot be removed to switch to another one"? Is this referring to hot unplug?
content.tex \subsection{Device Operation}\label{sec:Device Types / Entropy Device / Device O · line 5028
Quoted 10 lines
content.tex +10
-0+The flush command allows the driver to ask the device to release all the buffers sent to the +device. This allows the driver to release resources allocated to receive data from the device. + +\begin{lstlisting} +#define VIRTIO_RNG_CMD_FLUSH 0 +\end{lstlisting} + +\devicenormative{\paragraph}{Request Virtqueue Flushing}{Device Types / Entropy Device / Device Operation / Control Virtqueue / Request Virtqueue Flushing} + +When the driver sends a flush request, the device MUST release all outstanding buffers.
"releasing" a buffer is not term defined by the VIRTIO. I guess the full explanation is:
When the driver sends a flush request, the device MUST use all available requestq buffers and set the used length to 0.
?