Skip to contentSkip to conversation

nfc: enforce CAP_NET_RAW for raw sockets When creating a raw AF_NFC socket, CAP_NET_RAW needs to be checked first.

PATCH In review Qingyu Li 2 participants 2 messages Aug 6, 2020

Subsystems (3)
lore
Share & tools
lore

Qingyu Li

author
#0 lore raw

PATCH 1/1 nfc: enforce CAP_NET_RAW for raw sockets When creating a raw AF_NFC socket, CAP_NET_RAW needs to be checked first.

---
 net/nfc/rawsock.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
net/nfc/rawsock.c +4 -1
index ba5ffd3badd3..c1302b689a98 100644
@@ -332,8 +332,11 @@ static int rawsock_create(struct net *net, struct socket *sock,
 	if ((sock->type != SOCK_SEQPACKET) && (sock->type != SOCK_RAW))
 		return -ESOCKTNOSUPPORT;
 
-	if (sock->type == SOCK_RAW)
+	if (sock->type == SOCK_RAW){
+		if (!capable(CAP_NET_RAW))
+			return -EPERM;
 		sock->ops = &rawsock_raw_ops;
+	}
 	else
 		sock->ops = &rawsock_ops;
 
maintainer
#1 lore raw

On Thu, 6 Aug 2020 10:28:08 +0800 Qingyu Li wrote:

Commit message is required. Perhaps shorten the subject and put more info here.

Quoted 10 lines
---
 net/nfc/rawsock.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
net/nfc/rawsock.c +0 -0
index ba5ffd3badd3..c1302b689a98 100644

net/nfc/rawsock.c static int rawsock_create(struct net *net, struct socket *sock, · line 339

Quoted 9 lines
net/nfc/rawsock.c +4 -1
@@ -332,8 +332,11 @@ static int rawsock_create(struct net *net, struct socket *sock,
 	if ((sock->type != SOCK_SEQPACKET) && (sock->type != SOCK_RAW))
 		return -ESOCKTNOSUPPORT;
 
-	if (sock->type == SOCK_RAW)
+	if (sock->type == SOCK_RAW){
+		if (!capable(CAP_NET_RAW))
+			return -EPERM;
 		sock->ops = &rawsock_raw_ops;
+	}

please run checkpatch.pl --strict and fix the issues.

Quoted 5 lines
net/nfc/rawsock.c +0 -0
 	else
 		sock->ops = &rawsock_ops;