Skip to contentSkip to conversation

btrfs-progs: docs: update the stability and performance status of quota

PATCH In review Qu Wenruo 4 participants 4 messages Aug 6, 2020

Subsystems (2)
lore
Share & tools
lore

Qu Wenruo

author
#0 lore raw

PATCH 1/1 btrfs-progs: docs: update the stability and performance status of quota

There are a lot of enhancement to btrfs quota through v5.x releases.

Now btrfs quota is more stable than it used to be.

So update the man page to relect this.

---
 Documentation/btrfs-quota.asciidoc | 43 +++++++++++++++++++++++++-----
 1 file changed, 37 insertions(+), 6 deletions(-)
Documentation/btrfs-quota.asciidoc +37 -6
index 85ebf729c2fa..1c032f11d001 100644
@@ -23,16 +23,47 @@ PERFORMANCE IMPLICATIONS
 ~~~~~~~~~~~~~~~~~~~~~~~~
 
 When quotas are activated, they affect all extent processing, which takes a
-performance hit. Activation of qgroups is not recommended unless the user
-intends to actually use them.
+performance hit.
+
+Under most cases, the performance hit should be more or less acceptable for
+root fs usage.
+
+There used to be a huge performance hit for balance with quota enabled.
+That problem is solved since v5.4 kernel.
 
 STABILITY STATUS
 ~~~~~~~~~~~~~~~~
 
-The qgroup implementation has turned out to be quite difficult as it affects
-the core of the filesystem operation. Qgroup users have hit various corner cases
-over time, such as incorrect accounting or system instability. The situation is
-gradually improving and issues found and fixed.
+Btrfs quota has different stablity for different functionality:
+
+Extent accounting
+^^^^^^^^^^^^^^^^^
+
+Pretty stable, there aren't many bugs (if any) affecting the extent accounting
+through v5.x release cycles.
+
+Thus if users just want referenced/exclusive usage of each subvolume, it
+should be safe to use.
+
+Limit
+^^^^^
+
+Should be near stable since v5.9.
+
+There used to be some bugs causing early EDQUOT errors before v5.9.
+But v5.9 should solve them quite well, along with extra safe nets catching any
+reserved space leakage.
+
+Corner cases and small fixes may pop up time by time, but the core limit
+functionality should be in good shape since v5.9.
+
+Multi-level qgroups
+^^^^^^^^^^^^^^^^^^^
+
+Needs more testing. Although the core extent accounting should also work well
+for higher level qgroups, we don't have good enough test coverage yet.
+
+Thus extra testing and bug reports are welcomed.
 
 HIERARCHICAL QUOTA GROUP CONCEPTS
 ---------------------------------
Signature · 1 line
2.28.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 71 lines · Qu Wenruo

There are a lot of enhancement to btrfs quota through v5.x releases.

Now btrfs quota is more stable than it used to be.

So update the man page to relect this.

---
 Documentation/btrfs-quota.asciidoc | 43 +++++++++++++++++++++++++-----
 1 file changed, 37 insertions(+), 6 deletions(-)
Documentation/btrfs-quota.asciidoc +37 -7
index 85ebf729c2fa..1c032f11d001 100644
@@ -23,16 +23,47 @@ PERFORMANCE IMPLICATIONS
 ~~~~~~~~~~~~~~~~~~~~~~~~
 
 When quotas are activated, they affect all extent processing, which takes a
-performance hit. Activation of qgroups is not recommended unless the user
-intends to actually use them.
+performance hit.
+
+Under most cases, the performance hit should be more or less acceptable for
+root fs usage.
+
+There used to be a huge performance hit for balance with quota enabled.
+That problem is solved since v5.4 kernel.
 
 STABILITY STATUS
 ~~~~~~~~~~~~~~~~
 
-The qgroup implementation has turned out to be quite difficult as it affects
-the core of the filesystem operation. Qgroup users have hit various corner cases
-over time, such as incorrect accounting or system instability. The situation is
-gradually improving and issues found and fixed.
+Btrfs quota has different stablity for different functionality:
+
+Extent accounting
+^^^^^^^^^^^^^^^^^
+
+Pretty stable, there aren't many bugs (if any) affecting the extent accounting
+through v5.x release cycles.
+
+Thus if users just want referenced/exclusive usage of each subvolume, it
+should be safe to use.
+
+Limit
+^^^^^
+
+Should be near stable since v5.9.
+
+There used to be some bugs causing early EDQUOT errors before v5.9.
+But v5.9 should solve them quite well, along with extra safe nets catching any
+reserved space leakage.
+
+Corner cases and small fixes may pop up time by time, but the core limit
+functionality should be in good shape since v5.9.
+
+Multi-level qgroups
+^^^^^^^^^^^^^^^^^^^
+
+Needs more testing. Although the core extent accounting should also work well
+for higher level qgroups, we don't have good enough test coverage yet.
+
+Thus extra testing and bug reports are welcomed.
 
 HIERARCHICAL QUOTA GROUP CONCEPTS
 ---------------------------------
--
Quoted 2 lines

2.28.0

LGTM.

Signature · 1 line
真実はいつも一つ!/ Always, there's only one truth!
#2 lore raw
In reply to Qu Wenruo
Quoted 41 lines · Qu Wenruo

There are a lot of enhancement to btrfs quota through v5.x releases.

Now btrfs quota is more stable than it used to be.

So update the man page to relect this.

---
  Documentation/btrfs-quota.asciidoc | 43 +++++++++++++++++++++++++-----
  1 file changed, 37 insertions(+), 6 deletions(-)
Documentation/btrfs-quota.asciidoc +12 -6
index 85ebf729c2fa..1c032f11d001 100644
@@ -23,16 +23,47 @@ PERFORMANCE IMPLICATIONS
  ~~~~~~~~~~~~~~~~~~~~~~~~
 
  When quotas are activated, they affect all extent processing, which takes a
-performance hit. Activation of qgroups is not recommended unless the user
-intends to actually use them.
+performance hit.
+
+Under most cases, the performance hit should be more or less acceptable for
+root fs usage.
+
+There used to be a huge performance hit for balance with quota enabled.
+That problem is solved since v5.4 kernel.
 
  STABILITY STATUS
  ~~~~~~~~~~~~~~~~
 
-The qgroup implementation has turned out to be quite difficult as it affects
-the core of the filesystem operation. Qgroup users have hit various corner cases
-over time, such as incorrect accounting or system instability. The situation is
-gradually improving and issues found and fixed.
+Btrfs quota has different stablity for different functionality:
+
+Extent accounting
+^^^^^^^^^^^^^^^^^
+

Documentation/btrfs-quota.asciidoc PERFORMANCE IMPLICATIONS · line 51

Quoted 10 lines
Documentation/btrfs-quota.asciidoc +10 -0
+Pretty stable, there aren't many bugs (if any) affecting the extent accounting
+through v5.x release cycles.
+
+Thus if users just want referenced/exclusive usage of each subvolume, it
+should be safe to use.
+
+Limit
+^^^^^
+
+Should be near stable since v5.9.

Is it correct v5.9 ? We are at v5.8....

Quoted 19 lines
Documentation/btrfs-quota.asciidoc +15 -0
+
+There used to be some bugs causing early EDQUOT errors before v5.9.
+But v5.9 should solve them quite well, along with extra safe nets catching any
+reserved space leakage.
+
+Corner cases and small fixes may pop up time by time, but the core limit
+functionality should be in good shape since v5.9.
+
+Multi-level qgroups
+^^^^^^^^^^^^^^^^^^^
+
+Needs more testing. Although the core extent accounting should also work well
+for higher level qgroups, we don't have good enough test coverage yet.
+
+Thus extra testing and bug reports are welcomed.
 
  HIERARCHICAL QUOTA GROUP CONCEPTS
  ---------------------------------
Signature · 2 lines
gpg @keyserver.linux.it: Goffredo Baroncelli <kreijackATinwind.it>
Key fingerprint BBF5 1610 0B64 DAC6 5F7D  17B2 0EDA 9B37 8B82 E0B5
#3 lore raw
Quoted 51 lines · Goffredo Baroncelli
Quoted 50 lines · Qu Wenruo

There are a lot of enhancement to btrfs quota through v5.x releases.

Now btrfs quota is more stable than it used to be.

So update the man page to relect this.

---
  Documentation/btrfs-quota.asciidoc | 43 +++++++++++++++++++++++++-----

  1 file changed, 37 insertions(+), 6 deletions(-)
Documentation/btrfs-quota.asciidoc +0 -0
index 85ebf729c2fa..1c032f11d001 100644
@@ -23,16 +23,47 @@ PERFORMANCE IMPLICATIONS

  ~~~~~~~~~~~~~~~~~~~~~~~~
    When quotas are activated, they affect all extent processing, which takes a
-performance hit. Activation of qgroups is not recommended unless the user

Documentation/btrfs-quota.asciidoc +3 -1
-intends to actually use them.
+performance hit.
+
+Under most cases, the performance hit should be more or less

acceptable for

Documentation/btrfs-quota.asciidoc +4 -0
+root fs usage.
+
+There used to be a huge performance hit for balance with quota enabled.
+That problem is solved since v5.4 kernel.

    STABILITY STATUS
  ~~~~~~~~~~~~~~~~
  -The qgroup implementation has turned out to be quite difficult as it affects
-the core of the filesystem operation. Qgroup users have hit various corner cases
-over time, such as incorrect accounting or system instability. The situation is

Documentation/btrfs-quota.asciidoc +6 -1
-gradually improving and issues found and fixed.
+Btrfs quota has different stablity for different functionality:
+
+Extent accounting
+^^^^^^^^^^^^^^^^^
+
+Pretty stable, there aren't many bugs (if any) affecting the extent

accounting

Documentation/btrfs-quota.asciidoc +3 -0
+through v5.x release cycles.
+
+Thus if users just want referenced/exclusive usage of each subvolume, it
Quoted 8 lines

Documentation/btrfs-quota.asciidoc PERFORMANCE IMPLICATIONS · line 51

Quoted 6 lines
Documentation/btrfs-quota.asciidoc +6 -0
+should be safe to use.
+
+Limit
+^^^^^
+
+Should be near stable since v5.9.

Is it correct v5.9 ? We are at v5.8....

Yes. The fixes are in the latest torvalds' master branch, which will become v5.9-rc1 soon.

Thanks,
Qu

Quoted 23 lines
Quoted 21 lines
Documentation/btrfs-quota.asciidoc +3 -0
+
+There used to be some bugs causing early EDQUOT errors before v5.9.
+But v5.9 should solve them quite well, along with extra safe nets

catching any

Documentation/btrfs-quota.asciidoc +9 -0
+reserved space leakage.
+
+Corner cases and small fixes may pop up time by time, but the core limit
+functionality should be in good shape since v5.9.
+
+Multi-level qgroups
+^^^^^^^^^^^^^^^^^^^
+
+Needs more testing. Although the core extent accounting should also

work well

Documentation/btrfs-quota.asciidoc +3 -0
+for higher level qgroups, we don't have good enough test coverage yet.
+
+Thus extra testing and bug reports are welcomed.

    HIERARCHICAL QUOTA GROUP CONCEPTS
  ---------------------------------