Skip to contentSkip to conversation

binder: Remove bogus warning on failed same-process transaction

PATCH In review Jann Horn 3 participants 3 messages Aug 6, 2020 – Aug 7, 2020 Android drivers

lore
Share & tools
lore

Jann Horn

author
#0 lore raw

PATCH 1/1 binder: Remove bogus warning on failed same-process transaction

While binder transactions with the same binder_proc as sender and recipient are forbidden, transactions with the same task_struct as sender and recipient are possible (even though currently there is a weird check in binder_transaction() that rejects them in the target==0 case). Therefore, task_struct identities can't be used to distinguish whether the caller is running in the context of the sender or the recipient.

Since I see no easy way to make this WARN_ON() useful and correct, let's just remove it.

Fixes 44d8047f1d87 ("binder: use standard functions to allocate fds")
Reported-by [email protected]
---
 drivers/android/binder.c | 2 --
 1 file changed, 2 deletions(-)
drivers/android/binder.c +0 -2
index f936530a19b0..5b0376344dbe 100644
@@ -2344,8 +2344,6 @@ static void binder_transaction_buffer_release(struct binder_proc *proc,
 			 * file is done when the transaction is torn
 			 * down.
 			 */
-			WARN_ON(failed_at &&
-				proc->tsk == current->group_leader);
 		} break;
 		case BINDER_TYPE_PTR:
 			/*

base-commit: 47ec5303d73ea344e84f46660fff693c57641386

Signature · 1 line
2.28.0.163.g6104cc2f0b6-goog
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Jann Horn

While binder transactions with the same binder_proc as sender and recipient are forbidden, transactions with the same task_struct as sender and recipient are possible (even though currently there is a weird check in binder_transaction() that rejects them in the target==0 case). Therefore, task_struct identities can't be used to distinguish whether the caller is running in the context of the sender or the recipient.

Quoted 6 lines

Since I see no easy way to make this WARN_ON() useful and correct, let's just remove it.

Fixes 44d8047f1d87 ("binder: use standard functions to allocate fds")
Reported-by [email protected]
Quoted 22 lines
---
 drivers/android/binder.c | 2 --
 1 file changed, 2 deletions(-)
drivers/android/binder.c +0 -2
index f936530a19b0..5b0376344dbe 100644
@@ -2344,8 +2344,6 @@ static void binder_transaction_buffer_release(struct binder_proc *proc,
                         * file is done when the transaction is torn
                         * down.
                         */
-                       WARN_ON(failed_at &&
-                               proc->tsk == current->group_leader);
                } break;
                case BINDER_TYPE_PTR:
                        /*

base-commit: 47ec5303d73ea344e84f46660fff693c57641386 --
2.28.0.163.g6104cc2f0b6-goog

Acked-by on v1 1/1
#2 lore raw
In reply to Jann Horn
Quoted 7 lines · Jann Horn

While binder transactions with the same binder_proc as sender and recipient are forbidden, transactions with the same task_struct as sender and recipient are possible (even though currently there is a weird check in binder_transaction() that rejects them in the target==0 case). Therefore, task_struct identities can't be used to distinguish whether the caller is running in the context of the sender or the recipient.

Quoted 7 lines

Since I see no easy way to make this WARN_ON() useful and correct, let's just remove it.

Fixes 44d8047f1d87 ("binder: use standard functions to allocate fds")
Reported-by [email protected]

---

Thanks!
Christian