Skip to contentSkip to conversation

configs: socfpga: add kernel parameter for immediate reboot

PATCH Superseded Ooi 2 participants 3 messages Aug 7, 2020

lore
Share & tools
lore

Ooi

#0 lore raw

PATCH v2 1/1 configs: socfpga: add kernel parameter for immediate reboot

From: Joyce Ooi <[email protected]>

Add Linux kernel line parameters for socfpga soc64 U-Boot. The "panic=-1" indicates the reset should occur immediately (without a delay).

---
v2: fix typo in commit message

---
 include/configs/socfpga_soc64_common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/socfpga_soc64_common.h +1 -1
index 7237ec95e34..d51a532a929 100644
@@ -79,7 +79,7 @@ unsigned int cm_get_qspi_controller_clk_hz(void);
  * CONFIG_BOOTARGS goes into the environment value "bootargs".
  * Do note the value will override also the chosen node in FDT blob.
  */
-#define CONFIG_BOOTARGS "earlycon"
+#define CONFIG_BOOTARGS "earlycon panic=-1"
 #define CONFIG_BOOTCOMMAND "run fatscript; run mmcload;run linux_qspi_enable;" \
 			   "run mmcboot"
 
Signature · 1 line
2.13.0
#1 lore raw

PATCH v2 1/1 configs: socfpga: add kernel parameter for immediate reboot

Quoted 34 lines

-----Original Message-----
From: Ooi, Joyce <[email protected]>
Sent: Friday, August 7, 2020 2:39 PM
To: Simon Goldschmidt <[email protected]>; Tan, Ley Foon <[email protected]>; Miquel Raynal <[email protected]>; Boris Brezillon <[email protected]>; Marek Vasut <[email protected]>; Ashok Reddy Soma <[email protected]>; Hannes Schmelzer <[email protected]>
Cc: u-boot at lists.denx.de; Ooi, Joyce <[email protected]>; Lim, Elly Siew Chin <[email protected]>; See, Chin Liang <[email protected]>; Nguyen, Dinh <[email protected]>
Subject: [PATCH v2] configs: socfpga: add kernel parameter for immediate reboot

From: Joyce Ooi <[email protected]>

Add Linux kernel line parameters for socfpga soc64 U-Boot. The "panic=-1" indicates the reset should occur immediately (without a delay).

---
v2: fix typo in commit message

---
 include/configs/socfpga_soc64_common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/socfpga_soc64_common.h +0 -0
index 7237ec95e34..d51a532a929 100644

include/configs/socfpga_soc64_common.h unsigned int cm_get_qspi_controller_clk_hz(void); · line 85

Quoted 8 lines
include/configs/socfpga_soc64_common.h +1 -1
@@ -79,7 +79,7 @@ unsigned int cm_get_qspi_controller_clk_hz(void);
  * CONFIG_BOOTARGS goes into the environment value "bootargs".
  * Do note the value will override also the chosen node in FDT blob.
  */
-#define CONFIG_BOOTARGS "earlycon"
+#define CONFIG_BOOTARGS "earlycon panic=-1"
 #define CONFIG_BOOTCOMMAND "run fatscript; run mmcload;run
 linux_qspi_enable;" \
 			   "run mmcboot"

Hi Joyce

Just noticed CONFIG_BOOTARGS is supported in Kconfig now. Can you move this #define to Stratix10 and Agilex *_defconfig?

Regards
Ley Foon

#2 lore raw

PATCH v2 1/1 configs: socfpga: add kernel parameter for immediate reboot

Tan, Ley Foon <[email protected]> schrieb am Fr., 7. Aug. 2020, 09:25:

Quoted 31 lines
Quoted 18 lines · Joyce

From: Joyce Ooi <[email protected]>

Add Linux kernel line parameters for socfpga soc64 U-Boot. The "panic=-1" indicates the reset should occur immediately (without a delay).

---
v2: fix typo in commit message

---
 include/configs/socfpga_soc64_common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/socfpga_soc64_common.h +0 -0
index 7237ec95e34..d51a532a929 100644

include/configs/socfpga_soc64_common.h unsigned int cm_get_qspi_controller_clk_hz(void); · line 85

Quoted 8 lines
include/configs/socfpga_soc64_common.h +1 -1
@@ -79,7 +79,7 @@ unsigned int cm_get_qspi_controller_clk_hz(void);
  * CONFIG_BOOTARGS goes into the environment value "bootargs".
  * Do note the value will override also the chosen node in FDT blob.
  */
-#define CONFIG_BOOTARGS "earlycon"
+#define CONFIG_BOOTARGS "earlycon panic=-1"
 #define CONFIG_BOOTCOMMAND "run fatscript; run mmcload;run
 linux_qspi_enable;" \
                         "run mmcboot"

Hi Joyce

Quoted 3 lines

Just noticed CONFIG_BOOTARGS is supported in Kconfig now. Can you move this #define to Stratix10 and Agilex *_defconfig?

Of course _defconfig is a much better place so that people can easily override it...
But why do we need this in the defconfig at all? I don't know how other platforms handle this, but to me it seems like a user setting, not a thing that should be changed by general config?

Regards,
Simon

Quoted 3 lines

Regards
Ley Foon