Skip to contentSkip to conversation

media: sunxi: sun8i-rotate.c: remove useless error message

PATCH In review Daniel W. S. Almeida 1 participant 1 message Aug 7, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/20 media: sunxi: sun8i-rotate.c: remove useless error message

From: "Daniel W. S. Almeida" <[email protected]>

This fixes the following coccinelle report:

drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c:751:2-9:
line 751 is redundant because platform_get_irq() already prints an error

By removing the useless call to dev_err()

Found using - Coccinelle (http://coccinelle.lip6.fr)

---
 drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c +1 -4
index 94f505d3cbad..3f81dd17755c 100644
@@ -747,11 +747,8 @@ static int rotate_probe(struct platform_device *pdev)
 	dev->dev = &pdev->dev;
 
 	irq = platform_get_irq(pdev, 0);
-	if (irq <= 0) {
-		dev_err(dev->dev, "Failed to get IRQ\n");
-
+	if (irq <= 0)
 		return irq;
-	}
 
 	ret = devm_request_irq(dev->dev, irq, rotate_irq,
 			       0, dev_name(dev->dev), dev);
Signature · 1 line
2.28.0