Skip to contentSkip to conversation

docs: Fix function name trailing double-()s

PATCH In review Kees Cook 3 participants 4 messages Aug 8, 2020 – Aug 11, 2020

Subsystems (4)
lore
Share & tools
lore

Kees Cook

author
#0 lore raw

PATCH 1/1 docs: Fix function name trailing double-()s

I noticed a double-() after a function name in deprecated.rst today. Fix that one and two others in the Documentation/ tree.

---
 Documentation/RCU/lockdep.rst                           | 2 +-
 Documentation/process/deprecated.rst                    | 2 +-
 Documentation/translations/it_IT/process/deprecated.rst | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
Documentation/RCU/lockdep.rst +1 -1
index f1fc8ae3846a..cc860a0c296b 100644
@@ -49,7 +49,7 @@ checking of rcu_dereference() primitives:
 		is invoked by both RCU-sched readers and updaters.
 	srcu_dereference_check(p, c):
 		Use explicit check expression "c" along with
-		srcu_read_lock_held()().  This is useful in code that
+		srcu_read_lock_held().  This is useful in code that
 		is invoked by both SRCU readers and updaters.
 	rcu_dereference_raw(p):
 		Don't check.  (Use sparingly, if at all.)
Documentation/process/deprecated.rst +1 -1
index 4a9aa4f0681e..918e32d76fc4 100644
@@ -142,7 +142,7 @@ only NUL-terminated strings. The safe replacement is strscpy().
 (Users of strscpy() still needing NUL-padding should instead
 use strscpy_pad().)
 
-If a caller is using non-NUL-terminated strings, strncpy()() can
+If a caller is using non-NUL-terminated strings, strncpy() can
 still be used, but destinations should be marked with the `__nonstring
 <https://gcc.gnu.org/onlinedocs/gcc/Common-Variable-Attributes.html>`_
 attribute to avoid future compiler warnings.
Documentation/translations/it_IT/process/deprecated.rst +1 -1
index e108eaf82cf6..a642ff3fdc8b 100644
@@ -130,7 +130,7 @@ chi usa solo stringe terminate. La versione sicura da usare è
 strscpy(). (chi usa strscpy() e necessita di estendere la
 terminazione con NUL deve aggiungere una chiamata a memset())
 
-Se il chiamate no usa stringhe terminate con NUL, allore strncpy()()
+Se il chiamate no usa stringhe terminate con NUL, allore strncpy()
 può continuare ad essere usata, ma i buffer di destinazione devono essere
 marchiati con l'attributo `__nonstring <https://gcc.gnu.org/onlinedocs/gcc/Common-Variable-Attributes.html>`_
 per evitare avvisi durante la compilazione.
Signature · 5 lines
2.25.1


-- 
Kees Cook
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Kees Cook

I noticed a double-() after a function name in deprecated.rst today. Fix that one and two others in the Documentation/ tree.

For the RCU hunk:

Or I could take the Documentation/RCU/lockdep.rst portion, if you would prefer.

Quoted 51 lines
---
 Documentation/RCU/lockdep.rst                           | 2 +-
 Documentation/process/deprecated.rst                    | 2 +-
 Documentation/translations/it_IT/process/deprecated.rst | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
Documentation/RCU/lockdep.rst +1 -1
index f1fc8ae3846a..cc860a0c296b 100644
@@ -49,7 +49,7 @@ checking of rcu_dereference() primitives:
 		is invoked by both RCU-sched readers and updaters.
 	srcu_dereference_check(p, c):
 		Use explicit check expression "c" along with
-		srcu_read_lock_held()().  This is useful in code that
+		srcu_read_lock_held().  This is useful in code that
 		is invoked by both SRCU readers and updaters.
 	rcu_dereference_raw(p):
 		Don't check.  (Use sparingly, if at all.)
Documentation/process/deprecated.rst +1 -1
index 4a9aa4f0681e..918e32d76fc4 100644
@@ -142,7 +142,7 @@ only NUL-terminated strings. The safe replacement is strscpy().
 (Users of strscpy() still needing NUL-padding should instead
 use strscpy_pad().)
 
-If a caller is using non-NUL-terminated strings, strncpy()() can
+If a caller is using non-NUL-terminated strings, strncpy() can
 still be used, but destinations should be marked with the `__nonstring
 <https://gcc.gnu.org/onlinedocs/gcc/Common-Variable-Attributes.html>`_
 attribute to avoid future compiler warnings.
Documentation/translations/it_IT/process/deprecated.rst +1 -1
index e108eaf82cf6..a642ff3fdc8b 100644
@@ -130,7 +130,7 @@ chi usa solo stringe terminate. La versione sicura da usare è
 strscpy(). (chi usa strscpy() e necessita di estendere la
 terminazione con NUL deve aggiungere una chiamata a memset())
 
-Se il chiamate no usa stringhe terminate con NUL, allore strncpy()()
+Se il chiamate no usa stringhe terminate con NUL, allore strncpy()
 può continuare ad essere usata, ma i buffer di destinazione devono essere
 marchiati con l'attributo `__nonstring <https://gcc.gnu.org/onlinedocs/gcc/Common-Variable-Attributes.html>`_
 per evitare avvisi durante la compilazione.
Signature · 5 lines
2.25.1


-- 
Kees Cook
maintainer
#2 lore raw
In reply to Kees Cook
Quoted 9 lines · On Fri, 7 Aug 2020 23:49:59 -0700 Kees Cook <[email protected]> wrote:

I noticed a double-() after a function name in deprecated.rst today. Fix that one and two others in the Documentation/ tree.

---
 Documentation/RCU/lockdep.rst                           | 2 +-
 Documentation/process/deprecated.rst                    | 2 +-
 Documentation/translations/it_IT/process/deprecated.rst | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

This one doesn't apply, and it crashes b4 outright. The problem seems to be some sort of encoding confusion...?

Thanks,

jon

author
#3 lore raw
Quoted 13 lines · Jonathan Corbet
Quoted 9 lines · On Fri, 7 Aug 2020 23:49:59 -0700 Kees Cook <[email protected]> wrote:

I noticed a double-() after a function name in deprecated.rst today. Fix that one and two others in the Documentation/ tree.

---
 Documentation/RCU/lockdep.rst                           | 2 +-
 Documentation/process/deprecated.rst                    | 2 +-
 Documentation/translations/it_IT/process/deprecated.rst | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
Quoted 2 lines

This one doesn't apply, and it crashes b4 outright. The problem seems to be some sort of encoding confusion...?

Hmmm. Weird. Something in the translation file? Let me try to re-send.

Signature · 1 line
Kees Cook