mm-slub-make-reclaim_account-attribute-read-only.patch removed from -mm tree
The patch titled
Subject: mm, slub: make reclaim_account attribute read-only
has been removed from the -mm tree. Its filename was
mm-slub-make-reclaim_account-attribute-read-only.patch
This patch was dropped because it was merged into mainline or a subsystem tree
------------------------------------------------------
From: Vlastimil Babka <[email protected]>
Subject: mm, slub: make reclaim_account attribute read-only
The attribute reflects the SLAB_RECLAIM_ACCOUNT cache flag. It's not clear why this attribute was writable in the first place, as it's tied to how the cache is used by its creator, it's not a user tunable. Furthermore:
- it affects slab merging, but that's not being checked while toggled
- if affects whether __GFP_RECLAIMABLE flag is used to allocate page, but the runtime toggle doesn't update allocflags
- it affects cache_vmstat_idx() so runtime toggling might lead to incosistency of NR_SLAB_RECLAIMABLE and NR_SLAB_UNRECLAIMABLE
Thus make it read-only.
---
mm/slub.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-)
mm/slub.c renamed from mm/slub.c~mm-slub-make-reclaim_account-attribute-read-only +1 -10
@@ -5207,16 +5207,7 @@ static ssize_t reclaim_account_show(stru {return sprintf (buf,"%d\n" , !!(s->flags &SLAB_RECLAIM_ACCOUNT )); } - -static ssize_t reclaim_account_store (struct kmem_cache *s, -const char *buf,size_t length) -{ - s->flags &= ~SLAB_RECLAIM_ACCOUNT ; -if (buf[0 ] =='1' ) - s->flags |=SLAB_RECLAIM_ACCOUNT ; -return length; -} -SLAB_ATTR (reclaim_account); +SLAB_ATTR_RO (reclaim_account);static ssize_t hwcache_align_show (struct kmem_cache *s,char *buf) {
_
Patches currently in -mm which might be from [email protected] are