Skip to contentSkip to conversation

mm-filemap-clear-idle-flag-for-writes.patch removed from -mm tree

merged [email protected] 1 participant 1 message Aug 10, 2020

lore
Share & tools
lore

[email protected]

author tree notice Applied
#0 lore raw

The patch titled
Subject: mm: filemap: clear idle flag for writes
has been removed from the -mm tree. Its filename was
mm-filemap-clear-idle-flag-for-writes.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: Yang Shi <[email protected]>
Subject: mm: filemap: clear idle flag for writes

Since commit bbddabe2e436aa ("mm: filemap: only do access activations on reads"), mark_page_accessed() is called for reads only. But the idle flag is cleared by mark_page_accessed() so the idle flag won't get cleared if the page is write accessed only.

Basically idle page tracking is used to estimate workingset size of workload, noticeable size of workingset might be missed if the idle flag is not maintained correctly.

It seems good enough to just clear idle flag for write operations.

Fixes bbddabe2e436 ("mm: filemap: only do access activations on reads")
Cc Johannes Weiner <[email protected]>
Cc Rik van Riel <[email protected]>

---

 mm/filemap.c |    6 ++++++
 1 file changed, 6 insertions(+)
mm/filemap.c renamed from mm/filemap.c~mm-filemap-clear-idle-flag-for-writes +6 -0
@@ -41,6 +41,7 @@
 #include <linux/delayacct.h>
 #include <linux/psi.h>
 #include <linux/ramfs.h>
+#include <linux/page_idle.h>
 #include "internal.h"
 
 #define CREATE_TRACE_POINTS
@@ -1689,6 +1690,11 @@ repeat:
 
 	if (fgp_flags & FGP_ACCESSED)
 		mark_page_accessed(page);
+	else if (fgp_flags & FGP_WRITE) {
+		/* Clear idle flag for buffer write */
+		if (page_is_idle(page))
+			clear_page_idle(page);
+	}
 
 no_page:
 	if (!page && (fgp_flags & FGP_CREAT)) {

_

Patches currently in -mm which might be from [email protected] are

mm-thp-remove-debug_cow-switch.patch