Skip to contentSkip to conversation

locking/rwsem: remove redundant semicolon of down_write_nest_lock

PATCH In review Christian König 2 participants 4 messages Aug 11, 2020 – Aug 12, 2020 Locking primitives

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 locking/rwsem: remove redundant semicolon of down_write_nest_lock

From: Guchun Chen <[email protected]>

Otherwise, braces are needed when using it.

---
 include/linux/rwsem.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/rwsem.h +1 -1
index 7e5b2a4eb560..7a5bf5d50489 100644
@@ -179,7 +179,7 @@ extern void _down_write_nest_lock(struct rw_semaphore *sem, struct lockdep_map *
 do {								\
 	typecheck(struct lockdep_map *, &(nest_lock)->dep_map);	\
 	_down_write_nest_lock(sem, &(nest_lock)->dep_map);	\
-} while (0);
+} while (0)
 
 /*
  * Take/release a lock when not the owner will release it.
Signature · 1 line
2.25.1
#2 lore raw

Am 12.08.20 um 10:10 schrieb [email protected]:

Quoted 8 lines · Christian König
Quoted 6 lines

From: Guchun Chen <[email protected]>

Otherwise, braces are needed when using it.

Thanks!

Do you pick it up or can I push it through drm-misc-fixes?

If the former please let me know when it hits Linus tree since I have a driver which contains some extra {} because of this.

Thanks,
Christian.
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

maintainer Acked-by
#3 lore raw
Quoted 6 lines · Christian König

Am 12.08.20 um 10:10 schrieb [email protected]:

Quoted 5 lines · Christian König
Quoted 4 lines

From: Guchun Chen <[email protected]>

Otherwise, braces are needed when using it.

Quoted 8 lines
Quoted 3 lines
Quoted 2 lines

Thanks!

Do you pick it up or can I push it through drm-misc-fixes?

If the former please let me know when it hits Linus tree since I have a driver which contains some extra {} because of this.

Oh, in that case you can take it:

and I'll drop it from my quilt series.
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel